Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86782/?format=api
{ "id": 86782, "url": "https://patches.dpdk.org/api/patches/86782/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1610968623-31345-2-git-send-email-xuemingl@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1610968623-31345-2-git-send-email-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1610968623-31345-2-git-send-email-xuemingl@nvidia.com", "date": "2021-01-18T11:16:55", "name": "[v4,1/9] ethdev: introduce representor type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "795a81246bcbaad4530f677303d587eba7de7c41", "submitter": { "id": 1904, "url": "https://patches.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1610968623-31345-2-git-send-email-xuemingl@nvidia.com/mbox/", "series": [ { "id": 14809, "url": "https://patches.dpdk.org/api/series/14809/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14809", "date": "2021-01-18T11:16:55", "name": "ethdev: support SubFunction representor", "version": 4, "mbox": "https://patches.dpdk.org/series/14809/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86782/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86782/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 09198A0A03;\n\tMon, 18 Jan 2021 12:17:18 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 72956140D1A;\n\tMon, 18 Jan 2021 12:17:17 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id 0FF00140D17\n for <dev@dpdk.org>; Mon, 18 Jan 2021 12:17:15 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n xuemingl@nvidia.com) with SMTP; 18 Jan 2021 13:17:12 +0200", "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 10IBHBTo021675;\n Mon, 18 Jan 2021 13:17:12 +0200" ], "From": "Xueming Li <xuemingl@nvidia.com>", "To": "Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Olivier Matz <olivier.matz@6wind.com>", "Cc": "dev@dpdk.org, Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n xuemingl@nvidia.com, Asaf Penso <asafp@nvidia.com>", "Date": "Mon, 18 Jan 2021 11:16:55 +0000", "Message-Id": "<1610968623-31345-2-git-send-email-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": [ "<1610968623-31345-1-git-send-email-xuemingl@nvidia.com>", "<1608303356-13089-2-git-send-email-xuemingl@nvidia.com>" ], "References": [ "<1610968623-31345-1-git-send-email-xuemingl@nvidia.com>", "<1608303356-13089-2-git-send-email-xuemingl@nvidia.com>" ], "Subject": "[dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To support more representor type, this patch introduces representor type\nenum. The enum is subject to extend for new types upcoming.\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 7 +++++++\n drivers/net/enic/enic_ethdev.c | 7 +++++++\n drivers/net/i40e/i40e_ethdev.c | 8 ++++++++\n drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++\n drivers/net/mlx5/linux/mlx5_os.c | 11 +++++++++++\n lib/librte_ethdev/ethdev_private.c | 5 +++++\n lib/librte_ethdev/rte_ethdev_driver.h | 9 +++++++++\n 7 files changed, 55 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 74b0f3d1dc..d7c8b3ec07 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -5586,6 +5586,13 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,\n \tint i, ret = 0;\n \tstruct rte_kvargs *kvlist = NULL;\n \n+\tif (eth_da->type == RTE_ETH_REPRESENTOR_NONE)\n+\t\treturn 0;\n+\tif (eth_da->type != RTE_ETH_REPRESENTOR_VF) {\n+\t\tPMD_DRV_LOG(ERR, \"unsupported representor type %d\\n\",\n+\t\t\t eth_da->type);\n+\t\treturn -ENOTSUP;\n+\t}\n \tnum_rep = eth_da->nb_representor_ports;\n \tif (num_rep > BNXT_MAX_VF_REPS) {\n \t\tPMD_DRV_LOG(ERR, \"nb_representor_ports = %d > %d MAX VF REPS\\n\",\ndiff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c\nindex d041a6bee9..dd085caa93 100644\n--- a/drivers/net/enic/enic_ethdev.c\n+++ b/drivers/net/enic/enic_ethdev.c\n@@ -1303,6 +1303,13 @@ static int eth_enic_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\tif (retval)\n \t\t\treturn retval;\n \t}\n+\tif (eth_da.type == RTE_ETH_REPRESENTOR_NONE)\n+\t\treturn 0;\n+\tif (eth_da.type != RTE_ETH_REPRESENTOR_VF) {\n+\t\tENICPMD_LOG(ERR, \"unsupported representor type: %s\\n\",\n+\t\t\t pci_dev->device.devargs->args);\n+\t\treturn -ENOTSUP;\n+\t}\n \tretval = rte_eth_dev_create(&pci_dev->device, pci_dev->device.name,\n \t\tsizeof(struct enic),\n \t\teth_dev_pci_specific_init, pci_dev,\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex c1c2327b3f..3cea6de2bd 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -638,6 +638,14 @@ eth_i40e_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\t\treturn retval;\n \t}\n \n+\tif (eth_da.type == RTE_ETH_REPRESENTOR_NONE)\n+\t\treturn 0;\n+\tif (eth_da.type != RTE_ETH_REPRESENTOR_VF) {\n+\t\tPMD_DRV_LOG(ERR, \"unsupported representor type: %s\\n\",\n+\t\t\t pci_dev->device.devargs->args);\n+\t\treturn -ENOTSUP;\n+\t}\n+\n \tretval = rte_eth_dev_create(&pci_dev->device, pci_dev->device.name,\n \t\tsizeof(struct i40e_adapter),\n \t\teth_dev_pci_specific_init, pci_dev,\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex d7a1806ab8..eb2c4929e2 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1717,6 +1717,14 @@ eth_ixgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t} else\n \t\tmemset(ð_da, 0, sizeof(eth_da));\n \n+\tif (eth_da.type == RTE_ETH_REPRESENTOR_NONE)\n+\t\treturn 0;\n+\tif (eth_da.type != RTE_ETH_REPRESENTOR_VF) {\n+\t\tPMD_DRV_LOG(ERR, \"unsupported representor type: %s\\n\",\n+\t\t\t pci_dev->device.devargs->args);\n+\t\treturn -ENOTSUP;\n+\t}\n+\n \tretval = rte_eth_dev_create(&pci_dev->device, pci_dev->device.name,\n \t\tsizeof(struct ixgbe_adapter),\n \t\teth_dev_pci_specific_init, pci_dev,\ndiff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 9ac1d46b1b..caead107b0 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -705,6 +705,17 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \t\t\t\tstrerror(rte_errno));\n \t\t\treturn NULL;\n \t\t}\n+\t\tif (eth_da.type != RTE_ETH_REPRESENTOR_NONE) {\n+\t\t\t/* Representor not specified. */\n+\t\t\trte_errno = EBUSY;\n+\t\t\treturn NULL;\n+\t\t}\n+\t\tif (eth_da.type != RTE_ETH_REPRESENTOR_VF) {\n+\t\t\trte_errno = ENOTSUP;\n+\t\t\tDRV_LOG(ERR, \"unsupported representor type: %s\",\n+\t\t\t\tdpdk_dev->devargs->args);\n+\t\t\treturn NULL;\n+\t\t}\n \t\tfor (i = 0; i < eth_da.nb_representor_ports; ++i)\n \t\t\tif (eth_da.representor_ports[i] ==\n \t\t\t (uint16_t)switch_info->port_name)\ndiff --git a/lib/librte_ethdev/ethdev_private.c b/lib/librte_ethdev/ethdev_private.c\nindex 162a502fe7..c1a411dba4 100644\n--- a/lib/librte_ethdev/ethdev_private.c\n+++ b/lib/librte_ethdev/ethdev_private.c\n@@ -111,11 +111,16 @@ rte_eth_devargs_process_range(char *str, uint16_t *list, uint16_t *len_list,\n \treturn 0;\n }\n \n+/*\n+ * representor format:\n+ * #: range or single number of VF representor\n+ */\n int\n rte_eth_devargs_parse_representor_ports(char *str, void *data)\n {\n \tstruct rte_eth_devargs *eth_da = data;\n \n+\teth_da->type = RTE_ETH_REPRESENTOR_VF;\n \treturn rte_eth_devargs_process_range(str, eth_da->representor_ports,\n \t\tð_da->nb_representor_ports, RTE_MAX_ETHPORTS);\n }\ndiff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h\nindex 0eacfd8425..3bc5c5bbbb 100644\n--- a/lib/librte_ethdev/rte_ethdev_driver.h\n+++ b/lib/librte_ethdev/rte_ethdev_driver.h\n@@ -1193,6 +1193,14 @@ __rte_internal\n int\n rte_eth_switch_domain_free(uint16_t domain_id);\n \n+/** Ethernet device representor type */\n+enum rte_eth_representor_type {\n+\tRTE_ETH_REPRESENTOR_NONE, /**< not a representor. */\n+\tRTE_ETH_REPRESENTOR_VF, /**< representor of VF. */\n+\tRTE_ETH_REPRESENTOR_SF, /**< representor of SF. */\n+\tRTE_ETH_REPRESENTOR_PF, /**< representor of host PF. */\n+};\n+\n /** Generic Ethernet device arguments */\n struct rte_eth_devargs {\n \tuint16_t ports[RTE_MAX_ETHPORTS];\n@@ -1203,6 +1211,7 @@ struct rte_eth_devargs {\n \t/** representor port/s identifier to enable on device */\n \tuint16_t nb_representor_ports;\n \t/** number of ports in representor port field */\n+\tenum rte_eth_representor_type type; /* type of representor */\n };\n \n /**\n", "prefixes": [ "v4", "1/9" ] }