Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86761/?format=api
{ "id": 86761, "url": "https://patches.dpdk.org/api/patches/86761/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210118070428.36998-21-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210118070428.36998-21-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210118070428.36998-21-stevex.yang@intel.com", "date": "2021-01-18T07:04:26", "name": "[v4,20/22] net/hinic: fix the jumbo frame flag condition for mtu set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d56345057737b5120528cc59596f732ed3e60ddc", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210118070428.36998-21-stevex.yang@intel.com/mbox/", "series": [ { "id": 14800, "url": "https://patches.dpdk.org/api/series/14800/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14800", "date": "2021-01-18T07:04:06", "name": "fix rx packets dropped issue", "version": 4, "mbox": "https://patches.dpdk.org/series/14800/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86761/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86761/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5DC63A0A03;\n\tMon, 18 Jan 2021 08:10:42 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7126E140D22;\n\tMon, 18 Jan 2021 08:09:09 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 56395140D26\n for <dev@dpdk.org>; Mon, 18 Jan 2021 08:09:07 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jan 2021 23:08:54 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jan 2021 23:08:51 -0800" ], "IronPort-SDR": [ "\n ZRAGNF6PRR67sYP2lzWpyymz19oD+NHKbxmcgLlLW73rKvNkwAsypFoMvtxH8LRX2sZz1trtvz\n lIPX1q2Ilauw==", "\n QB39geqCD4WTJLCqG/8hgZwdb9E42p6fpwsQrWbw031n3JfbNHbK/qxe8Yu/B2ieyzhoH/2WNQ\n PMBYYKSTvK0A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9867\"; a=\"197460249\"", "E=Sophos;i=\"5.79,355,1602572400\"; d=\"scan'208\";a=\"197460249\"", "E=Sophos;i=\"5.79,355,1602572400\"; d=\"scan'208\";a=\"355087016\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "Steve Yang <stevex.yang@intel.com>, Ziyang Xuan <xuanziyang2@huawei.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>", "Date": "Mon, 18 Jan 2021 07:04:26 +0000", "Message-Id": "<20210118070428.36998-21-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210118070428.36998-1-stevex.yang@intel.com>", "References": "<20210114094537.13661-1-stevex.yang@intel.com>\n <20210118070428.36998-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 20/22] net/hinic: fix the jumbo frame flag\n condition for mtu set", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition.\nIf the Ether overhead is larger than 18 when it supports VLAN tag,\nthat will cause the jumbo flag rx offload is wrong when MTU size is\n'RTE_ETHER_MTU'.\n\nThis fix will normalize the boundary condition with 'RTE_ETHER_MTU'\nand overhead even though current overhead is 18.\n\nFixes: 254bd849b132 (\"net/hinic: set jumbo frame offload flag\")\n\nCc: Ziyang Xuan <xuanziyang2@huawei.com>\nCc: Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>\nCc: Guoyang Zhou <zhouguoyang@huawei.com>\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\n drivers/net/hinic/hinic_pmd_ethdev.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c\nindex 62642354cf..5a2c171099 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.c\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.c\n@@ -75,6 +75,9 @@\n #define HINIC_PKTLEN_TO_MTU(pktlen)\t\\\n \t((pktlen) - (ETH_HLEN + ETH_CRC_LEN))\n \n+/* The max frame size with default MTU */\n+#define HINIC_ETH_MAX_LEN (RTE_ETHER_MTU + ETH_HLEN + ETH_CRC_LEN)\n+\n /* lro numer limit for one packet */\n #define HINIC_LRO_WQE_NUM_DEFAULT\t8\n \n@@ -1556,7 +1559,7 @@ static int hinic_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)\n \n \t/* update max frame size */\n \tframe_size = HINIC_MTU_TO_PKTLEN(mtu);\n-\tif (frame_size > RTE_ETHER_MAX_LEN)\n+\tif (frame_size > HINIC_ETH_MAX_LEN)\n \t\tdev->data->dev_conf.rxmode.offloads |=\n \t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n \telse\n", "prefixes": [ "v4", "20/22" ] }