Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86759/?format=api
{ "id": 86759, "url": "https://patches.dpdk.org/api/patches/86759/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210118070428.36998-19-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210118070428.36998-19-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210118070428.36998-19-stevex.yang@intel.com", "date": "2021-01-18T07:04:24", "name": "[v4,18/22] net/axgbe: fix the jumbo frame flag condition for mtu set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bc6236a160474de1efd89b051695ef94c62c4e4c", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210118070428.36998-19-stevex.yang@intel.com/mbox/", "series": [ { "id": 14800, "url": "https://patches.dpdk.org/api/series/14800/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14800", "date": "2021-01-18T07:04:06", "name": "fix rx packets dropped issue", "version": 4, "mbox": "https://patches.dpdk.org/series/14800/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86759/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86759/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 00DEFA0A03;\n\tMon, 18 Jan 2021 08:10:27 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C9BF5140DE2;\n\tMon, 18 Jan 2021 08:08:51 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 730D6140D48\n for <dev@dpdk.org>; Mon, 18 Jan 2021 08:08:49 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jan 2021 23:08:49 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jan 2021 23:08:47 -0800" ], "IronPort-SDR": [ "\n l10TZl3ICRqT4MFbi42C5I/Xrw+HiQNnW72speQ8+hkNpzHBjW84tu3NcDvzOccK5hUIDJ1288\n l/KSz2Ho4y8g==", "\n BPsdpbhGCn2VV3Bct1wGibCzHrSXPXHc88qwj3PmAucg9icjfyaHVRuawbBXIYEFg97mvjsU/c\n bylZI3qd3MNQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9867\"; a=\"197460239\"", "E=Sophos;i=\"5.79,355,1602572400\"; d=\"scan'208\";a=\"197460239\"", "E=Sophos;i=\"5.79,355,1602572400\"; d=\"scan'208\";a=\"355086983\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "Steve Yang <stevex.yang@intel.com>,\n Somalapuram Amaranath <asomalap@amd.com>", "Date": "Mon, 18 Jan 2021 07:04:24 +0000", "Message-Id": "<20210118070428.36998-19-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210118070428.36998-1-stevex.yang@intel.com>", "References": "<20210114094537.13661-1-stevex.yang@intel.com>\n <20210118070428.36998-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 18/22] net/axgbe: fix the jumbo frame flag\n condition for mtu set", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition.\nIf the Ether overhead is larger than 18 when it supports VLAN tag,\nthat will cause the jumbo flag rx offload is wrong when MTU size is\n'RTE_ETHER_MTU'.\n\nThis fix will normalize the boundary condition with 'RTE_ETHER_MTU'\nand overhead even though current overhead is 18.\n\nFixes: b58d8781fa1f (\"net/axgbe: support setting MTU\")\n\nCc: Somalapuram Amaranath <asomalap@amd.com>\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\n drivers/net/axgbe/axgbe_ethdev.c | 2 +-\n drivers/net/axgbe/axgbe_ethdev.h | 6 ++++++\n 2 files changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex ddd903680d..ebe9a2876d 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -1490,7 +1490,7 @@ static int axgb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \t\t\t\tdev->data->port_id);\n \t\treturn -EBUSY;\n \t}\n-\tif (frame_size > RTE_ETHER_MAX_LEN) {\n+\tif (frame_size > AXGBE_ETH_MAX_LEN) {\n \t\tdev->data->dev_conf.rxmode.offloads |=\n \t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n \t\tval = 1;\ndiff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h\nindex 1481fd9ff3..a6226729fe 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.h\n+++ b/drivers/net/axgbe/axgbe_ethdev.h\n@@ -125,6 +125,12 @@\n /* MDIO port types */\n #define AXGMAC_MAX_C22_PORT\t\t3\n \n+/* The max frame size with default MTU */\n+#define AXGBE_ETH_MAX_LEN ( \\\n+\tRTE_ETHER_MTU + \\\n+\tRTE_ETHER_HDR_LEN + \\\n+\tRTE_ETHER_CRC_LEN)\n+\n /* Helper macro for descriptor handling\n * Always use AXGBE_GET_DESC_DATA to access the descriptor data\n * since the index is free-running and needs to be and-ed\n", "prefixes": [ "v4", "18/22" ] }