Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86758/?format=api
{ "id": 86758, "url": "https://patches.dpdk.org/api/patches/86758/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210118070428.36998-18-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210118070428.36998-18-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210118070428.36998-18-stevex.yang@intel.com", "date": "2021-01-18T07:04:23", "name": "[v4,17/22] net/cxgbe: fix the jumbo frame flag condition", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "289ada9cfea15e8ee35a50faa0f6219f6bb2e610", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210118070428.36998-18-stevex.yang@intel.com/mbox/", "series": [ { "id": 14800, "url": "https://patches.dpdk.org/api/series/14800/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14800", "date": "2021-01-18T07:04:06", "name": "fix rx packets dropped issue", "version": 4, "mbox": "https://patches.dpdk.org/series/14800/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86758/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86758/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0A7EBA0A03;\n\tMon, 18 Jan 2021 08:10:18 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 123A8140DD6;\n\tMon, 18 Jan 2021 08:08:50 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 66F1B140DD0\n for <dev@dpdk.org>; Mon, 18 Jan 2021 08:08:47 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jan 2021 23:08:47 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jan 2021 23:08:43 -0800" ], "IronPort-SDR": [ "\n omayZ3zGtySR61iJN+/AYT5cZ+SGEkfUAgLObj/u391dY+1go2TCH0jqOCnY6cwbZtX4WqSmz1\n UJ1tDWMrOpNQ==", "\n TCcsrprHTAZlTI/MkN0MOan/tv55Tap0FDRyqkCiC4qWJPGncHBTQ2cwJz6kdkHX1HcW2uZ28u\n C3Pieudh3zZA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9867\"; a=\"197460231\"", "E=Sophos;i=\"5.79,355,1602572400\"; d=\"scan'208\";a=\"197460231\"", "E=Sophos;i=\"5.79,355,1602572400\"; d=\"scan'208\";a=\"355086967\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "Steve Yang <stevex.yang@intel.com>,\n Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>", "Date": "Mon, 18 Jan 2021 07:04:23 +0000", "Message-Id": "<20210118070428.36998-18-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210118070428.36998-1-stevex.yang@intel.com>", "References": "<20210114094537.13661-1-stevex.yang@intel.com>\n <20210118070428.36998-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 17/22] net/cxgbe: fix the jumbo frame flag\n condition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition.\nIf the Ether overhead is larger than 18 when it supports VLAN tag,\nthat will cause the jumbo flag rx offload is wrong when MTU size is\n'RTE_ETHER_MTU'.\n\nThis fix will normalize the boundary condition with 'RTE_ETHER_MTU'\nand overhead even though current overhead is 18.\n\nFixes: 4b2eff452d2e (\"cxgbe: enable jumbo frames\")\nFixes: 0ec33be4c857 (\"cxgbe: allow to change mtu\")\n\nCc: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\n drivers/net/cxgbe/cxgbe.h | 4 ++++\n drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++--\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/cxgbe.h b/drivers/net/cxgbe/cxgbe.h\nindex ef62af1c3f..7c89a028bf 100644\n--- a/drivers/net/cxgbe/cxgbe.h\n+++ b/drivers/net/cxgbe/cxgbe.h\n@@ -19,6 +19,10 @@\n #define CXGBE_MAX_RX_PKTLEN (9000 + RTE_ETHER_HDR_LEN + \\\n \t\t\t\tRTE_ETHER_CRC_LEN) /* max pkt */\n \n+/* The max frame size with default MTU */\n+#define CXGBE_ETH_MAX_LEN (RTE_ETHER_MTU + \\\n+\t\tRTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN)\n+\n /* Max poll time is 100 * 100msec = 10 sec */\n #define CXGBE_LINK_STATUS_POLL_MS 100 /* 100ms */\n #define CXGBE_LINK_STATUS_POLL_CNT 100 /* Max number of times to poll */\ndiff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c\nindex 98d0362fa3..480d6f58a8 100644\n--- a/drivers/net/cxgbe/cxgbe_ethdev.c\n+++ b/drivers/net/cxgbe/cxgbe_ethdev.c\n@@ -300,7 +300,7 @@ int cxgbe_dev_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)\n \t\treturn -EINVAL;\n \n \t/* set to jumbo mode if needed */\n-\tif (new_mtu > RTE_ETHER_MAX_LEN)\n+\tif (new_mtu > CXGBE_ETH_MAX_LEN)\n \t\teth_dev->data->dev_conf.rxmode.offloads |=\n \t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n \telse\n@@ -669,7 +669,7 @@ int cxgbe_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,\n \t\trxq->fl.size = temp_nb_desc;\n \n \t/* Set to jumbo mode if necessary */\n-\tif (pkt_len > RTE_ETHER_MAX_LEN)\n+\tif (pkt_len > CXGBE_ETH_MAX_LEN)\n \t\teth_dev->data->dev_conf.rxmode.offloads |=\n \t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n \telse\n", "prefixes": [ "v4", "17/22" ] }