Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86750/?format=api
{ "id": 86750, "url": "https://patches.dpdk.org/api/patches/86750/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210118070428.36998-10-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210118070428.36998-10-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210118070428.36998-10-stevex.yang@intel.com", "date": "2021-01-18T07:04:15", "name": "[v4,09/22] net/ice: fix the jumbo frame flag condition", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3316120a9d739c4bc15cd4d573d36804857e7e52", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210118070428.36998-10-stevex.yang@intel.com/mbox/", "series": [ { "id": 14800, "url": "https://patches.dpdk.org/api/series/14800/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14800", "date": "2021-01-18T07:04:06", "name": "fix rx packets dropped issue", "version": 4, "mbox": "https://patches.dpdk.org/series/14800/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86750/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86750/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 73EE8A0A03;\n\tMon, 18 Jan 2021 08:09:13 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A2614140D74;\n\tMon, 18 Jan 2021 08:08:30 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id B4CEB140D6B\n for <dev@dpdk.org>; Mon, 18 Jan 2021 08:08:28 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jan 2021 23:08:28 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jan 2021 23:08:26 -0800" ], "IronPort-SDR": [ "\n KbBT6AHIGsK3oGvnVLjQK/NBJmy3C+gtyexF0odlvaNVW/A4dIvFbNzqhUL3W3JuktdGzp9BDP\n 4MvSqnvsZwlQ==", "\n r4wm+WsQyh9Hf9mZ/WBMs4SVkDObVLd2KWRro1npGVf7ea5DEuK2cky0znUCJPf3TLE+6f8DPB\n Mf/20JhdFe9w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9867\"; a=\"197460181\"", "E=Sophos;i=\"5.79,355,1602572400\"; d=\"scan'208\";a=\"197460181\"", "E=Sophos;i=\"5.79,355,1602572400\"; d=\"scan'208\";a=\"355086854\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "Steve Yang <stevex.yang@intel.com>, Qiming Yang <qiming.yang@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>", "Date": "Mon, 18 Jan 2021 07:04:15 +0000", "Message-Id": "<20210118070428.36998-10-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210118070428.36998-1-stevex.yang@intel.com>", "References": "<20210114094537.13661-1-stevex.yang@intel.com>\n <20210118070428.36998-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 09/22] net/ice: fix the jumbo frame flag\n condition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition,\nbut the Ether overhead is larger than 18 when it supports dual VLAN tags.\nThat will cause the jumbo flag rx offload is wrong when MTU size is\n'RTE_ETHER_MTU'.\n\nThis fix will change the boundary condition with 'RTE_ETHER_MTU' and\noverhead, that perhaps impacts the cases of the jumbo frame related.\n\nFixes: 84dc7a95a2d3 (\"net/ice: enable flow director engine\")\nFixes: 1b009275e2c8 (\"net/ice: add Rx queue init in DCF\")\nFixes: ae2bdd0219cb (\"net/ice: support MTU setting\")\nFixes: 50370662b727 (\"net/ice: support device and queue ops\")\n\nCc: Qiming Yang <qiming.yang@intel.com>\nCc: Qi Zhang <qi.z.zhang@intel.com>\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\n drivers/net/ice/ice_dcf_ethdev.c | 8 ++++----\n drivers/net/ice/ice_ethdev.c | 2 +-\n drivers/net/ice/ice_ethdev.h | 1 +\n drivers/net/ice/ice_rxtx.c | 10 +++++-----\n 4 files changed, 11 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c\nindex a9e78064d4..d46734a57b 100644\n--- a/drivers/net/ice/ice_dcf_ethdev.c\n+++ b/drivers/net/ice/ice_dcf_ethdev.c\n@@ -60,23 +60,23 @@ ice_dcf_init_rxq(struct rte_eth_dev *dev, struct ice_rx_queue *rxq)\n \t * correctly.\n \t */\n \tif (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {\n-\t\tif (max_pkt_len <= RTE_ETHER_MAX_LEN ||\n+\t\tif (max_pkt_len <= ICE_ETH_MAX_LEN ||\n \t\t max_pkt_len > ICE_FRAME_SIZE_MAX) {\n \t\t\tPMD_DRV_LOG(ERR, \"maximum packet length must be \"\n \t\t\t\t \"larger than %u and smaller than %u, \"\n \t\t\t\t \"as jumbo frame is enabled\",\n-\t\t\t\t (uint32_t)RTE_ETHER_MAX_LEN,\n+\t\t\t\t (uint32_t)ICE_ETH_MAX_LEN,\n \t\t\t\t (uint32_t)ICE_FRAME_SIZE_MAX);\n \t\t\treturn -EINVAL;\n \t\t}\n \t} else {\n \t\tif (max_pkt_len < RTE_ETHER_MIN_LEN ||\n-\t\t max_pkt_len > RTE_ETHER_MAX_LEN) {\n+\t\t max_pkt_len > ICE_ETH_MAX_LEN) {\n \t\t\tPMD_DRV_LOG(ERR, \"maximum packet length must be \"\n \t\t\t\t \"larger than %u and smaller than %u, \"\n \t\t\t\t \"as jumbo frame is disabled\",\n \t\t\t\t (uint32_t)RTE_ETHER_MIN_LEN,\n-\t\t\t\t (uint32_t)RTE_ETHER_MAX_LEN);\n+\t\t\t\t (uint32_t)ICE_ETH_MAX_LEN);\n \t\t\treturn -EINVAL;\n \t\t}\n \t}\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex e2799a8eb2..ba533a78ee 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -3912,7 +3912,7 @@ ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \t\treturn -EBUSY;\n \t}\n \n-\tif (frame_size > RTE_ETHER_MAX_LEN)\n+\tif (frame_size > ICE_ETH_MAX_LEN)\n \t\tdev_data->dev_conf.rxmode.offloads |=\n \t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n \telse\ndiff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h\nindex 899f446cde..2b03c59671 100644\n--- a/drivers/net/ice/ice_ethdev.h\n+++ b/drivers/net/ice/ice_ethdev.h\n@@ -135,6 +135,7 @@\n */\n #define ICE_ETH_OVERHEAD \\\n \t(RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + ICE_VLAN_TAG_SIZE * 2)\n+#define ICE_ETH_MAX_LEN (RTE_ETHER_MTU + ICE_ETH_OVERHEAD)\n \n #define ICE_RXTX_BYTES_HIGH(bytes) ((bytes) & ~ICE_40_BIT_MASK)\n #define ICE_RXTX_BYTES_LOW(bytes) ((bytes) & ICE_40_BIT_MASK)\ndiff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex d052bd0f1b..c98328ce0b 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -246,23 +246,23 @@ ice_program_hw_rx_queue(struct ice_rx_queue *rxq)\n \t\t\t\t dev->data->dev_conf.rxmode.max_rx_pkt_len);\n \n \tif (rxmode->offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {\n-\t\tif (rxq->max_pkt_len <= RTE_ETHER_MAX_LEN ||\n+\t\tif (rxq->max_pkt_len <= ICE_ETH_MAX_LEN ||\n \t\t rxq->max_pkt_len > ICE_FRAME_SIZE_MAX) {\n \t\t\tPMD_DRV_LOG(ERR, \"maximum packet length must \"\n \t\t\t\t \"be larger than %u and smaller than %u,\"\n \t\t\t\t \"as jumbo frame is enabled\",\n-\t\t\t\t (uint32_t)RTE_ETHER_MAX_LEN,\n+\t\t\t\t (uint32_t)ICE_ETH_MAX_LEN,\n \t\t\t\t (uint32_t)ICE_FRAME_SIZE_MAX);\n \t\t\treturn -EINVAL;\n \t\t}\n \t} else {\n \t\tif (rxq->max_pkt_len < RTE_ETHER_MIN_LEN ||\n-\t\t rxq->max_pkt_len > RTE_ETHER_MAX_LEN) {\n+\t\t rxq->max_pkt_len > ICE_ETH_MAX_LEN) {\n \t\t\tPMD_DRV_LOG(ERR, \"maximum packet length must be \"\n \t\t\t\t \"larger than %u and smaller than %u, \"\n \t\t\t\t \"as jumbo frame is disabled\",\n \t\t\t\t (uint32_t)RTE_ETHER_MIN_LEN,\n-\t\t\t\t (uint32_t)RTE_ETHER_MAX_LEN);\n+\t\t\t\t (uint32_t)ICE_ETH_MAX_LEN);\n \t\t\treturn -EINVAL;\n \t\t}\n \t}\n@@ -701,7 +701,7 @@ ice_fdir_program_hw_rx_queue(struct ice_rx_queue *rxq)\n \trx_ctx.hbuf = rxq->rx_hdr_len >> ICE_RLAN_CTX_HBUF_S;\n \trx_ctx.dtype = 0; /* No Header Split mode */\n \trx_ctx.dsize = 1; /* 32B descriptors */\n-\trx_ctx.rxmax = RTE_ETHER_MAX_LEN;\n+\trx_ctx.rxmax = ICE_ETH_MAX_LEN;\n \t/* TPH: Transaction Layer Packet (TLP) processing hints */\n \trx_ctx.tphrdesc_ena = 1;\n \trx_ctx.tphwdesc_ena = 1;\n", "prefixes": [ "v4", "09/22" ] }