Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86747/?format=api
{ "id": 86747, "url": "https://patches.dpdk.org/api/patches/86747/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210118070428.36998-7-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210118070428.36998-7-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210118070428.36998-7-stevex.yang@intel.com", "date": "2021-01-18T07:04:12", "name": "[v4,06/22] net/hns3: fix the jumbo frame flag condition for mtu set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3f88009d00d28dbe71ccdca302c64dc046c5c4cd", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210118070428.36998-7-stevex.yang@intel.com/mbox/", "series": [ { "id": 14800, "url": "https://patches.dpdk.org/api/series/14800/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14800", "date": "2021-01-18T07:04:06", "name": "fix rx packets dropped issue", "version": 4, "mbox": "https://patches.dpdk.org/series/14800/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86747/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86747/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7DB2AA0A03;\n\tMon, 18 Jan 2021 08:08:49 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CE58A140D38;\n\tMon, 18 Jan 2021 08:08:24 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 4B71B140D59\n for <dev@dpdk.org>; Mon, 18 Jan 2021 08:08:22 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jan 2021 23:08:21 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Jan 2021 23:08:19 -0800" ], "IronPort-SDR": [ "\n TxgjecQ/Y9ftUC3HG94acSc52dDDzZKbc2sg9uwKt7PdicxwErzXaLWikZcA0Y9pQY20QdulAk\n M1fuvUU6R9RA==", "\n 6csucqySJkjhTPxnZGrxdYxt6Nz/mXsYFcS/098CHDH9l0/nBwBpRk8Ia/DarXLi9Tsqncws/5\n AC2v2swPzV6g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9867\"; a=\"197460169\"", "E=Sophos;i=\"5.79,355,1602572400\"; d=\"scan'208\";a=\"197460169\"", "E=Sophos;i=\"5.79,355,1602572400\"; d=\"scan'208\";a=\"355086796\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "Steve Yang <stevex.yang@intel.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>, Lijun Ou <oulijun@huawei.com>", "Date": "Mon, 18 Jan 2021 07:04:12 +0000", "Message-Id": "<20210118070428.36998-7-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210118070428.36998-1-stevex.yang@intel.com>", "References": "<20210114094537.13661-1-stevex.yang@intel.com>\n <20210118070428.36998-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 06/22] net/hns3: fix the jumbo frame flag\n condition for mtu set", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition,\nbut the Ether overhead is larger than 18 when it supports dual VLAN tags.\nThat will cause the jumbo flag rx offload is wrong when MTU size is\n'RTE_ETHER_MTU'.\n\nThis fix will change the boundary condition with 'HSN3_DEFAULT_FRAME_LEN',\nthat perhaps impacts the cases of the jumbo frame related.\n\nFixes: 1f5ca0b460cd (\"net/hns3: support some device operations\")\nFixes: a5475d61fa34 (\"net/hns3: support VF\")\n\nCc: \"Min Hu (Connor)\" <humin29@huawei.com>\nCc: Yisen Zhuang <yisen.zhuang@huawei.com>\nCc: Lijun Ou <oulijun@huawei.com>\n\nAcked-by: Lijun Ou <oulijun@huawei.com>\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 2 +-\n drivers/net/hns3/hns3_ethdev_vf.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 7c34e382fb..10e0c0de46 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2467,7 +2467,7 @@ hns3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \t}\n \n \trte_spinlock_lock(&hw->lock);\n-\tis_jumbo_frame = frame_size > RTE_ETHER_MAX_LEN ? true : false;\n+\tis_jumbo_frame = frame_size > HNS3_DEFAULT_FRAME_LEN ? true : false;\n \tframe_size = RTE_MAX(frame_size, HNS3_DEFAULT_FRAME_LEN);\n \n \t/*\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex f09cabcd82..ef03fb1c4e 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -928,7 +928,7 @@ hns3vf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \t\trte_spinlock_unlock(&hw->lock);\n \t\treturn ret;\n \t}\n-\tif (frame_size > RTE_ETHER_MAX_LEN)\n+\tif (mtu > RTE_ETHER_MTU)\n \t\tdev->data->dev_conf.rxmode.offloads |=\n \t\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n \telse\n", "prefixes": [ "v4", "06/22" ] }