Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86664/?format=api
{ "id": 86664, "url": "https://patches.dpdk.org/api/patches/86664/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210115100829.31980-1-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210115100829.31980-1-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210115100829.31980-1-alvinx.zhang@intel.com", "date": "2021-01-15T10:08:29", "name": "[v4] net/ixgbe: fix configuration of max frame size", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b96224d56d93308fef93d1742c576dbfa61f2cd4", "submitter": { "id": 1398, "url": "https://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210115100829.31980-1-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 14776, "url": "https://patches.dpdk.org/api/series/14776/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14776", "date": "2021-01-15T10:08:29", "name": "[v4] net/ixgbe: fix configuration of max frame size", "version": 4, "mbox": "https://patches.dpdk.org/series/14776/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86664/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/86664/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 608F7A0A02;\n\tFri, 15 Jan 2021 11:08:42 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BF927140E55;\n\tFri, 15 Jan 2021 11:08:41 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 77091140E53;\n Fri, 15 Jan 2021 11:08:39 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Jan 2021 02:08:36 -0800", "from shwdenpg235.ccr.corp.intel.com ([10.240.182.60])\n by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Jan 2021 02:08:34 -0800" ], "IronPort-SDR": [ "\n C62QCAHP0kalCyqnyaYI0nakMBMSl+PDxg3mLLZ6qhER9t9sU6piEgHGrQ3b57bluMzA+H12L1\n dSCBfnQtAjJA==", "\n 2ESRtJk9I4wWqfmuSeDM9qTJmU192NfVoWnn2Ckw2caJ6VRu4t6F9CRqlO9V1GHYlC69F+bnBm\n pbnR9nsS+hjg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9864\"; a=\"178614931\"", "E=Sophos;i=\"5.79,349,1602572400\"; d=\"scan'208\";a=\"178614931\"", "E=Sophos;i=\"5.79,349,1602572400\"; d=\"scan'208\";a=\"401238266\"" ], "From": "\"Zhang,Alvin\" <alvinx.zhang@intel.com>", "To": "jia.guo@intel.com,\n\tWeiX.Xie@intel.com,\n\thaiyue.wang@intel.com", "Cc": "dev@dpdk.org,\n\tAlvin Zhang <alvinx.zhang@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 15 Jan 2021 18:08:29 +0800", "Message-Id": "<20210115100829.31980-1-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20210115070029.2768-1-alvinx.zhang@intel.com>", "References": "<20210115070029.2768-1-alvinx.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4] net/ixgbe: fix configuration of max frame size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Alvin Zhang <alvinx.zhang@intel.com>\n\nFor 82599 NIC, jumbo frame feature is not supported in IOV mode,\nif a VF requests to configure the max frame size to that not\nbigger than RTE_ETHER_MAX_LEN, the kernel driver returns 0, but\nthe DPDK ixgbe PMD returens -1, this will cause the VF to fail\nto start when the PF driven by DPDK ixgbe PMD.\n\nThis patch keeps ixgbe PMD's handling mode consistent with kernel\ndriver in above situation.\n\nIn addition, the value set by the command IXGBE_VF_SET_LPE\nrepresents the max frame size, not the mtu.\n\nFixes: 1b9ea09c067b (\"ixgbe: support X550\")\nFixes: 95a27b3ba5f5 (\"net/ixgbe: enable jumbo frame for VF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n---\n\nV3: Restore variable name from cur_frame_size to max_frs.\nV4: Update git log and add notes.\n---\n drivers/net/ixgbe/ixgbe_pf.c | 23 ++++++++++++++++-------\n 1 file changed, 16 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c\nindex 833863a..911a145 100644\n--- a/drivers/net/ixgbe/ixgbe_pf.c\n+++ b/drivers/net/ixgbe/ixgbe_pf.c\n@@ -555,17 +555,26 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev)\n ixgbe_set_vf_lpe(struct rte_eth_dev *dev, __rte_unused uint32_t vf, uint32_t *msgbuf)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tuint32_t new_mtu = msgbuf[1];\n+\tuint32_t max_frame = msgbuf[1];\n \tuint32_t max_frs;\n \tuint32_t hlreg0;\n-\tint max_frame = new_mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;\n \n \t/* X540 and X550 support jumbo frames in IOV mode */\n \tif (hw->mac.type != ixgbe_mac_X540 &&\n \t\thw->mac.type != ixgbe_mac_X550 &&\n \t\thw->mac.type != ixgbe_mac_X550EM_x &&\n-\t\thw->mac.type != ixgbe_mac_X550EM_a)\n-\t\treturn -1;\n+\t\thw->mac.type != ixgbe_mac_X550EM_a) {\n+\t\t/**\n+\t\t * For Other NICs, set max packet length is not enabled,\n+\t\t * but if the value is not bigger than that has been set\n+\t\t * by PF, here return -1 will cause the VF to fail to\n+\t\t * start.\n+\t\t */\n+\t\tif (max_frame > dev->data->dev_conf.rxmode.max_rx_pkt_len)\n+\t\t\treturn -1;\n+\n+\t\treturn 0;\n+\t}\n \n \tif (max_frame < RTE_ETHER_MIN_LEN ||\n \t\t\tmax_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)\n@@ -573,9 +582,9 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev)\n \n \tmax_frs = (IXGBE_READ_REG(hw, IXGBE_MAXFRS) &\n \t\t IXGBE_MHADD_MFS_MASK) >> IXGBE_MHADD_MFS_SHIFT;\n-\tif (max_frs < new_mtu) {\n+\tif (max_frs < max_frame) {\n \t\thlreg0 = IXGBE_READ_REG(hw, IXGBE_HLREG0);\n-\t\tif (new_mtu > RTE_ETHER_MAX_LEN) {\n+\t\tif (max_frame > RTE_ETHER_MAX_LEN) {\n \t\t\tdev->data->dev_conf.rxmode.offloads |=\n \t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n \t\t\thlreg0 |= IXGBE_HLREG0_JUMBOEN;\n@@ -586,7 +595,7 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev)\n \t\t}\n \t\tIXGBE_WRITE_REG(hw, IXGBE_HLREG0, hlreg0);\n \n-\t\tmax_frs = new_mtu << IXGBE_MHADD_MFS_SHIFT;\n+\t\tmax_frs = max_frame << IXGBE_MHADD_MFS_SHIFT;\n \t\tIXGBE_WRITE_REG(hw, IXGBE_MAXFRS, max_frs);\n \t}\n \n", "prefixes": [ "v4" ] }