Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86662/?format=api
{ "id": 86662, "url": "https://patches.dpdk.org/api/patches/86662/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210115083411.9324-1-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210115083411.9324-1-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210115083411.9324-1-alvinx.zhang@intel.com", "date": "2021-01-15T08:34:11", "name": "[v2] net/i40e: fix out-of-scope variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d7f1c762c6e37ba02b9ac62dbb87bcbdb27f7fe2", "submitter": { "id": 1398, "url": "https://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210115083411.9324-1-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 14774, "url": "https://patches.dpdk.org/api/series/14774/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14774", "date": "2021-01-15T08:34:11", "name": "[v2] net/i40e: fix out-of-scope variable", "version": 2, "mbox": "https://patches.dpdk.org/series/14774/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86662/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/86662/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A094BA0A02;\n\tFri, 15 Jan 2021 09:34:27 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5631A140DD4;\n\tFri, 15 Jan 2021 09:34:27 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id E488A140DCD\n for <dev@dpdk.org>; Fri, 15 Jan 2021 09:34:25 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Jan 2021 00:34:20 -0800", "from shwdenpg235.ccr.corp.intel.com ([10.240.182.60])\n by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Jan 2021 00:34:16 -0800" ], "IronPort-SDR": [ "\n 3t3ih6nuFhayQM4iql19kTOuYns83HILflpfXcKzqP+i08scg+HphdCevcd/oTIG6Bg3Ceb0Ny\n yu4ATqYZP4MQ==", "\n zh0nHZnWHyBD3A7D+ds7g1SZVW3Bf8bLuZgEpAPtyJhF/gRcgcKIsChqUtV0G/4gcnp3ea4MGf\n 7eByIXm9eEjg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9864\"; a=\"165604631\"", "E=Sophos;i=\"5.79,348,1602572400\"; d=\"scan'208\";a=\"165604631\"", "E=Sophos;i=\"5.79,348,1602572400\"; d=\"scan'208\";a=\"401219068\"" ], "From": "\"Zhang,Alvin\" <alvinx.zhang@intel.com>", "To": "jia.guo@intel.com,\n\tWeiX.Xie@intel.com", "Cc": "dev@dpdk.org,\n\tAlvin Zhang <alvinx.zhang@intel.com>", "Date": "Fri, 15 Jan 2021 16:34:11 +0800", "Message-Id": "<20210115083411.9324-1-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20210114065248.17160-1-alvinx.zhang@intel.com>", "References": "<20210114065248.17160-1-alvinx.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: fix out-of-scope variable", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Alvin Zhang <alvinx.zhang@intel.com>\n\nUsing \"key\", which points to an out-of-scope variable \"rss_key_default\".\n\nCoverity issue: 365293\nFixes: ef4c16fd9148 (\"net/i40e: refactor RSS flow\")\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n---\n\nV2: Update the commit log.\n---\n drivers/net/i40e/i40e_hash.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c\nindex e07f806..83a9af5 100644\n--- a/drivers/net/i40e/i40e_hash.c\n+++ b/drivers/net/i40e/i40e_hash.c\n@@ -901,10 +901,12 @@ struct i40e_hash_match_pattern {\n \t\t\tPMD_DRV_LOG(WARNING,\n \t\t\t\t \"RSS key length invalid, must be %u bytes, now set key to default\",\n \t\t\t\t (uint32_t)sizeof(rss_conf->key));\n-\t\tkey = (const uint8_t *)rss_key_default;\n+\n+\t\tmemcpy(rss_conf->key, rss_key_default, sizeof(rss_conf->key));\n+\t} else {\n+\t\tmemcpy(rss_conf->key, key, sizeof(rss_conf->key));\n \t}\n \n-\tmemcpy(rss_conf->key, key, sizeof(rss_conf->key));\n \trss_conf->conf.key = rss_conf->key;\n \trss_conf->conf.key_len = sizeof(rss_conf->key);\n }\n", "prefixes": [ "v2" ] }