Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86583/?format=api
{ "id": 86583, "url": "https://patches.dpdk.org/api/patches/86583/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210114103101.738262-2-feifei.wang2@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210114103101.738262-2-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210114103101.738262-2-feifei.wang2@arm.com", "date": "2021-01-14T10:30:59", "name": "[v4,1/3] doc: fix core enabled bug for eventdev pipeline example", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f1bfcbdc568e8184fb29fbd21230fe15a4e7cc77", "submitter": { "id": 1771, "url": "https://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210114103101.738262-2-feifei.wang2@arm.com/mbox/", "series": [ { "id": 14749, "url": "https://patches.dpdk.org/api/series/14749/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14749", "date": "2021-01-14T10:30:58", "name": "fix bugs for examples/evnentdev", "version": 4, "mbox": "https://patches.dpdk.org/series/14749/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86583/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86583/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B8EB2A0A02;\n\tThu, 14 Jan 2021 11:31:19 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7964D1410EB;\n\tThu, 14 Jan 2021 11:31:18 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 40E481410E2;\n Thu, 14 Jan 2021 11:31:16 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC1351FB;\n Thu, 14 Jan 2021 02:31:15 -0800 (PST)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.127])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B99D23F70D;\n Thu, 14 Jan 2021 02:31:12 -0800 (PST)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Harry van Haaren <harry.van.haaren@intel.com>,\n David Hunt <david.hunt@intel.com>,\n Jerin Jacob <jerin.jacob@caviumnetworks.com>,\n John McNamara <john.mcnamara@intel.com>", "Cc": "dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,\n stable@dpdk.org, Ruifeng Wang <ruifeng.wang@arm.com>", "Date": "Thu, 14 Jan 2021 18:30:59 +0800", "Message-Id": "<20210114103101.738262-2-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210114103101.738262-1-feifei.wang2@arm.com>", "References": "<20201221053454.47307-1-feifei.wang2@arm.com>\n <20210114103101.738262-1-feifei.wang2@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 1/3] doc: fix core enabled bug for eventdev\n pipeline example", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In the case that the cores are isolated, if \"-l\" or \"-c\" parameter is not\nadded, the cores will not be enabled and can not launch worker function\ncorrectly. In the meanwhile, no error information is reported.\n\nFor example:\ntotally CPUs:16\nisolated CPUs:1-8\ncommand: sudo gdb -args ./dpdk-eventdev_pipeline --vdev event_sw0 \\\n -- -r1 -t1 -e4 -w F00 -s4 -n0 -c32 -W1000 -D\n\ncores information:\nrte_config->lcore_role = {ROLE_RTE, ROLE_OFF, ROLE_OFF, ROLE_OFF,\n ROLE_OFF, ROLE_OFF, ROLE_OFF, ROLE_OFF,\n ROLE_OFF, ROLE_RTE, ROLE_RTE, ROLE_RTE,\n ROLE_RTE, ROLE_RTE, ROLE_RTE, ROLE_RTE}\n\noutput information:\n...\n[main()] lcore 9 executing worker, using eventdev port 0\n[main()] lcore 10 executing worker, using eventdev port 1\n[main()] lcore 11 executing worker, using eventdev port 2\n\nThis is because \"RTE_LCORE_FOREACH_WORKER\" chooses the enabled core. In\nthe case that the cores are isolated, \"the lcore_role\" flag of isolated\ncores are set as \"ROLE_OFF\" by default(not enabled). So if we choose\nthese isolated cores as workers, \"RTE_LCORE_FOREACH_WORKER\" will ignore\nthese cores and not launch worker functions on them.\n\nTo fix this, add \"-l\" parameters to doc and add lcore enabled check.\n\nFixes: 1094ca96689c (\"doc: add SW eventdev pipeline to sample app guide\")\nCc: harry.van.haaren@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n doc/guides/sample_app_ug/eventdev_pipeline.rst | 5 +++--\n examples/eventdev_pipeline/main.c | 7 ++++++-\n 2 files changed, 9 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/sample_app_ug/eventdev_pipeline.rst b/doc/guides/sample_app_ug/eventdev_pipeline.rst\nindex 4508c3dcc..19ff53803 100644\n--- a/doc/guides/sample_app_ug/eventdev_pipeline.rst\n+++ b/doc/guides/sample_app_ug/eventdev_pipeline.rst\n@@ -34,6 +34,7 @@ options.\n An example eventdev pipeline running with the software eventdev PMD using\n these settings is shown below:\n \n+ * ``-l 0,2,8-15``: lcore to use\n * ``-r1``: core mask 0x1 for RX\n * ``-t1``: core mask 0x1 for TX\n * ``-e4``: core mask 0x4 for the software scheduler\n@@ -46,8 +47,8 @@ these settings is shown below:\n \n .. code-block:: console\n \n- ./<build_dir>/examples/dpdk-eventdev_pipeline --vdev event_sw0 -- -r1 -t1 \\\n- -e4 -w FF00 -s4 -n0 -c32 -W1000 -D\n+ ./<build_dir>/examples/dpdk-eventdev_pipeline -l 0,2,8-15 --vdev event_sw0 \\\n+ -- -r1 -t1 -e4 -w FF00 -s4 -n0 -c32 -W1000 -D\n \n The application has some sanity checking built-in, so if there is a function\n (e.g.; the RX core) which doesn't have a cpu core mask assigned, the application\ndiff --git a/examples/eventdev_pipeline/main.c b/examples/eventdev_pipeline/main.c\nindex 823f8b51c..e9a591134 100644\n--- a/examples/eventdev_pipeline/main.c\n+++ b/examples/eventdev_pipeline/main.c\n@@ -239,8 +239,13 @@ parse_app_args(int argc, char **argv)\n \n \t\tif (fdata->worker_core[i])\n \t\t\tcdata.num_workers++;\n-\t\tif (core_in_use(i))\n+\t\tif (core_in_use(i)) {\n+\t\t\tif (!rte_lcore_is_enabled(i)) {\n+\t\t\t\tprintf(\"error: lcore %d is not enabled in lcore list\\n\", i);\n+\t\t\t\trte_exit(EXIT_FAILURE, \"check lcore params failed\\n\");\n+\t\t\t}\n \t\t\tcdata.active_cores++;\n+\t\t}\n \t}\n }\n \n", "prefixes": [ "v4", "1/3" ] }