Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86555/?format=api
{ "id": 86555, "url": "https://patches.dpdk.org/api/patches/86555/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1610609088-204833-3-git-send-email-jiaweiw@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1610609088-204833-3-git-send-email-jiaweiw@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1610609088-204833-3-git-send-email-jiaweiw@nvidia.com", "date": "2021-01-14T07:24:46", "name": "[v3,2/4] net/mlx5: fix the unnecessary checking for RSS action", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "578d7470a245452e2c8fbc0b0cedd91aa62f351e", "submitter": { "id": 1939, "url": "https://patches.dpdk.org/api/people/1939/?format=api", "name": "Jiawei Wang", "email": "jiaweiw@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1610609088-204833-3-git-send-email-jiaweiw@nvidia.com/mbox/", "series": [ { "id": 14722, "url": "https://patches.dpdk.org/api/series/14722/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14722", "date": "2021-01-14T07:24:47", "name": "Add RSS action support in the sample sub-actions list", "version": 3, "mbox": "https://patches.dpdk.org/series/14722/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86555/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86555/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 04CBDA0A02;\n\tThu, 14 Jan 2021 08:25:26 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 328BD140FA7;\n\tThu, 14 Jan 2021 08:25:01 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id 98E47140F98\n for <dev@dpdk.org>; Thu, 14 Jan 2021 08:24:54 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n jiaweiw@nvidia.com) with SMTP; 14 Jan 2021 09:24:48 +0200", "from nvidia.com (gen-l-vrt-281.mtl.labs.mlnx [10.237.44.1])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 10E7OmcW001294;\n Thu, 14 Jan 2021 09:24:48 +0200" ], "From": "Jiawei Wang <jiaweiw@nvidia.com>", "To": "ferruh.yigit@intel.com, viacheslavo@nvidia.com, matan@nvidia.com,\n orika@nvidia.com", "Cc": "dev@dpdk.org, rasland@nvidia.com, stable@dpdk.org", "Date": "Thu, 14 Jan 2021 09:24:46 +0200", "Message-Id": "<1610609088-204833-3-git-send-email-jiaweiw@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1610609088-204833-1-git-send-email-jiaweiw@nvidia.com>", "References": "<1610445689-389472-1-git-send-email-jiaweiw@nvidia.com>\n <1610609088-204833-1-git-send-email-jiaweiw@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v3 2/4] net/mlx5: fix the unnecessary checking\n for RSS action", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "RSS action is valid only in NIC-RX domain, this fix bypass\nthe function that getting RSS action from the flow action list\nunder no NIC-RX domain.\n\nFixes: e745f90 (\"net/mlx5: optimize flow RSS struct\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawei Wang <jiaweiw@nvidia.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 2a4073c..0670447 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -5278,7 +5278,7 @@ struct mlx5_hlist_entry *\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tstruct rte_flow *flow = NULL;\n \tstruct mlx5_flow *dev_flow;\n-\tconst struct rte_flow_action_rss *rss;\n+\tconst struct rte_flow_action_rss *rss = NULL;\n \tstruct mlx5_translated_shared_action\n \t\tshared_actions[MLX5_MAX_SHARED_ACTIONS];\n \tint shared_actions_n = MLX5_MAX_SHARED_ACTIONS;\n@@ -5356,7 +5356,9 @@ struct mlx5_hlist_entry *\n \tMLX5_ASSERT(flow->drv_type > MLX5_FLOW_TYPE_MIN &&\n \t\t flow->drv_type < MLX5_FLOW_TYPE_MAX);\n \tmemset(rss_desc, 0, offsetof(struct mlx5_flow_rss_desc, queue));\n-\trss = flow_get_rss_action(p_actions_rx);\n+\t/* RSS Action only works on NIC RX domain */\n+\tif (attr->ingress && !attr->transfer)\n+\t\trss = flow_get_rss_action(p_actions_rx);\n \tif (rss) {\n \t\tif (flow_rss_workspace_adjust(wks, rss_desc, rss->queue_num))\n \t\t\treturn 0;\n", "prefixes": [ "v3", "2/4" ] }