Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 86527,
    "url": "https://patches.dpdk.org/api/patches/86527/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210114065926.1200855-5-ruifeng.wang@arm.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210114065926.1200855-5-ruifeng.wang@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210114065926.1200855-5-ruifeng.wang@arm.com",
    "date": "2021-01-14T06:59:25",
    "name": "[v2,4/4] test/lpm: improve coverage on tbl8",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "976e8424857a58d9a0fec9986ec05c471d94ca44",
    "submitter": {
        "id": 1198,
        "url": "https://patches.dpdk.org/api/people/1198/?format=api",
        "name": "Ruifeng Wang",
        "email": "ruifeng.wang@arm.com"
    },
    "delegate": {
        "id": 24651,
        "url": "https://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210114065926.1200855-5-ruifeng.wang@arm.com/mbox/",
    "series": [
        {
            "id": 14715,
            "url": "https://patches.dpdk.org/api/series/14715/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14715",
            "date": "2021-01-14T06:59:21",
            "name": "lpm lookupx4 fixes",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/14715/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/86527/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/86527/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AE739A0A02;\n\tThu, 14 Jan 2021 08:01:29 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A9F7D140ED5;\n\tThu, 14 Jan 2021 08:00:17 +0100 (CET)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id E5DCD140ECC\n for <dev@dpdk.org>; Thu, 14 Jan 2021 08:00:15 +0100 (CET)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D7091FB;\n Wed, 13 Jan 2021 23:00:15 -0800 (PST)",
            "from net-arm-n1amp-01.shanghai.arm.com\n (net-arm-n1amp-01.shanghai.arm.com [10.169.208.220])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BB0C03F719;\n Wed, 13 Jan 2021 23:00:12 -0800 (PST)"
        ],
        "From": "Ruifeng Wang <ruifeng.wang@arm.com>",
        "To": "Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>",
        "Cc": "dev@dpdk.org, nd@arm.com, jerinj@marvell.com, drc@linux.vnet.ibm.com,\n honnappa.nagarahalli@arm.com, Ruifeng Wang <ruifeng.wang@arm.com>",
        "Date": "Thu, 14 Jan 2021 06:59:25 +0000",
        "Message-Id": "<20210114065926.1200855-5-ruifeng.wang@arm.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20210114065926.1200855-1-ruifeng.wang@arm.com>",
        "References": "<20210108082127.1061538-1-ruifeng.wang@arm.com>\n <20210114065926.1200855-1-ruifeng.wang@arm.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2 4/4] test/lpm: improve coverage on tbl8",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Existing test cases create 256 tbl8 groups for testing. The number covers\nonly 8 bit next_hop/group field. Since the next_hop/group field had been\nextended to 24-bits, creating more than 256 groups in tests can improve\nthe coverage.\n\nCoverage was not expanded to reach the max supported group number, because\nit would take too much time to run for this fast-test.\n\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\nTested-by: David Christensen <drc@linux.vnet.ibm.com>\nAcked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>\n---\nv2:\nCheck all 4 returned next hops. (Vladimir)\n\n app/test/test_lpm.c | 25 +++++++++++++++++--------\n 1 file changed, 17 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/app/test/test_lpm.c b/app/test/test_lpm.c\nindex 258b2f67c..556f5a67b 100644\n--- a/app/test/test_lpm.c\n+++ b/app/test/test_lpm.c\n@@ -993,7 +993,7 @@ test13(void)\n }\n \n /*\n- * Fore TBL8 extension exhaustion. Add 256 rules that require a tbl8 extension.\n+ * For TBL8 extension exhaustion. Add 512 rules that require a tbl8 extension.\n  * No more tbl8 extensions will be allowed. Now add one more rule that required\n  * a tbl8 extension and get fail.\n  * */\n@@ -1008,28 +1008,37 @@ test14(void)\n \tstruct rte_lpm_config config;\n \n \tconfig.max_rules = 256 * 32;\n-\tconfig.number_tbl8s = NUMBER_TBL8S;\n+\tconfig.number_tbl8s = 512;\n \tconfig.flags = 0;\n-\tuint32_t ip, next_hop_add, next_hop_return;\n+\tuint32_t ip, next_hop_base, next_hop_return;\n \tuint8_t depth;\n \tint32_t status = 0;\n+\txmm_t ipx4;\n+\tuint32_t hop[4];\n \n \t/* Add enough space for 256 rules for every depth */\n \tlpm = rte_lpm_create(__func__, SOCKET_ID_ANY, &config);\n \tTEST_LPM_ASSERT(lpm != NULL);\n \n \tdepth = 32;\n-\tnext_hop_add = 100;\n+\tnext_hop_base = 100;\n \tip = RTE_IPV4(0, 0, 0, 0);\n \n \t/* Add 256 rules that require a tbl8 extension */\n-\tfor (; ip <= RTE_IPV4(0, 0, 255, 0); ip += 256) {\n-\t\tstatus = rte_lpm_add(lpm, ip, depth, next_hop_add);\n+\tfor (; ip <= RTE_IPV4(0, 1, 255, 0); ip += 256) {\n+\t\tstatus = rte_lpm_add(lpm, ip, depth, next_hop_base + ip);\n \t\tTEST_LPM_ASSERT(status == 0);\n \n \t\tstatus = rte_lpm_lookup(lpm, ip, &next_hop_return);\n \t\tTEST_LPM_ASSERT((status == 0) &&\n-\t\t\t\t(next_hop_return == next_hop_add));\n+\t\t\t\t(next_hop_return == next_hop_base + ip));\n+\n+\t\tipx4 = vect_set_epi32(ip + 3, ip + 2, ip + 1, ip);\n+\t\trte_lpm_lookupx4(lpm, ipx4, hop, UINT32_MAX);\n+\t\tTEST_LPM_ASSERT(hop[0] == next_hop_base + ip);\n+\t\tTEST_LPM_ASSERT(hop[1] == UINT32_MAX);\n+\t\tTEST_LPM_ASSERT(hop[2] == UINT32_MAX);\n+\t\tTEST_LPM_ASSERT(hop[3] == UINT32_MAX);\n \t}\n \n \t/* All tbl8 extensions have been used above. Try to add one more and\n@@ -1037,7 +1046,7 @@ test14(void)\n \tip = RTE_IPV4(1, 0, 0, 0);\n \tdepth = 32;\n \n-\tstatus = rte_lpm_add(lpm, ip, depth, next_hop_add);\n+\tstatus = rte_lpm_add(lpm, ip, depth, next_hop_base + ip);\n \tTEST_LPM_ASSERT(status < 0);\n \n \trte_lpm_free(lpm);\n",
    "prefixes": [
        "v2",
        "4/4"
    ]
}