Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 8631,
    "url": "https://patches.dpdk.org/api/patches/8631/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1446617263-7448-10-git-send-email-cunming.liang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1446617263-7448-10-git-send-email-cunming.liang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1446617263-7448-10-git-send-email-cunming.liang@intel.com",
    "date": "2015-11-04T06:07:39",
    "name": "[dpdk-dev,v3,09/13] ixgbe: fix unnecessary intr_vec free in dev_close",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "60dbd655fb3edcd0d3cbc506f219ce416137dc58",
    "submitter": {
        "id": 46,
        "url": "https://patches.dpdk.org/api/people/46/?format=api",
        "name": "Cunming Liang",
        "email": "cunming.liang@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1446617263-7448-10-git-send-email-cunming.liang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/8631/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/8631/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4AA9491BF;\n\tWed,  4 Nov 2015 07:08:18 +0100 (CET)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 790CE91B0\n\tfor <dev@dpdk.org>; Wed,  4 Nov 2015 07:08:16 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP; 03 Nov 2015 22:08:17 -0800",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 03 Nov 2015 22:08:15 -0800",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id tA468Aw9010129;\n\tWed, 4 Nov 2015 14:08:10 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid tA4687Cc007563; Wed, 4 Nov 2015 14:08:09 +0800",
            "(from cliang18@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id tA46871q007559; \n\tWed, 4 Nov 2015 14:08:07 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.20,241,1444719600\"; d=\"scan'208\";a=\"811315222\"",
        "From": "Cunming Liang <cunming.liang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Wed,  4 Nov 2015 14:07:39 +0800",
        "Message-Id": "<1446617263-7448-10-git-send-email-cunming.liang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1446617263-7448-1-git-send-email-cunming.liang@intel.com>",
        "References": "<1446182873-28814-2-git-send-email-cunming.liang@intel.com>\n\t<1446617263-7448-1-git-send-email-cunming.liang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3 09/13] ixgbe: fix unnecessary intr_vec free in\n\tdev_close",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The intr_vec is free in dev_stop. It's not necessary to check in dev_close.\n\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 7 -------\n 1 file changed, 7 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 6b075f6..d5556cc 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -3952,7 +3952,6 @@ static void\n ixgbevf_dev_close(struct rte_eth_dev *dev)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct rte_pci_device *pci_dev;\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -3964,12 +3963,6 @@ ixgbevf_dev_close(struct rte_eth_dev *dev)\n \n \t/* reprogram the RAR[0] in case user changed it. */\n \tixgbe_set_rar(hw, 0, hw->mac.addr, 0, IXGBE_RAH_AV);\n-\n-\tpci_dev = dev->pci_dev;\n-\tif (pci_dev->intr_handle.intr_vec) {\n-\t\trte_free(pci_dev->intr_handle.intr_vec);\n-\t\tpci_dev->intr_handle.intr_vec = NULL;\n-\t}\n }\n \n static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "09/13"
    ]
}