Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86251/?format=api
https://patches.dpdk.org/api/patches/86251/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210110111023.9525-6-ophirmu@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210110111023.9525-6-ophirmu@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210110111023.9525-6-ophirmu@nvidia.com", "date": "2021-01-10T11:10:22", "name": "[v3,5/6] app/regex: support performance measurements per QP", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "552fc3fc09457a019f0838e36b104165c399250c", "submitter": { "id": 1908, "url": "https://patches.dpdk.org/api/people/1908/?format=api", "name": "Ophir Munk", "email": "ophirmu@nvidia.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210110111023.9525-6-ophirmu@nvidia.com/mbox/", "series": [ { "id": 14620, "url": "https://patches.dpdk.org/api/series/14620/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14620", "date": "2021-01-10T11:10:19", "name": "regex multi Q with multi cores support", "version": 3, "mbox": "https://patches.dpdk.org/series/14620/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86251/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86251/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 028EAA04B5;\n\tSun, 10 Jan 2021 12:10:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 60764140F85;\n\tSun, 10 Jan 2021 12:10:32 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id ADE2D140F6B\n for <dev@dpdk.org>; Sun, 10 Jan 2021 12:10:30 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n ophirmu@nvidia.com) with SMTP; 10 Jan 2021 13:10:25 +0200", "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 10ABAOOo032562;\n Sun, 10 Jan 2021 13:10:25 +0200" ], "From": "Ophir Munk <ophirmu@nvidia.com>", "To": "dev@dpdk.org", "Cc": "Ori Kam <orika@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>,\n Ophir Munk <ophirmu@mellanox.com>", "Date": "Sun, 10 Jan 2021 11:10:22 +0000", "Message-Id": "<20210110111023.9525-6-ophirmu@nvidia.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20210110111023.9525-1-ophirmu@nvidia.com>", "References": "<20201220104148.13961-2-ophirmu@nvidia.com>\n <20210110111023.9525-1-ophirmu@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v3 5/6] app/regex: support performance\n measurements per QP", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Up to this commit measuring the parsing elapsed time and Giga bits per\nsecond performance was done on the aggregation of all QPs (per core).\nThis commit separates the time measurements per individual QP.\n\nSigned-off-by: Ophir Munk <ophirmu@nvidia.com>\nAcked-by: Ori Kam <orika@nvidia.com>\n---\n app/test-regex/main.c | 34 +++++++++++++++++++++++-----------\n 1 file changed, 23 insertions(+), 11 deletions(-)", "diff": "diff --git a/app/test-regex/main.c b/app/test-regex/main.c\nindex 2948d3e..2fce55d 100644\n--- a/app/test-regex/main.c\n+++ b/app/test-regex/main.c\n@@ -48,6 +48,8 @@ struct qp_params {\n \tstruct rte_regex_ops **ops;\n \tstruct job_ctx *jobs_ctx;\n \tchar *buf;\n+\ttime_t start;\n+\ttime_t end;\n };\n \n struct qps_per_lcore {\n@@ -324,8 +326,6 @@ run_regex(void *args)\n \tunsigned long d_ind = 0;\n \tstruct rte_mbuf_ext_shared_info shinfo;\n \tint res = 0;\n-\ttime_t start;\n-\ttime_t end;\n \tdouble time;\n \tstruct rte_mempool *mbuf_mp;\n \tstruct qp_params *qp;\n@@ -418,9 +418,10 @@ run_regex(void *args)\n \n \t\tqp->buf = buf;\n \t\tqp->total_matches = 0;\n+\t\tqp->start = 0;\n+\t\tqp->end = 0;\n \t}\n \n-\tstart = clock();\n \tfor (i = 0; i < nb_iterations; i++) {\n \t\tfor (qp_id = 0; qp_id < nb_qps; qp_id++) {\n \t\t\tqp = &qps[qp_id];\n@@ -431,6 +432,8 @@ run_regex(void *args)\n \t\t\tupdate = false;\n \t\t\tfor (qp_id = 0; qp_id < nb_qps; qp_id++) {\n \t\t\t\tqp = &qps[qp_id];\n+\t\t\t\tif (!qp->start)\n+\t\t\t\t\tqp->start = clock();\n \t\t\t\tif (qp->total_dequeue < actual_jobs) {\n \t\t\t\t\tstruct rte_regex_ops **\n \t\t\t\t\t\tcur_ops_to_enqueue = qp->ops +\n@@ -461,22 +464,31 @@ run_regex(void *args)\n \t\t\t\t\t\t\tqp->total_enqueue -\n \t\t\t\t\t\t\tqp->total_dequeue);\n \t\t\t\t\tupdate = true;\n+\t\t\t\t} else {\n+\t\t\t\t\tif (!qp->end)\n+\t\t\t\t\t\tqp->end = clock();\n \t\t\t\t}\n+\n \t\t\t}\n \t\t} while (update);\n \t}\n-\tend = clock();\n-\ttime = ((double)end - start) / CLOCKS_PER_SEC;\n-\tprintf(\"Job len = %ld Bytes\\n\", job_len);\n-\tprintf(\"Time = %lf sec\\n\", time);\n-\tprintf(\"Perf = %lf Gbps\\n\",\n-\t (((double)actual_jobs * job_len * nb_iterations * 8) / time) /\n-\t\t1000000000.0);\n+\tfor (qp_id = 0; qp_id < nb_qps; qp_id++) {\n+\t\tqp = &qps[qp_id];\n+\t\ttime = ((double)qp->end - qp->start) / CLOCKS_PER_SEC;\n+\t\tprintf(\"Core=%u QP=%u\\n\", rte_lcore_id(), qp_id + qp_id_base);\n+\t\tprintf(\"Job len = %ld Bytes\\n\", job_len);\n+\t\tprintf(\"Time = %lf sec\\n\", time);\n+\t\tprintf(\"Perf = %lf Gbps\\n\\n\",\n+\t\t\t\t(((double)actual_jobs * job_len *\n+\t\t\t\tnb_iterations * 8) / time) /\n+\t\t\t\t1000000000.0);\n+\t}\n \n \tif (rgxc->perf_mode)\n \t\tgoto end;\n \tfor (qp_id = 0; qp_id < nb_qps; qp_id++) {\n-\t\tprintf(\"\\n############ QP id=%u ############\\n\", qp_id);\n+\t\tprintf(\"\\n############ Core=%u QP=%u ############\\n\",\n+\t\t rte_lcore_id(), qp_id + qp_id_base);\n \t\tqp = &qps[qp_id];\n \t\t/* Log results per job. */\n \t\tfor (d_ind = 0; d_ind < qp->total_dequeue; d_ind++) {\n", "prefixes": [ "v3", "5/6" ] }{ "id": 86251, "url": "