Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86176/?format=api
https://patches.dpdk.org/api/patches/86176/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210108072910.11184-1-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210108072910.11184-1-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210108072910.11184-1-alvinx.zhang@intel.com", "date": "2021-01-08T07:29:10", "name": "net/ice: fix initialization of RSS look-up table", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2024523456649af54db14edbf2183eb57f73bbbd", "submitter": { "id": 1398, "url": "https://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210108072910.11184-1-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 14596, "url": "https://patches.dpdk.org/api/series/14596/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14596", "date": "2021-01-08T07:29:10", "name": "net/ice: fix initialization of RSS look-up table", "version": 1, "mbox": "https://patches.dpdk.org/series/14596/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86176/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86176/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 17F6FA0524;\n\tFri, 8 Jan 2021 08:29:23 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 047B0140E1A;\n\tFri, 8 Jan 2021 08:29:23 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id BD736140E0F;\n Fri, 8 Jan 2021 08:29:20 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jan 2021 23:29:19 -0800", "from shwdenpg235.ccr.corp.intel.com ([10.240.182.60])\n by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jan 2021 23:29:16 -0800" ], "IronPort-SDR": [ "\n 8oe4SczVGFrkUGLfOlQPcJ2RaMjLmqeEuqWkov516v6Yj59TKyZ4vx7KZA6t9VVZ5Y+lyig3tc\n zt5Z39L5NbZA==", "\n xi1lWLzdMINzEIfywQ7LiOgFCn1fJN9ozPdyiKOnxRdC/uv/lB/rgWDIzTcbTV8xHtwsMZjGp9\n yrawrGmQqdyQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9857\"; a=\"177704923\"", "E=Sophos;i=\"5.79,330,1602572400\"; d=\"scan'208\";a=\"177704923\"", "E=Sophos;i=\"5.79,330,1602572400\"; d=\"scan'208\";a=\"398901909\"" ], "From": "\"Zhang,Alvin\" <alvinx.zhang@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tAlvin Zhang <alvinx.zhang@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 8 Jan 2021 15:29:10 +0800", "Message-Id": "<20210108072910.11184-1-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/ice: fix initialization of RSS look-up table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Alvin Zhang <alvinx.zhang@intel.com>\n\nRSS look-up table initialization is done incorrectly due to divide-by-zero\nerror.\nAdd a check to rx-queue count.\n\nFixes: 50370662b727 (\"net/ice: support device and queue ops\")\nCc: stable@dpdk.org\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 9a5d6a5..9cef73e 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -3268,10 +3268,12 @@ static int ice_init_rss(struct ice_pf *pf)\n \tif (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)\n \t\tdev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;\n \n-\tret = ice_init_rss(pf);\n-\tif (ret) {\n-\t\tPMD_DRV_LOG(ERR, \"Failed to enable rss for PF\");\n-\t\treturn ret;\n+\tif (dev->data->nb_rx_queues) {\n+\t\tret = ice_init_rss(pf);\n+\t\tif (ret) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Failed to enable rss for PF\");\n+\t\t\treturn ret;\n+\t\t}\n \t}\n \n \treturn 0;\n", "prefixes": [] }{ "id": 86176, "url": "