Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86154/?format=api
{ "id": 86154, "url": "https://patches.dpdk.org/api/patches/86154/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210108043508.301227-9-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210108043508.301227-9-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210108043508.301227-9-qi.z.zhang@intel.com", "date": "2021-01-08T04:35:07", "name": "[8/9] net/ice/base: updated the add scheduler node counter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b45bb08c7da7be86f32fd9dd8a6b53b2a5d8c3a8", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210108043508.301227-9-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 14588, "url": "https://patches.dpdk.org/api/series/14588/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14588", "date": "2021-01-08T04:34:59", "name": "ice base update batch 2", "version": 1, "mbox": "https://patches.dpdk.org/series/14588/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86154/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0C40AA0524;\n\tFri, 8 Jan 2021 05:32:32 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2783D140E2B;\n\tFri, 8 Jan 2021 05:31:35 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 4A2D4140E15;\n Fri, 8 Jan 2021 05:31:33 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jan 2021 20:31:33 -0800", "from dpdk51.sh.intel.com ([10.67.111.142])\n by fmsmga002.fm.intel.com with ESMTP; 07 Jan 2021 20:31:31 -0800" ], "IronPort-SDR": [ "\n FLlXa9uOxdWAeXLc8Z98k3UyuvJbx2Tl2hWNVOkZubpT9I6kgE+5AXC/v/BFWOK9y+XznN451U\n FMqH2MXtoCpw==", "\n VxPiAlayFQ6IQAr4MOWzX4AoNca0uqpE9MT+08Ri4Za1lBtmwuCveiCZ777vKRv0ls/x3+ZDow\n JNocTHa19RcQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9857\"; a=\"262309398\"", "E=Sophos;i=\"5.79,330,1602572400\"; d=\"scan'208\";a=\"262309398\"", "E=Sophos;i=\"5.79,330,1602572400\"; d=\"scan'208\";a=\"398858760\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "haiyue.wang@intel.com, jia.guo@intel.com, dev@dpdk.org,\n ferruh.yigit@intel.com, Qi Zhang <qi.z.zhang@intel.com>, stable@dpdk.org,\n Victor Raj <victor.raj@intel.com>", "Date": "Fri, 8 Jan 2021 12:35:07 +0800", "Message-Id": "<20210108043508.301227-9-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210108043508.301227-1-qi.z.zhang@intel.com>", "References": "<20210108043508.301227-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 8/9] net/ice/base: updated the add scheduler node\n counter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The number of nodes added counter was updated incorrectly. This issue\nwas exposed when the driver tried to add more than 128 queues per TC.\n\nFix added to update the counter correctly.\n\nFixes: 93e84b1bfc92 (\"net/ice/base: add basic Tx scheduler\")\nCc: stable@dpdk.org\n\nSigned-off-by: Victor Raj <victor.raj@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_sched.c | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_sched.c b/drivers/net/ice/base/ice_sched.c\nindex 53d76d17ee..7d4721e60c 100644\n--- a/drivers/net/ice/base/ice_sched.c\n+++ b/drivers/net/ice/base/ice_sched.c\n@@ -1040,7 +1040,15 @@ ice_sched_add_nodes_to_layer(struct ice_port_info *pi,\n \t\t\t\t\t\t\t layer,\tnew_num_nodes,\n \t\t\t\t\t\t\t first_teid_ptr,\n \t\t\t\t\t\t\t &num_added);\n-\t\t*num_nodes_added += num_added;\n+\t\tif (status == ICE_SUCCESS)\n+\t\t\t*num_nodes_added += num_added;\n+\t\t/* added more nodes than requested ? */\n+\t\tif (*num_nodes_added > num_nodes) {\n+\t\t\tice_debug(pi->hw, ICE_DBG_SCHED, \"added extra nodes %d %d\\n\", num_nodes,\n+\t\t\t\t *num_nodes_added);\n+\t\t\tstatus = ICE_ERR_CFG;\n+\t\t\tbreak;\n+\t\t}\n \t\t/* break if all the nodes are added successfully */\n \t\tif (status == ICE_SUCCESS && (*num_nodes_added == num_nodes))\n \t\t\tbreak;\n@@ -1063,7 +1071,7 @@ ice_sched_add_nodes_to_layer(struct ice_port_info *pi,\n \t\t\tif (num_added)\n \t\t\t\tfirst_teid_ptr = &temp;\n \n-\t\t\tnew_num_nodes = num_nodes - num_added;\n+\t\t\tnew_num_nodes = num_nodes - *num_nodes_added;\n \t\t}\n \t}\n \treturn status;\n", "prefixes": [ "8/9" ] }