Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86151/?format=api
{ "id": 86151, "url": "https://patches.dpdk.org/api/patches/86151/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210108043508.301227-6-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210108043508.301227-6-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210108043508.301227-6-qi.z.zhang@intel.com", "date": "2021-01-08T04:35:04", "name": "[5/9] net/ice/base: limit forced overrides based on FW version", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8a6c18ddc865df3544cfe4e7dd06273551f5062a", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210108043508.301227-6-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 14588, "url": "https://patches.dpdk.org/api/series/14588/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14588", "date": "2021-01-08T04:34:59", "name": "ice base update batch 2", "version": 1, "mbox": "https://patches.dpdk.org/series/14588/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86151/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86151/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 27054A0524;\n\tFri, 8 Jan 2021 05:32:05 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DD376140E01;\n\tFri, 8 Jan 2021 05:31:28 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 1C42F140DF8\n for <dev@dpdk.org>; Fri, 8 Jan 2021 05:31:26 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jan 2021 20:31:26 -0800", "from dpdk51.sh.intel.com ([10.67.111.142])\n by fmsmga002.fm.intel.com with ESMTP; 07 Jan 2021 20:31:25 -0800" ], "IronPort-SDR": [ "\n g15huDcSynS51SZG3r1//1RzHB4VrxOLa37jpQLC8ywjtXhyVUqzGFWWdQIUtzYH+JTwLlQc/e\n xzCkg16n05iw==", "\n tcGjHs//PUSKEi1bJQCaQMgUK+WVIYhExPEPvW9b1c/u78YlcACPzHc0qMyyOuDrypYqSwESdn\n n6e/lsyIwcvQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9857\"; a=\"262309387\"", "E=Sophos;i=\"5.79,330,1602572400\"; d=\"scan'208\";a=\"262309387\"", "E=Sophos;i=\"5.79,330,1602572400\"; d=\"scan'208\";a=\"398858728\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "haiyue.wang@intel.com, jia.guo@intel.com, dev@dpdk.org,\n ferruh.yigit@intel.com, Qi Zhang <qi.z.zhang@intel.com>,\n Jeb Cramer <jeb.j.cramer@intel.com>", "Date": "Fri, 8 Jan 2021 12:35:04 +0800", "Message-Id": "<20210108043508.301227-6-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210108043508.301227-1-qi.z.zhang@intel.com>", "References": "<20210108043508.301227-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 5/9] net/ice/base: limit forced overrides based\n on FW version", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Beyond a specific version of firmware, there is no need to provide\noverride values to the firmware when setting PHY capabilities. In this\ncase, we do not need to indicate whether we're in Strict or Lenient Link\nMode.\n\nIn the case of translating capabilities to the configuration structure,\nthe module compliance enforcement is already correctly set by firmware,\nso the extra code block is redundant.\n\nSigned-off-by: Jeb Cramer <jeb.j.cramer@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 14 ++------------\n 1 file changed, 2 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex f2fb132060..b71feb3476 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -3088,17 +3088,6 @@ ice_copy_phy_caps_to_cfg(struct ice_port_info *pi,\n \tcfg->link_fec_opt = caps->link_fec_options;\n \tcfg->module_compliance_enforcement =\n \t\tcaps->module_compliance_enforcement;\n-\n-\tif (ice_fw_supports_link_override(pi->hw)) {\n-\t\tstruct ice_link_default_override_tlv tlv;\n-\n-\t\tif (ice_get_link_default_override(&tlv, pi))\n-\t\t\treturn;\n-\n-\t\tif (tlv.options & ICE_LINK_OVERRIDE_STRICT_MODE)\n-\t\t\tcfg->module_compliance_enforcement |=\n-\t\t\t\tICE_LINK_OVERRIDE_STRICT_MODE;\n-\t}\n }\n \n /**\n@@ -3168,7 +3157,8 @@ ice_cfg_phy_fec(struct ice_port_info *pi, struct ice_aqc_set_phy_cfg_data *cfg,\n \t\tbreak;\n \t}\n \n-\tif (fec == ICE_FEC_AUTO && ice_fw_supports_link_override(pi->hw)) {\n+\tif (fec == ICE_FEC_AUTO && ice_fw_supports_link_override(pi->hw) &&\n+\t !ice_fw_supports_report_dflt_cfg(pi->hw)) {\n \t\tstruct ice_link_default_override_tlv tlv;\n \n \t\tif (ice_get_link_default_override(&tlv, pi))\n", "prefixes": [ "5/9" ] }