Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 8611,
    "url": "https://patches.dpdk.org/api/patches/8611/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1446570914-25996-2-git-send-email-adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1446570914-25996-2-git-send-email-adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1446570914-25996-2-git-send-email-adrien.mazarguil@6wind.com",
    "date": "2015-11-03T17:15:14",
    "name": "[dpdk-dev,2/2] mlx5: fix wrong hash RX queue type in RSS mode",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "9728b32640e6764765bd71217cc278ca9d4ee0d0",
    "submitter": {
        "id": 165,
        "url": "https://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1446570914-25996-2-git-send-email-adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/8611/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/8611/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5FAFF8F9D;\n\tTue,  3 Nov 2015 18:15:45 +0100 (CET)",
            "from mail-wi0-f171.google.com (mail-wi0-f171.google.com\n\t[209.85.212.171]) by dpdk.org (Postfix) with ESMTP id A51CF8F9B\n\tfor <dev@dpdk.org>; Tue,  3 Nov 2015 18:15:43 +0100 (CET)",
            "by wicfv8 with SMTP id fv8so16236606wic.0\n\tfor <dev@dpdk.org>; Tue, 03 Nov 2015 09:15:43 -0800 (PST)",
            "from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tu126sm24366417wmd.3.2015.11.03.09.15.42\n\t(version=TLSv1.2 cipher=RC4-SHA bits=128/128);\n\tTue, 03 Nov 2015 09:15:43 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind_com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=lyb8DwX7UeBMNRuwb/U9hDx3CCMkX1B1jV8R854QcU8=;\n\tb=a5XJGaE+aURdLGLkqSY/cwj0g7loGjL2Sf+J9hIvDumeWgIi77TC8+gnNP/LI6OP40\n\tIbL2Gy30AKLFrowBWSKlczecIJX1Afxg+GUQFZyCpb6w/912q+0Y5S3cM0P6IpFNvCPL\n\tNXYo8YQ3icZOxMmg9AIRSK2UGK/COE2+ILx6VoPSbfEov2Jxf6WzCt8gL9b1Wb6J5qrx\n\tLtyLVzEexae5zXd100yKzxnWHS2vKdAIi8LGqH+TIH24KggTDotPWhdqnwvnciFMaP9z\n\t8ZtO6PIFKBjWwyu4OWCZBX9Ly2NIFY1d0kq4Df7SDncbJUD7e3iXXstZWRH4mHPbtlsO\n\tcZjA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=lyb8DwX7UeBMNRuwb/U9hDx3CCMkX1B1jV8R854QcU8=;\n\tb=WCxV3vgiGlzHHM65coGiL/06WrYVeRgZpVIn+jbh4YPJwDuCuPSwJ1A5IdNxg2eg+8\n\t62DLz33OYmfQJUEDaSJ61hC2Qoyh7LCPVlVN29+yRKTzBz1Kgy/JfeUeNH57f3BozKsa\n\tkF7+j3Bfc19ZooX1qUJmdvle1P3aiIkkKfYr91v2PDxz3v+3f26FNednTmXOa6o7fYkg\n\tsN1OAQyTLyZReu8GjiGnRnmBJ9B+3gxpxX9bkukIAa0Z7SNr6CPWP+c/qZQAjfMrGfRc\n\tWwb8RMbyBqUV6wvhmlhDYRM9Ct3kureVQs/dEi0yTMLx/1KMSXCuyavEoM24FyrM9bzv\n\taE4A==",
        "X-Gm-Message-State": "ALoCoQnFkPXdMo8gMYu9jqw2JuMbk83DB47o7yQ3bC31zt2Lw0lQtmZPrr0MHw4LPTj1gv/a/n+8",
        "X-Received": "by 10.194.142.166 with SMTP id rx6mr30854356wjb.54.1446570943508;\n\tTue, 03 Nov 2015 09:15:43 -0800 (PST)",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue,  3 Nov 2015 18:15:14 +0100",
        "Message-Id": "<1446570914-25996-2-git-send-email-adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.1.0",
        "In-Reply-To": "<1446570914-25996-1-git-send-email-adrien.mazarguil@6wind.com>",
        "References": "<1446570914-25996-1-git-send-email-adrien.mazarguil@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 2/2] mlx5: fix wrong hash RX queue type in RSS\n\tmode",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Only seen since IPv6 RSS support was added, confusion about the purpose of\nthe hash_rxq_type_from_n() function has caused it to return invalid hash RX\nqueue types.\n\nRefactor function for its intended purpose, rename it\nhash_rxq_type_from_pos() and update comment with a better description.\n\nFixes: a76133214d88 (\"mlx5: use separate indirection table for default hash Rx queue\")\n\nReported-by: Olga Shern <olgas@mellanox.com>\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_rxq.c | 32 +++++++++++++++++++-------------\n 1 file changed, 19 insertions(+), 13 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 3d7ae7e..37b4efd 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -259,23 +259,29 @@ hash_rxq_flow_attr(const struct hash_rxq *hash_rxq,\n }\n \n /**\n- * Return the type corresponding to the n'th bit set.\n+ * Convert hash type position in indirection table initializer to\n+ * hash RX queue type.\n  *\n  * @param table\n- *   The indirection table.\n- * @param n\n- *   The n'th bit set.\n+ *   Indirection table initializer.\n+ * @param pos\n+ *   Hash type position.\n  *\n  * @return\n- *   The corresponding hash_rxq_type.\n+ *   Hash RX queue type.\n  */\n static enum hash_rxq_type\n-hash_rxq_type_from_n(const struct ind_table_init *table, unsigned int n)\n+hash_rxq_type_from_pos(const struct ind_table_init *table, unsigned int pos)\n {\n-\tassert(n < table->hash_types_n);\n-\twhile (((table->hash_types >> n) & 0x1) == 0)\n-\t\t++n;\n-\treturn n;\n+\tenum hash_rxq_type type = 0;\n+\n+\tassert(pos < table->hash_types_n);\n+\tdo {\n+\t\tif ((table->hash_types & (1 << type)) && (pos-- == 0))\n+\t\t\tbreak;\n+\t\t++type;\n+\t} while (1);\n+\treturn type;\n }\n \n /**\n@@ -429,7 +435,7 @@ priv_create_hash_rxqs(struct priv *priv)\n \t     ++i) {\n \t\tstruct hash_rxq *hash_rxq = &(*hash_rxqs)[i];\n \t\tenum hash_rxq_type type =\n-\t\t\thash_rxq_type_from_n(&ind_table_init[j], k);\n+\t\t\thash_rxq_type_from_pos(&ind_table_init[j], k);\n \t\tstruct rte_eth_rss_conf *priv_rss_conf =\n \t\t\t(*priv->rss_conf)[type];\n \t\tstruct ibv_exp_rx_hash_conf hash_conf = {\n@@ -453,8 +459,8 @@ priv_create_hash_rxqs(struct priv *priv)\n \t\t\t.port_num = priv->port,\n \t\t};\n \n-\t\tDEBUG(\"using indirection table %u for hash RX queue %u\",\n-\t\t      j, i);\n+\t\tDEBUG(\"using indirection table %u for hash RX queue %u type %d\",\n+\t\t      j, i, type);\n \t\t*hash_rxq = (struct hash_rxq){\n \t\t\t.priv = priv,\n \t\t\t.qp = ibv_exp_create_qp(priv->ctx, &qp_init_attr),\n",
    "prefixes": [
        "dpdk-dev",
        "2/2"
    ]
}