Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 8610,
    "url": "https://patches.dpdk.org/api/patches/8610/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1446570914-25996-1-git-send-email-adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1446570914-25996-1-git-send-email-adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1446570914-25996-1-git-send-email-adrien.mazarguil@6wind.com",
    "date": "2015-11-03T17:15:13",
    "name": "[dpdk-dev,1/2] mlx5: fix compilation error with debugging enabled",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f10d8b0ea4be8af6d73eb167be4ab603592f971a",
    "submitter": {
        "id": 165,
        "url": "https://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1446570914-25996-1-git-send-email-adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/8610/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/8610/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 69A6C5A6B;\n\tTue,  3 Nov 2015 18:15:40 +0100 (CET)",
            "from mail-wm0-f46.google.com (mail-wm0-f46.google.com\n\t[74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 1FCAD5682\n\tfor <dev@dpdk.org>; Tue,  3 Nov 2015 18:15:39 +0100 (CET)",
            "by wmff134 with SMTP id f134so89993740wmf.1\n\tfor <dev@dpdk.org>; Tue, 03 Nov 2015 09:15:39 -0800 (PST)",
            "from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tr9sm28538203wjz.35.2015.11.03.09.15.36\n\tfor <dev@dpdk.org> (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\n\tTue, 03 Nov 2015 09:15:38 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind_com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id;\n\tbh=hszWGlLF3URsQI67tgRGOE7hmZhhiufqsl6UteTfj1s=;\n\tb=fZ0H9wRXAOd30gYBDYDh7RubiJfHQ0rPJcMm/AM36kb110zha7jzlktEWStCkqTNt0\n\tmi8+MtcbEZb4mTu4mzSDmhtsGVjcBczyCskVJDp02MsuJJ5EkyVxqKFUsW10H700bD7E\n\tOD46Gj4Ge6egRxlPkO6Wpu3A788X0zVO+LcIt9Z4XhFCUM5uNPXPVUH9vaRfBqNEEbfl\n\tVtO04M2DoefnG7aJHOCGMLiPBuC+PCPLBTc/IHUGP16fbohYCmCZDydL0FTwkLumUBRq\n\tPruke5BxWqaDwhsmYV2vafffMaGPKj0HQEjnma5sG2w6KM9xZqJxo28UgZSXpQ2JJT8S\n\tNSdQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=hszWGlLF3URsQI67tgRGOE7hmZhhiufqsl6UteTfj1s=;\n\tb=kKkrbb5DqBV8F4Jf01EyiLltuJJnNVSyPbV2oJ2dQNqP/ydRX468Jz1ZfrqLcXUzpe\n\to+BX8yN35iSTf04F0ftOId4YBdOSbn070QStHbnlLhMQCI+8c2xhsfwSWNdAUogKNp2D\n\t9eaXdYgHvBPbUOOwqzEmo/D/y1iGLsIf5WY6ANDcUTdgaqN2LZzrUtx1BIhWeSAMFpJr\n\t2xGetkyjre3SdKlNBYxJHEVPNJCX5GGQYpSyT0joY+JDfsOCkltHqGRsPY6wCapatWdW\n\tR9O3g/6Rb4QXQHVMpX16YnIedOKpMwfaDWSlXPpkE2ctmS4CgvWTyc6idmX5lkNGK+pf\n\tBOCQ==",
        "X-Gm-Message-State": "ALoCoQmK8zM2ZLIoqfSTFwll4AFsnoVCiRUalmA02/gyptuVlwuKPH3YKIul2JJknw5kYX9hF2cp",
        "X-Received": "by 10.28.143.21 with SMTP id r21mr19833484wmd.39.1446570939009; \n\tTue, 03 Nov 2015 09:15:39 -0800 (PST)",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue,  3 Nov 2015 18:15:13 +0100",
        "Message-Id": "<1446570914-25996-1-git-send-email-adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.1.0",
        "Subject": "[dpdk-dev] [PATCH 1/2] mlx5: fix compilation error with debugging\n\tenabled",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The following error occurs when CONFIG_RTE_LIBRTE_MLX5_DEBUG=y:\n\n drivers/net/mlx5/mlx5.c:381:4: error: ISO C forbids braced-groups within expressions\n\nRTE_MIN() uses the non-standard ({ ... }) syntax to declare variables within\nparentheses, which is rejected by -pedantic.\n\nSince the RSS_INDIRECTION_TABLE_SIZE check is meant to go away as soon as\nDPDK supports larger/variable indirection tables, put it in a separate\ncondition.\n\nFixes: 634efbc2c8c0 (\"mlx5: support RETA query and update\")\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx5/mlx5.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 5a95260..0cd7208 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -65,6 +65,7 @@\n #include \"mlx5_utils.h\"\n #include \"mlx5_rxtx.h\"\n #include \"mlx5_autoconf.h\"\n+#include \"mlx5_defs.h\"\n \n /**\n  * DPDK callback to close the device.\n@@ -377,9 +378,11 @@ mlx5_pci_devinit(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\tDEBUG(\"L2 tunnel checksum offloads are %ssupported\",\n \t\t      (priv->hw_csum_l2tun ? \"\" : \"not \"));\n \n-\t\tpriv->ind_table_max_size =\n-\t\t\tRTE_MIN((unsigned int)RSS_INDIRECTION_TABLE_SIZE,\n-\t\t\t\texp_device_attr.rx_hash_caps.max_rwq_indirection_table_size);\n+\t\tpriv->ind_table_max_size = exp_device_attr.rx_hash_caps.max_rwq_indirection_table_size;\n+\t\t/* Remove this check once DPDK supports larger/variable\n+\t\t * indirection tables. */\n+\t\tif (priv->ind_table_max_size > (unsigned int)RSS_INDIRECTION_TABLE_SIZE)\n+\t\t\tpriv->ind_table_max_size = RSS_INDIRECTION_TABLE_SIZE;\n \t\tDEBUG(\"maximum RX indirection table size is %u\",\n \t\t      priv->ind_table_max_size);\n \n",
    "prefixes": [
        "dpdk-dev",
        "1/2"
    ]
}