Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86097/?format=api
{ "id": 86097, "url": "https://patches.dpdk.org/api/patches/86097/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210107080230.7836-2-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210107080230.7836-2-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210107080230.7836-2-alvinx.zhang@intel.com", "date": "2021-01-07T08:02:28", "name": "[v3,2/3] net/i40e: fix return value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "73e0b8301326e9797464d149344715ed76296908", "submitter": { "id": 1398, "url": "https://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210107080230.7836-2-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 14572, "url": "https://patches.dpdk.org/api/series/14572/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14572", "date": "2021-01-07T08:02:27", "name": "[v3,1/3] doc: fix testpmd command for i40e RSS flow", "version": 3, "mbox": "https://patches.dpdk.org/series/14572/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86097/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86097/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3FBDEA09FF;\n\tThu, 7 Jan 2021 09:02:48 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 110D4140EEE;\n\tThu, 7 Jan 2021 09:02:43 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 6D851140EC0;\n Thu, 7 Jan 2021 09:02:41 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jan 2021 00:02:40 -0800", "from shwdenpg235.ccr.corp.intel.com ([10.240.182.60])\n by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Jan 2021 00:02:38 -0800" ], "IronPort-SDR": [ "\n jQ34KJ3raGRU9nc+oaTpwBCyHya2Oul2TzqEzi3gjAK9eMV927u2ZCuF7WlI3FqtdTW2TRU7ND\n 0t2qJeiSKvhw==", "\n dYRb0fj1Wyaj187+5uMioZj//g4QK292vjSxoHVKtOtVrdrVE4YA3hmy1eIxAfYxGbbYyPt3Qh\n zGSCcsZPDEUw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9856\"; a=\"177491570\"", "E=Sophos;i=\"5.79,329,1602572400\"; d=\"scan'208\";a=\"177491570\"", "E=Sophos;i=\"5.79,329,1602572400\"; d=\"scan'208\";a=\"398533068\"" ], "From": "\"Zhang,Alvin\" <alvinx.zhang@intel.com>", "To": "jia.guo@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com,\n Simei.Su@intel.com, qiming.yang@intel.com", "Cc": "dev@dpdk.org,\n\tAlvin Zhang <alvinx.zhang@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 7 Jan 2021 16:02:28 +0800", "Message-Id": "<20210107080230.7836-2-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20210107080230.7836-1-alvinx.zhang@intel.com>", "References": "<20201228071210.19596-1-alvinx.zhang@intel.com>\n <20210107080230.7836-1-alvinx.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/3] net/i40e: fix return value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Alvin Zhang <alvinx.zhang@intel.com>\n\nThe api should return the system error status, but it returned the\nhardware error status, this is confused for the caller.\nThis patch adds check on hardware execution status and returns -EIO\nin case of hardware execution failure.\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n\nFixes: 1d4b2b4966bb (\"net/i40e: fix VF overwrite PF RSS LUT for X722\")\nFixes: d0a349409bd7 (\"i40e: support AQ based RSS config\")\nCc: stable@dpdk.org\n---\n drivers/net/i40e/i40e_ethdev.c | 33 ++++++++++++++++++++-------------\n 1 file changed, 20 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex f54769c..2034008 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -4426,7 +4426,6 @@ static int i40e_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n {\n \tstruct i40e_pf *pf;\n \tstruct i40e_hw *hw;\n-\tint ret;\n \n \tif (!vsi || !lut)\n \t\treturn -EINVAL;\n@@ -4435,12 +4434,16 @@ static int i40e_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,\n \thw = I40E_VSI_TO_HW(vsi);\n \n \tif (pf->flags & I40E_FLAG_RSS_AQ_CAPABLE) {\n-\t\tret = i40e_aq_set_rss_lut(hw, vsi->vsi_id,\n-\t\t\t\t\t vsi->type != I40E_VSI_SRIOV,\n-\t\t\t\t\t lut, lut_size);\n-\t\tif (ret) {\n-\t\t\tPMD_DRV_LOG(ERR, \"Failed to set RSS lookup table\");\n-\t\t\treturn ret;\n+\t\tenum i40e_status_code status;\n+\n+\t\tstatus = i40e_aq_set_rss_lut(hw, vsi->vsi_id,\n+\t\t\t\t\t vsi->type != I40E_VSI_SRIOV,\n+\t\t\t\t\t lut, lut_size);\n+\t\tif (status) {\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t \"Failed to update RSS lookup table, error status: %d\",\n+\t\t\t\t status);\n+\t\t\treturn -EIO;\n \t\t}\n \t} else {\n \t\tuint32_t *lut_dw = (uint32_t *)lut;\n@@ -7591,7 +7594,6 @@ struct i40e_vsi *\n \tuint16_t key_idx = (vsi->type == I40E_VSI_SRIOV) ?\n \t\t\t I40E_VFQF_HKEY_MAX_INDEX :\n \t\t\t I40E_PFQF_HKEY_MAX_INDEX;\n-\tint ret = 0;\n \n \tif (!key || key_len == 0) {\n \t\tPMD_DRV_LOG(DEBUG, \"No key to be configured\");\n@@ -7604,11 +7606,16 @@ struct i40e_vsi *\n \n \tif (pf->flags & I40E_FLAG_RSS_AQ_CAPABLE) {\n \t\tstruct i40e_aqc_get_set_rss_key_data *key_dw =\n-\t\t\t(struct i40e_aqc_get_set_rss_key_data *)key;\n+\t\t\t\t(struct i40e_aqc_get_set_rss_key_data *)key;\n+\t\tenum i40e_status_code status =\n+\t\t\t\ti40e_aq_set_rss_key(hw, vsi->vsi_id, key_dw);\n \n-\t\tret = i40e_aq_set_rss_key(hw, vsi->vsi_id, key_dw);\n-\t\tif (ret)\n-\t\t\tPMD_INIT_LOG(ERR, \"Failed to configure RSS key via AQ\");\n+\t\tif (status) {\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t \"Failed to configure RSS key via AQ, error status: %d\",\n+\t\t\t\t status);\n+\t\t\treturn -EIO;\n+\t\t}\n \t} else {\n \t\tuint32_t *hash_key = (uint32_t *)key;\n \t\tuint16_t i;\n@@ -7628,7 +7635,7 @@ struct i40e_vsi *\n \t\tI40E_WRITE_FLUSH(hw);\n \t}\n \n-\treturn ret;\n+\treturn 0;\n }\n \n static int\n", "prefixes": [ "v3", "2/3" ] }