Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85937/?format=api
{ "id": 85937, "url": "https://patches.dpdk.org/api/patches/85937/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210103034627.80169-6-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210103034627.80169-6-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210103034627.80169-6-ajit.khaparde@broadcom.com", "date": "2021-01-03T03:46:26", "name": "[v2,5/6] net/bnxt: modify context memory allocation code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "45c1719832b45415e71aebebed445ca3e26c69e3", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210103034627.80169-6-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 14511, "url": "https://patches.dpdk.org/api/series/14511/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14511", "date": "2021-01-03T03:46:21", "name": "net/bnxt: add support for Stingray2", "version": 2, "mbox": "https://patches.dpdk.org/series/14511/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85937/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85937/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9031BA09E4;\n\tSun, 3 Jan 2021 04:47:20 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1FD2C1606AB;\n\tSun, 3 Jan 2021 04:46:52 +0100 (CET)", "from mail-pg1-f181.google.com (mail-pg1-f181.google.com\n [209.85.215.181])\n by mails.dpdk.org (Postfix) with ESMTP id 51DFE1606AB\n for <dev@dpdk.org>; Sun, 3 Jan 2021 04:46:50 +0100 (CET)", "by mail-pg1-f181.google.com with SMTP id 30so11883784pgr.6\n for <dev@dpdk.org>; Sat, 02 Jan 2021 19:46:50 -0800 (PST)", "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id k7sm51391194pfh.201.2021.01.02.19.46.47\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Sat, 02 Jan 2021 19:46:48 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version; bh=pNHOuWHuio7HV11UTa75n4IwDvFhMjEnc5dVWT48iec=;\n b=aTisKdeQW8/GpUSO5TQLR/nfYCo8QFZu4pFPZ50tFlslXLut+3LlnsN3iT1CxwqI4/\n ybTm7rbkPaQ53VwKDsywkyNvnP49OyKkgJzDF4Rs4gU6GXd66Wqn3nCmmw12Lwz/Yt6D\n J6DBhxwv8Rcu9opQ9cNATY3hM86b2KrV8Bfvs=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=pNHOuWHuio7HV11UTa75n4IwDvFhMjEnc5dVWT48iec=;\n b=YwZU39v6ME4R6mKOzIboFNvwFdty+Z2xhPKkvq0XN7g2Cq/XInWjAOBbBk7ELPQgIP\n QG3O+HYBKfZDtjLVrH0+Zg21nQMPBg/wLg2Vo+JKn2VIV6+VuD3VjyOV2f2n8EyOVjC7\n 5ebMcyD10yPk5+fm8lU4ptLNE+KkeLaIXhBa4RV50sNEUItqKUTuAMRcGd0o3eBtXglC\n OaswghvHaj3sTxkTsrtjvgh527TSE/vk3cF8Dz5L1MdBfqnkN8y6Bfn+4nSm8CzQruIy\n /a/bqHuyb0+/w1x6NNK38VxV2yRbgvUdvvwJZSHgXnTgojhKETqNKtXgYhwcxs86TbuK\n NVMA==", "X-Gm-Message-State": "AOAM532yYhsCCKbeGmffS4Qv78+JrB8kTI/05ktVuB3ab5bFNFfkmTaA\n ZVWTtQDoGUmbApqOJYIKemB5Wgr1eNQDsVlZaJBeC+I/56vSg/FPF67jChBcnwyLBdpeTSeb0VS\n geIvueSnThJRtozKIERkhP6svs4HlBNXgyqTjFLnxnmsyHiec4jiNeu72rHNSLC97YQ==", "X-Google-Smtp-Source": "\n ABdhPJzCRJMgDN/DMDx2xzKgBRyZhMnKFEXrIXEdEjdDmee8TL5WMFcFqSN8GFILr1EaVUXPvMESqw==", "X-Received": "by 2002:a65:55ca:: with SMTP id\n k10mr65757896pgs.431.1609645609149;\n Sat, 02 Jan 2021 19:46:49 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Kalesh AP <kalesh-anakkur.purayil@broadcom.com>", "Date": "Sat, 2 Jan 2021 19:46:26 -0800", "Message-Id": "<20210103034627.80169-6-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20210103034627.80169-1-ajit.khaparde@broadcom.com>", "References": "<20201220052430.99990-1-ajit.khaparde@broadcom.com>\n <20210103034627.80169-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"000000000000c523f005b7f6d246\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.29", "Subject": "[dpdk-dev] [PATCH v2 5/6] net/bnxt: modify context memory\n allocation code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nNewer devices like SR2 may have chip backing store and do not require\nhost backed memory allocation.\n\nIn these cases, HWRM_FUNC_BACKING_STORE_QCAPS will return a zero entry\nsize to indicate contexts for which the host should not allocate backing\nstore.\n\nSelectively allocate context memory based on device capabilities and\nonly enable backing store for the appropriate contexts.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 60 ++++++++++++++++++++--------------\n drivers/net/bnxt/bnxt_hwrm.c | 3 ++\n 2 files changed, 39 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 8ca4fb151..e11751cc1 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -4212,39 +4212,49 @@ int bnxt_alloc_ctx_mem(struct bnxt *bp)\n \n \tctx_pg = &ctx->qp_mem;\n \tctx_pg->entries = ctx->qp_min_qp1_entries + ctx->qp_max_l2_entries;\n-\tmem_size = ctx->qp_entry_size * ctx_pg->entries;\n-\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"qp_mem\", 0);\n-\tif (rc)\n-\t\treturn rc;\n+\tif (ctx->qp_entry_size) {\n+\t\tmem_size = ctx->qp_entry_size * ctx_pg->entries;\n+\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"qp_mem\", 0);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t}\n \n \tctx_pg = &ctx->srq_mem;\n \tctx_pg->entries = ctx->srq_max_l2_entries;\n-\tmem_size = ctx->srq_entry_size * ctx_pg->entries;\n-\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"srq_mem\", 0);\n-\tif (rc)\n-\t\treturn rc;\n+\tif (ctx->srq_entry_size) {\n+\t\tmem_size = ctx->srq_entry_size * ctx_pg->entries;\n+\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"srq_mem\", 0);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t}\n \n \tctx_pg = &ctx->cq_mem;\n \tctx_pg->entries = ctx->cq_max_l2_entries;\n-\tmem_size = ctx->cq_entry_size * ctx_pg->entries;\n-\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"cq_mem\", 0);\n-\tif (rc)\n-\t\treturn rc;\n+\tif (ctx->cq_entry_size) {\n+\t\tmem_size = ctx->cq_entry_size * ctx_pg->entries;\n+\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"cq_mem\", 0);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t}\n \n \tctx_pg = &ctx->vnic_mem;\n \tctx_pg->entries = ctx->vnic_max_vnic_entries +\n \t\tctx->vnic_max_ring_table_entries;\n-\tmem_size = ctx->vnic_entry_size * ctx_pg->entries;\n-\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"vnic_mem\", 0);\n-\tif (rc)\n-\t\treturn rc;\n+\tif (ctx->vnic_entry_size) {\n+\t\tmem_size = ctx->vnic_entry_size * ctx_pg->entries;\n+\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"vnic_mem\", 0);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t}\n \n \tctx_pg = &ctx->stat_mem;\n \tctx_pg->entries = ctx->stat_max_entries;\n-\tmem_size = ctx->stat_entry_size * ctx_pg->entries;\n-\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"stat_mem\", 0);\n-\tif (rc)\n-\t\treturn rc;\n+\tif (ctx->stat_entry_size) {\n+\t\tmem_size = ctx->stat_entry_size * ctx_pg->entries;\n+\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"stat_mem\", 0);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t}\n \n \tmin = ctx->tqm_min_entries_per_ring;\n \n@@ -4260,10 +4270,12 @@ int bnxt_alloc_ctx_mem(struct bnxt *bp)\n \tfor (i = 0, ena = 0; i < ctx->tqm_fp_rings_count + 1; i++) {\n \t\tctx_pg = ctx->tqm_mem[i];\n \t\tctx_pg->entries = i ? entries : entries_sp;\n-\t\tmem_size = ctx->tqm_entry_size * ctx_pg->entries;\n-\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"tqm_mem\", i);\n-\t\tif (rc)\n-\t\t\treturn rc;\n+\t\tif (ctx->tqm_entry_size) {\n+\t\t\tmem_size = ctx->tqm_entry_size * ctx_pg->entries;\n+\t\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"tqm_mem\", i);\n+\t\t\tif (rc)\n+\t\t\t\treturn rc;\n+\t\t}\n \t\tena |= HWRM_FUNC_BACKING_STORE_CFG_INPUT_ENABLES_TQM_SP << i;\n \t}\n \ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 56e2e33a9..6d54b1656 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -64,6 +64,9 @@ static void bnxt_hwrm_set_pg_attr(struct bnxt_ring_mem_info *rmem,\n \t\t\t\t uint8_t *pg_attr,\n \t\t\t\t uint64_t *pg_dir)\n {\n+\tif (rmem->nr_pages == 0)\n+\t\treturn;\n+\n \tif (rmem->nr_pages > 1) {\n \t\t*pg_attr = 1;\n \t\t*pg_dir = rte_cpu_to_le_64(rmem->pg_tbl_map);\n", "prefixes": [ "v2", "5/6" ] }