Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85844/?format=api
https://patches.dpdk.org/api/patches/85844/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201228123302.3608-36-talshn@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201228123302.3608-36-talshn@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201228123302.3608-36-talshn@nvidia.com", "date": "2020-12-28T12:33:02", "name": "[v2,35/35] net/mlx5: fix warnings on comparison sign mismatch", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "352935d535a88f38eae4ba4b366f4fc1659cd5d0", "submitter": { "id": 1893, "url": "https://patches.dpdk.org/api/people/1893/?format=api", "name": "Tal Shnaiderman", "email": "talshn@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201228123302.3608-36-talshn@nvidia.com/mbox/", "series": [ { "id": 14482, "url": "https://patches.dpdk.org/api/series/14482/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14482", "date": "2020-12-28T12:32:28", "name": "mlx5 Windows support - part #6", "version": 2, "mbox": "https://patches.dpdk.org/series/14482/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85844/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/85844/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CD0ECA09FF;\n\tMon, 28 Dec 2020 13:46:06 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 27B78CD61;\n\tMon, 28 Dec 2020 13:34:34 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id BC078C9F2\n for <dev@dpdk.org>; Mon, 28 Dec 2020 13:33:41 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n talshn@nvidia.com) with SMTP; 28 Dec 2020 14:33:36 +0200", "from nvidia.com (l-wincomp04-vm.mtl.labs.mlnx [10.237.1.5])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0BSCXWno001295;\n Mon, 28 Dec 2020 14:33:35 +0200" ], "From": "Tal Shnaiderman <talshn@nvidia.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, matan@nvidia.com, rasland@nvidia.com,\n ophirmu@nvidia.com, stable@dpdk.org", "Date": "Mon, 28 Dec 2020 14:33:02 +0200", "Message-Id": "<20201228123302.3608-36-talshn@nvidia.com>", "X-Mailer": "git-send-email 2.16.1.windows.4", "In-Reply-To": "<20201228123302.3608-1-talshn@nvidia.com>", "References": "<20201217173037.11396-2-talshn@nvidia.com>\n <20201228123302.3608-1-talshn@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v2 35/35] net/mlx5: fix warnings on comparison\n\tsign mismatch", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The clang compiler warns on size mismatches of several\ncomparisons.\n\nwarning: comparison of integers of different signs\n\nTo resolve those the right types is used/cast to.\n\nCc: stable@dpdk.org\nSigned-off-by: Tal Shnaiderman <talshn@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 4 ++--\n drivers/net/mlx5/mlx5_flow_dv.c | 2 +-\n drivers/net/mlx5/windows/mlx5_flow_os.c | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex b1c061a3f0..f110c6b714 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -798,7 +798,7 @@ mlx5_flow_get_reg_id(struct rte_eth_dev *dev,\n \t\tstart_reg = priv->mtr_color_reg != REG_C_2 ? REG_C_2 :\n \t\t\t (priv->mtr_reg_share ? REG_C_3 : REG_C_4);\n \t\tskip_mtr_reg = !!(priv->mtr_en && start_reg == REG_C_2);\n-\t\tif (id > (REG_C_7 - start_reg))\n+\t\tif (id > (uint32_t)(REG_C_7 - start_reg))\n \t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n \t\t\t\t\t\t NULL, \"invalid tag id\");\n@@ -814,7 +814,7 @@ mlx5_flow_get_reg_id(struct rte_eth_dev *dev,\n \t\t */\n \t\tif (skip_mtr_reg && config->flow_mreg_c\n \t\t [id + start_reg - REG_C_0] >= priv->mtr_color_reg) {\n-\t\t\tif (id >= (REG_C_7 - start_reg))\n+\t\t\tif (id >= (uint32_t)(REG_C_7 - start_reg))\n \t\t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n \t\t\t\t\t\t\tNULL, \"invalid tag id\");\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 51b5e5a2e3..ab5f0ed9e2 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -955,7 +955,7 @@ flow_dv_convert_action_set_reg\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n \t\t\t\t\t \"too many items to modify\");\n \tMLX5_ASSERT(conf->id != REG_NON);\n-\tMLX5_ASSERT(conf->id < RTE_DIM(reg_to_field));\n+\tMLX5_ASSERT(conf->id < (enum modify_reg)RTE_DIM(reg_to_field));\n \tactions[i] = (struct mlx5_modification_cmd) {\n \t\t.action_type = MLX5_MODIFICATION_TYPE_SET,\n \t\t.field = reg_to_field[conf->id],\ndiff --git a/drivers/net/mlx5/windows/mlx5_flow_os.c b/drivers/net/mlx5/windows/mlx5_flow_os.c\nindex daf4e15ddb..acd7de61e0 100644\n--- a/drivers/net/mlx5/windows/mlx5_flow_os.c\n+++ b/drivers/net/mlx5/windows/mlx5_flow_os.c\n@@ -188,7 +188,7 @@ mlx5_flow_os_create_flow(void *matcher, void *match_value,\n \t\t\t void *actions[], void **flow)\n {\n \tstruct mlx5_action *action;\n-\tint i;\n+\tsize_t i;\n \tstruct mlx5_matcher *mlx5_matcher = matcher;\n \tstruct mlx5_flow_dv_match_params *mlx5_match_value = match_value;\n \tuint32_t in[MLX5_ST_SZ_DW(devx_fs_rule_add_in)] = {0};\n", "prefixes": [ "v2", "35/35" ] }{ "id": 85844, "url": "