Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8577/?format=api
{ "id": 8577, "url": "https://patches.dpdk.org/api/patches/8577/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1446555725-19540-6-git-send-email-bernard.iremonger@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1446555725-19540-6-git-send-email-bernard.iremonger@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1446555725-19540-6-git-send-email-bernard.iremonger@intel.com", "date": "2015-11-03T13:01:59", "name": "[dpdk-dev,v8,05/11] null: remove pci device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "68ef8dbff2375c0975c31a96b1616add216418be", "submitter": { "id": 91, "url": "https://patches.dpdk.org/api/people/91/?format=api", "name": "Iremonger, Bernard", "email": "bernard.iremonger@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1446555725-19540-6-git-send-email-bernard.iremonger@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/8577/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/8577/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 17C17919B;\n\tTue, 3 Nov 2015 14:02:29 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 7ABD28F9C\n\tfor <dev@dpdk.org>; Tue, 3 Nov 2015 14:02:27 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 03 Nov 2015 05:02:15 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga001.jf.intel.com with ESMTP; 03 Nov 2015 05:02:15 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ttA3D2D6F011927; Tue, 3 Nov 2015 13:02:13 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id tA3D2D6B019633;\n\tTue, 3 Nov 2015 13:02:13 GMT", "(from bairemon@localhost)\n\tby sivswdev01.ir.intel.com with id tA3D2DER019629;\n\tTue, 3 Nov 2015 13:02:13 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,238,1444719600\"; d=\"scan'208\";a=\"810610915\"", "From": "Bernard Iremonger <bernard.iremonger@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 3 Nov 2015 13:01:59 +0000", "Message-Id": "<1446555725-19540-6-git-send-email-bernard.iremonger@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1446555725-19540-1-git-send-email-bernard.iremonger@intel.com>", "References": "<PATCH v8>\n\t<1446555725-19540-1-git-send-email-bernard.iremonger@intel.com>", "Subject": "[dpdk-dev] [PATCH v8 05/11] null: remove pci device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "remove rte_null_pmd and pci_dev.\n\nSigned-off-by: Bernard Iremonger <bernard.iremonger@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/null/rte_eth_null.c | 19 +------------------\n 1 file changed, 1 insertion(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 11d6037..77fc988 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -366,13 +366,6 @@ eth_stats_reset(struct rte_eth_dev *dev)\n \t}\n }\n \n-static struct eth_driver rte_null_pmd = {\n-\t.pci_drv = {\n-\t\t.name = \"rte_null_pmd\",\n-\t\t.drv_flags = RTE_PCI_DRV_DETACHABLE,\n-\t},\n-};\n-\n static void\n eth_queue_release(void *q)\n {\n@@ -501,7 +494,6 @@ eth_dev_null_create(const char *name,\n \tconst unsigned nb_rx_queues = 1;\n \tconst unsigned nb_tx_queues = 1;\n \tstruct rte_eth_dev_data *data = NULL;\n-\tstruct rte_pci_device *pci_dev = NULL;\n \tstruct pmd_internals *internals = NULL;\n \tstruct rte_eth_dev *eth_dev = NULL;\n \n@@ -525,10 +517,6 @@ eth_dev_null_create(const char *name,\n \tif (data == NULL)\n \t\tgoto error;\n \n-\tpci_dev = rte_zmalloc_socket(name, sizeof(*pci_dev), 0, numa_node);\n-\tif (pci_dev == NULL)\n-\t\tgoto error;\n-\n \tinternals = rte_zmalloc_socket(name, sizeof(*internals), 0, numa_node);\n \tif (internals == NULL)\n \t\tgoto error;\n@@ -558,9 +546,6 @@ eth_dev_null_create(const char *name,\n \n \trte_memcpy(internals->rss_key, default_rss_key, 40);\n \n-\tpci_dev->numa_node = numa_node;\n-\tpci_dev->driver = &rte_null_pmd.pci_drv;\n-\n \tdata->dev_private = internals;\n \tdata->port_id = eth_dev->data->port_id;\n \tdata->nb_rx_queues = (uint16_t)nb_rx_queues;\n@@ -593,7 +578,6 @@ eth_dev_null_create(const char *name,\n \n error:\n \trte_free(data);\n-\trte_free(pci_dev);\n \trte_free(internals);\n \n \treturn -1;\n@@ -696,14 +680,13 @@ rte_pmd_null_devuninit(const char *name)\n \tRTE_LOG(INFO, PMD, \"Closing null ethdev on numa socket %u\\n\",\n \t\t\trte_socket_id());\n \n-\t/* reserve an ethdev entry */\n+\t/* find the ethdev entry */\n \teth_dev = rte_eth_dev_allocated(name);\n \tif (eth_dev == NULL)\n \t\treturn -1;\n \n \trte_free(eth_dev->data->dev_private);\n \trte_free(eth_dev->data);\n-\trte_free(eth_dev->pci_dev);\n \n \trte_eth_dev_release_port(eth_dev);\n \n", "prefixes": [ "dpdk-dev", "v8", "05/11" ] }