Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85761/?format=api
{ "id": 85761, "url": "https://patches.dpdk.org/api/patches/85761/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201229061736.92666-1-beilei.xing@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201229061736.92666-1-beilei.xing@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201229061736.92666-1-beilei.xing@intel.com", "date": "2020-12-29T06:17:36", "name": "[v2] net/i40e: fix flex payload rule conflict issue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "627e38a9929ac0e2feb757e7f6955092c9eeb28f", "submitter": { "id": 410, "url": "https://patches.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201229061736.92666-1-beilei.xing@intel.com/mbox/", "series": [ { "id": 14476, "url": "https://patches.dpdk.org/api/series/14476/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14476", "date": "2020-12-29T06:17:36", "name": "[v2] net/i40e: fix flex payload rule conflict issue", "version": 2, "mbox": "https://patches.dpdk.org/series/14476/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85761/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/85761/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F3131A09FF;\n\tMon, 28 Dec 2020 07:24:49 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 344F6C9AE;\n\tMon, 28 Dec 2020 07:24:48 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 73DCD2C2D;\n Mon, 28 Dec 2020 07:24:45 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Dec 2020 22:24:43 -0800", "from dpdk-beileix-3.sh.intel.com ([10.67.110.150])\n by orsmga008.jf.intel.com with ESMTP; 27 Dec 2020 22:24:41 -0800" ], "IronPort-SDR": [ "\n kG9mWTYdr5G6JV7mumiLX1T+pNot0GitOWJiEidV14Ly5PfiMKBmpDMeboTNPMwrJ8sEXwrvnz\n kwz1543R3/OQ==", "\n Dz9woEhmCO1fjjJfJPTBUxb/kvkv+8/KFk+2YQvWEd00Tc5IqFCx0TrtwTCWJZ17n4ibr2F1YN\n ZISNkug4W+AQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9847\"; a=\"240433391\"", "E=Sophos;i=\"5.78,454,1599548400\"; d=\"scan'208\";a=\"240433391\"", "E=Sophos;i=\"5.78,454,1599548400\"; d=\"scan'208\";a=\"375502111\"" ], "X-ExtLoop1": "1", "From": "beilei.xing@intel.com", "To": "jia.guo@intel.com,\n\tdev@dpdk.org", "Cc": "Beilei Xing <beilei.xing@intel.com>, stable@dpdk.org,\n Chenmin Sun <chenmin.sun@intel.com>", "Date": "Tue, 29 Dec 2020 14:17:36 +0800", "Message-Id": "<20201229061736.92666-1-beilei.xing@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20201229054639.92132-1-beilei.xing@intel.com>", "References": "<20201229054639.92132-1-beilei.xing@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: fix flex payload rule conflict issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Beilei Xing <beilei.xing@intel.com>\n\nWith the following commands, the second flow can't\nbe created successfully.\n\n1. flow create 0 ingress pattern eth / ipv4 / udp /\n raw relative is 1 pattern is 0102030405 / end\n actions drop / end\n2. flow destroy 0 rule 0\n3. flow create 0 ingress pattern eth / ipv4 / udp /\n raw relative is 1 pattern is 010203040506 / end\n actions drop / end\n\nThe root cause is that a flag for flex pit isn't reset.\n\nFixes: 6ced3dd72f5f (\"net/i40e: support flexible payload parsing for FDIR\")\nCc: stable@dpdk.org\n\nReported-by: Chenmin Sun<chenmin.sun@intel.com>\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\n---\n\nv2 changes:\n - Add fix line.\n - Refine comments.\n\n drivers/net/i40e/i40e_flow.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c\nindex b09ff6590d..65e0b69356 100644\n--- a/drivers/net/i40e/i40e_flow.c\n+++ b/drivers/net/i40e/i40e_flow.c\n@@ -5284,6 +5284,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev,\n \tenum rte_filter_type filter_type = flow->filter_type;\n \tstruct i40e_fdir_info *fdir_info = &pf->fdir;\n \tint ret = 0;\n+\tint i;\n \n \tswitch (filter_type) {\n \tcase RTE_ETH_FILTER_ETHERTYPE:\n@@ -5299,9 +5300,13 @@ i40e_flow_destroy(struct rte_eth_dev *dev,\n \t\t\t\t&((struct i40e_fdir_filter *)flow->rule)->fdir,\n \t\t\t\t0);\n \n-\t\t/* If the last flow is destroyed, disable fdir. */\n+\t\t/* When the last flow is destroyed. */\n \t\tif (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) {\n+\t\t\t/* Disable FDIR processing. */\n \t\t\ti40e_fdir_rx_proc_enable(dev, 0);\n+\t\t\t/* Reset the flex_pit_flag. */\n+\t\t\tfor (i = 0; i < I40E_MAX_FLXPLD_LAYER; i++)\n+\t\t\t\tpf->fdir.flex_pit_flag[i] = 0;\n \t\t}\n \t\tbreak;\n \tcase RTE_ETH_FILTER_HASH:\n@@ -5515,6 +5520,9 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf)\n \t\t\tpf->fdir.flex_mask_flag[pctype] = 0;\n \t\t}\n \n+\t\tfor (i = 0; i < I40E_MAX_FLXPLD_LAYER; i++)\n+\t\t\tpf->fdir.flex_pit_flag[i] = 0;\n+\n \t\t/* Disable FDIR processing as all FDIR rules are now flushed */\n \t\ti40e_fdir_rx_proc_enable(dev, 0);\n \t}\n", "prefixes": [ "v2" ] }