Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85723/?format=api
{ "id": 85723, "url": "https://patches.dpdk.org/api/patches/85723/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201224093734.13940-3-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201224093734.13940-3-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201224093734.13940-3-somnath.kotur@broadcom.com", "date": "2020-12-24T09:37:33", "name": "[2/3] net/bnxt: fix error path handling of dev start op", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6fc5936f9869bd9f8417f7e08726b939669bf410", "submitter": { "id": 908, "url": "https://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201224093734.13940-3-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 14458, "url": "https://patches.dpdk.org/api/series/14458/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14458", "date": "2020-12-24T09:37:32", "name": "[1/3] net/bnxt: fix to init/destroy locks only once", "version": 1, "mbox": "https://patches.dpdk.org/series/14458/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85723/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85723/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F1C5DA09FF;\n\tThu, 24 Dec 2020 10:46:59 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D7F53CA6E;\n\tThu, 24 Dec 2020 10:46:34 +0100 (CET)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.221.30]) by dpdk.org (Postfix) with ESMTP id 90F48CA16\n for <dev@dpdk.org>; Thu, 24 Dec 2020 10:46:29 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 5EE7024760;\n Thu, 24 Dec 2020 01:46:27 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 5EE7024760", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1608803187;\n bh=pxvnuLfeIRsutHc464kn9s2CovkqXxFEOgvi/LqRqVo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=cZy6gC4lEm9xXGZaN2mXqi5jIXk4nbIXuBKW/vLpW9zpcER1LYGrqu1+zw9R5VRMb\n EiNcrfs1q1YrV0fpEvm+DckLMtB6IOqRQaBpJrM15kvsjr3AKoRgRAjkVluXrV/9oG\n 50Lkj5FZ8wbE1W5KnlKWW+WoOCWqFWC9grPKJmrc=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tSomnath Kotur <somnath.kotur@broadcom.com>", "Date": "Thu, 24 Dec 2020 15:07:33 +0530", "Message-Id": "<20201224093734.13940-3-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.28.0.450.g3a238e5", "In-Reply-To": "<20201224093734.13940-1-somnath.kotur@broadcom.com>", "References": "<20201224063126.12232-1-somnath.kotur@broadcom.com>\n <20201224093734.13940-1-somnath.kotur@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/3] net/bnxt: fix error path handling of dev\n\tstart op", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Call bnxt_dev_stop in error path of bnxt_dev_start_op() to keep\nit simple and consistent\n\nFixes: c09f57b49c13 (\"net/bnxt: add start/stop/link update operations\")\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 144 ++++++++++++++++-----------------\n 1 file changed, 70 insertions(+), 74 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 6c38155da6..b6a9db1b66 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1239,80 +1239,6 @@ static int bnxt_handle_if_change_status(struct bnxt *bp)\n \treturn rc;\n }\n \n-static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n-{\n-\tstruct bnxt *bp = eth_dev->data->dev_private;\n-\tuint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads;\n-\tint vlan_mask = 0;\n-\tint rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT;\n-\n-\tif (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) {\n-\t\tPMD_DRV_LOG(ERR, \"Queues are not configured yet!\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tif (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS)\n-\t\tPMD_DRV_LOG(ERR,\n-\t\t\t \"RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\\n\",\n-\t\t\t bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\n-\tdo {\n-\t\trc = bnxt_hwrm_if_change(bp, true);\n-\t\tif (rc == 0 || rc != -EAGAIN)\n-\t\t\tbreak;\n-\n-\t\trte_delay_ms(BNXT_IF_CHANGE_RETRY_INTERVAL);\n-\t} while (retry_cnt--);\n-\n-\tif (rc)\n-\t\treturn rc;\n-\n-\tif (bp->flags & BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE) {\n-\t\trc = bnxt_handle_if_change_status(bp);\n-\t\tif (rc)\n-\t\t\treturn rc;\n-\t}\n-\n-\tbnxt_enable_int(bp);\n-\n-\trc = bnxt_init_chip(bp);\n-\tif (rc)\n-\t\tgoto error;\n-\n-\teth_dev->data->scattered_rx = bnxt_scattered_rx(eth_dev);\n-\teth_dev->data->dev_started = 1;\n-\n-\tbnxt_link_update_op(eth_dev, 1);\n-\n-\tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)\n-\t\tvlan_mask |= ETH_VLAN_FILTER_MASK;\n-\tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_STRIP)\n-\t\tvlan_mask |= ETH_VLAN_STRIP_MASK;\n-\trc = bnxt_vlan_offload_set_op(eth_dev, vlan_mask);\n-\tif (rc)\n-\t\tgoto error;\n-\n-\t/* Initialize bnxt ULP port details */\n-\trc = bnxt_ulp_port_init(bp);\n-\tif (rc)\n-\t\tgoto error;\n-\n-\teth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev);\n-\teth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev);\n-\n-\tbnxt_schedule_fw_health_check(bp);\n-\n-\treturn 0;\n-\n-error:\n-\tbnxt_shutdown_nic(bp);\n-\tbnxt_free_tx_mbufs(bp);\n-\tbnxt_free_rx_mbufs(bp);\n-\tbnxt_hwrm_if_change(bp, false);\n-\teth_dev->data->dev_started = 0;\n-\treturn rc;\n-}\n-\n static int bnxt_dev_set_link_up_op(struct rte_eth_dev *eth_dev)\n {\n \tstruct bnxt *bp = eth_dev->data->dev_private;\n@@ -1419,6 +1345,76 @@ static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n \treturn 0;\n }\n \n+static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct bnxt *bp = eth_dev->data->dev_private;\n+\tuint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads;\n+\tint vlan_mask = 0;\n+\tint rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT;\n+\n+\tif (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) {\n+\t\tPMD_DRV_LOG(ERR, \"Queues are not configured yet!\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS)\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\\n\",\n+\t\t\t bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n+\n+\tdo {\n+\t\trc = bnxt_hwrm_if_change(bp, true);\n+\t\tif (rc == 0 || rc != -EAGAIN)\n+\t\t\tbreak;\n+\n+\t\trte_delay_ms(BNXT_IF_CHANGE_RETRY_INTERVAL);\n+\t} while (retry_cnt--);\n+\n+\tif (rc)\n+\t\treturn rc;\n+\n+\tif (bp->flags & BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE) {\n+\t\trc = bnxt_handle_if_change_status(bp);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t}\n+\n+\tbnxt_enable_int(bp);\n+\n+\trc = bnxt_init_chip(bp);\n+\tif (rc)\n+\t\tgoto error;\n+\n+\teth_dev->data->scattered_rx = bnxt_scattered_rx(eth_dev);\n+\teth_dev->data->dev_started = 1;\n+\n+\tbnxt_link_update_op(eth_dev, 1);\n+\n+\tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)\n+\t\tvlan_mask |= ETH_VLAN_FILTER_MASK;\n+\tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_STRIP)\n+\t\tvlan_mask |= ETH_VLAN_STRIP_MASK;\n+\trc = bnxt_vlan_offload_set_op(eth_dev, vlan_mask);\n+\tif (rc)\n+\t\tgoto error;\n+\n+\t/* Initialize bnxt ULP port details */\n+\trc = bnxt_ulp_port_init(bp);\n+\tif (rc)\n+\t\tgoto error;\n+\n+\teth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev);\n+\teth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev);\n+\n+\tbnxt_schedule_fw_health_check(bp);\n+\n+\treturn 0;\n+\n+error:\n+\tbnxt_dev_stop_op(eth_dev);\n+\treturn rc;\n+}\n+\n static void\n bnxt_uninit_locks(struct bnxt *bp)\n {\n", "prefixes": [ "2/3" ] }