Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85722/?format=api
{ "id": 85722, "url": "https://patches.dpdk.org/api/patches/85722/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201224093734.13940-2-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201224093734.13940-2-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201224093734.13940-2-somnath.kotur@broadcom.com", "date": "2020-12-24T09:37:32", "name": "[1/3] net/bnxt: fix to init/destroy locks only once", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1f18c98e7accf524f02064185c43c0a745b41ec6", "submitter": { "id": 908, "url": "https://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201224093734.13940-2-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 14458, "url": "https://patches.dpdk.org/api/series/14458/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14458", "date": "2020-12-24T09:37:32", "name": "[1/3] net/bnxt: fix to init/destroy locks only once", "version": 1, "mbox": "https://patches.dpdk.org/series/14458/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85722/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85722/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2852A09FF;\n\tThu, 24 Dec 2020 10:46:46 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 82239CA40;\n\tThu, 24 Dec 2020 10:46:33 +0100 (CET)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.221.30]) by dpdk.org (Postfix) with ESMTP id 46DF3CA1A\n for <dev@dpdk.org>; Thu, 24 Dec 2020 10:46:29 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 08D742474E;\n Thu, 24 Dec 2020 01:46:26 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 08D742474E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1608803187;\n bh=yQhKSBJ3iAKW+9xao5MLnCR7hoEM/sD1CfUOGXgd+Kg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=UMPK80rPWroel8Exm3rt35M6PJ0hcz1LpNPgyk1jgo/shaDMbOMJ/iJmCfaIYa+5s\n hG5St24QpObbksw9DTKNmoB8hr2OleOtFh0Hglx/j1ajutq+FbEpCF3RAd+UzNbxLh\n ZF+2xekjkMjNusekDzmNnjo96GD7OXPX59uGTGPs=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tSomnath Kotur <somnath.kotur@broadcom.com>", "Date": "Thu, 24 Dec 2020 15:07:32 +0530", "Message-Id": "<20201224093734.13940-2-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.28.0.450.g3a238e5", "In-Reply-To": "<20201224093734.13940-1-somnath.kotur@broadcom.com>", "References": "<20201224063126.12232-1-somnath.kotur@broadcom.com>\n <20201224093734.13940-1-somnath.kotur@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/3] net/bnxt: fix to init/destroy locks only once", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Invoking init/uninit locks in init_resources and uninit_resources\nwould end up initializing and destroying locks on every port start\nstop which is not desired.\nMove the 2 routines to dev_init and dev_close respectively as\nlocks need to be initialized and destroyed only once during the\nlifetime of the driver.\n\nFixes: 1cb3d39a48f7 (\"net/bnxt: synchronize between flow related functions\")\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 34 +++++++++++++++++-----------------\n 1 file changed, 17 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 0788d263d8..6c38155da6 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1419,6 +1419,18 @@ static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n \treturn 0;\n }\n \n+static void\n+bnxt_uninit_locks(struct bnxt *bp)\n+{\n+\tpthread_mutex_destroy(&bp->flow_lock);\n+\tpthread_mutex_destroy(&bp->def_cp_lock);\n+\tpthread_mutex_destroy(&bp->health_check_lock);\n+\tif (bp->rep_info) {\n+\t\tpthread_mutex_destroy(&bp->rep_info->vfr_lock);\n+\t\tpthread_mutex_destroy(&bp->rep_info->vfr_start_lock);\n+\t}\n+}\n+\n static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n {\n \tstruct bnxt *bp = eth_dev->data->dev_private;\n@@ -1444,6 +1456,7 @@ static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n \tbnxt_free_link_info(bp);\n \tbnxt_free_pf_info(bp);\n \tbnxt_free_parent_info(bp);\n+\tbnxt_uninit_locks(bp);\n \n \trte_memzone_free((const struct rte_memzone *)bp->tx_mem_zone);\n \tbp->tx_mem_zone = NULL;\n@@ -4790,10 +4803,6 @@ static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev)\n \t\treturn rc;\n \t}\n \n-\trc = bnxt_init_locks(bp);\n-\tif (rc)\n-\t\treturn rc;\n-\n \treturn 0;\n }\n \n@@ -5280,6 +5289,10 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)\n \tif (rc)\n \t\tgoto error_free;\n \n+\trc = bnxt_init_locks(bp);\n+\tif (rc)\n+\t\tgoto error_free;\n+\n \trc = bnxt_init_resources(bp, false);\n \tif (rc)\n \t\tgoto error_free;\n@@ -5371,18 +5384,6 @@ bnxt_free_error_recovery_info(struct bnxt *bp)\n \tbp->fw_cap &= ~BNXT_FW_CAP_ERROR_RECOVERY;\n }\n \n-static void\n-bnxt_uninit_locks(struct bnxt *bp)\n-{\n-\tpthread_mutex_destroy(&bp->flow_lock);\n-\tpthread_mutex_destroy(&bp->def_cp_lock);\n-\tpthread_mutex_destroy(&bp->health_check_lock);\n-\tif (bp->rep_info) {\n-\t\tpthread_mutex_destroy(&bp->rep_info->vfr_lock);\n-\t\tpthread_mutex_destroy(&bp->rep_info->vfr_start_lock);\n-\t}\n-}\n-\n static int\n bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev)\n {\n@@ -5404,7 +5405,6 @@ bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev)\n \n \tbnxt_uninit_ctx_mem(bp);\n \n-\tbnxt_uninit_locks(bp);\n \tbnxt_free_flow_stats_info(bp);\n \tbnxt_free_rep_info(bp);\n \trte_free(bp->ptp_cfg);\n", "prefixes": [ "1/3" ] }