Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8572/?format=api
{ "id": 8572, "url": "https://patches.dpdk.org/api/patches/8572/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1446555725-19540-5-git-send-email-bernard.iremonger@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1446555725-19540-5-git-send-email-bernard.iremonger@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1446555725-19540-5-git-send-email-bernard.iremonger@intel.com", "date": "2015-11-03T13:01:58", "name": "[dpdk-dev,v8,04/11] librte_ether: remove branches on pci_dev", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e0dc4741354d70375f68eda56ade26d6f3254c80", "submitter": { "id": 91, "url": "https://patches.dpdk.org/api/people/91/?format=api", "name": "Iremonger, Bernard", "email": "bernard.iremonger@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1446555725-19540-5-git-send-email-bernard.iremonger@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/8572/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/8572/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AA03E8E8C;\n\tTue, 3 Nov 2015 14:02:16 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 92BB38E8A\n\tfor <dev@dpdk.org>; Tue, 3 Nov 2015 14:02:14 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga103.fm.intel.com with ESMTP; 03 Nov 2015 05:02:14 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 03 Nov 2015 05:02:13 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ttA3D2CqV011921; Tue, 3 Nov 2015 13:02:12 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id tA3D2CEY019622;\n\tTue, 3 Nov 2015 13:02:12 GMT", "(from bairemon@localhost)\n\tby sivswdev01.ir.intel.com with id tA3D2CIb019617;\n\tTue, 3 Nov 2015 13:02:12 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,238,1444719600\"; d=\"scan'208\";a=\"842000362\"", "From": "Bernard Iremonger <bernard.iremonger@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 3 Nov 2015 13:01:58 +0000", "Message-Id": "<1446555725-19540-5-git-send-email-bernard.iremonger@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1446555725-19540-1-git-send-email-bernard.iremonger@intel.com>", "References": "<PATCH v8>\n\t<1446555725-19540-1-git-send-email-bernard.iremonger@intel.com>", "Subject": "[dpdk-dev] [PATCH v8 04/11] librte_ether: remove branches on pci_dev", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "use dev_type to distinguish between vdev's and pdev's.\nremove pci_dev branches.\nupdate release notes.\n\nSigned-off-by: Bernard Iremonger <bernard.iremonger@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n doc/guides/rel_notes/release_2_2.rst | 3 +++\n lib/librte_ether/rte_ethdev.c | 40 +++++++++++++++---------------------\n 2 files changed, 20 insertions(+), 23 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst\nindex 8a20044..b7d0984 100644\n--- a/doc/guides/rel_notes/release_2_2.rst\n+++ b/doc/guides/rel_notes/release_2_2.rst\n@@ -59,6 +59,9 @@ New Features\n \n * **Added port hotplug support to xenvirt.**\n \n+* **Removed the PCI device from vdev PMD's.**\n+\n+ * This change required modifications to librte_ether and all vdev and pdev PMD's.\n \n Resolved Issues\n ---------------\ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 04eff73..d8e791c 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -424,7 +424,7 @@ rte_eth_dev_socket_id(uint8_t port_id)\n {\n \tif (!rte_eth_dev_is_valid_port(port_id))\n \t\treturn -1;\n-\treturn rte_eth_devices[port_id].pci_dev->numa_node;\n+\treturn rte_eth_devices[port_id].data->numa_node;\n }\n \n uint8_t\n@@ -503,27 +503,25 @@ rte_eth_dev_get_name_by_port(uint8_t port_id, char *name)\n static int\n rte_eth_dev_is_detachable(uint8_t port_id)\n {\n-\tuint32_t drv_flags;\n+\tuint32_t dev_flags;\n \n \tif (!rte_eth_dev_is_valid_port(port_id)) {\n \t\tPMD_DEBUG_TRACE(\"Invalid port_id=%d\\n\", port_id);\n \t\treturn -EINVAL;\n \t}\n \n-\tif (rte_eth_devices[port_id].dev_type == RTE_ETH_DEV_PCI) {\n-\t\tswitch (rte_eth_devices[port_id].pci_dev->kdrv) {\n-\t\tcase RTE_KDRV_IGB_UIO:\n-\t\tcase RTE_KDRV_UIO_GENERIC:\n-\t\tcase RTE_KDRV_NIC_UIO:\n-\t\t\tbreak;\n-\t\tcase RTE_KDRV_VFIO:\n-\t\tdefault:\n-\t\t\treturn -ENOTSUP;\n-\t\t}\n+\tswitch (rte_eth_devices[port_id].data->kdrv) {\n+\tcase RTE_KDRV_IGB_UIO:\n+\tcase RTE_KDRV_UIO_GENERIC:\n+\tcase RTE_KDRV_NIC_UIO:\n+\tcase RTE_KDRV_NONE:\n+\t\tbreak;\n+\tcase RTE_KDRV_VFIO:\n+\tdefault:\n+\t\treturn -ENOTSUP;\n \t}\n-\n-\tdrv_flags = rte_eth_devices[port_id].driver->pci_drv.drv_flags;\n-\treturn !(drv_flags & RTE_PCI_DRV_DETACHABLE);\n+\tdev_flags = rte_eth_devices[port_id].data->dev_flags;\n+\treturn !(dev_flags & RTE_ETH_DEV_DETACHABLE);\n }\n \n /* attach the new physical device, then store port_id of the device */\n@@ -952,14 +950,11 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t * If link state interrupt is enabled, check that the\n \t * device supports it.\n \t */\n-\tif (dev_conf->intr_conf.lsc == 1) {\n-\t\tconst struct rte_pci_driver *pci_drv = &dev->driver->pci_drv;\n-\n-\t\tif (!(pci_drv->drv_flags & RTE_PCI_DRV_INTR_LSC)) {\n+\tif ((dev_conf->intr_conf.lsc == 1) &&\n+\t\t(!(dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC))) {\n \t\t\tPMD_DEBUG_TRACE(\"driver %s does not support lsc\\n\",\n-\t\t\t\t\tpci_drv->name);\n+\t\t\t\t\tdev->data->drv_name);\n \t\t\treturn -EINVAL;\n-\t\t}\n \t}\n \n \t/*\n@@ -1616,8 +1611,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info *dev_info)\n \tFUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get);\n \t(*dev->dev_ops->dev_infos_get)(dev, dev_info);\n \tdev_info->pci_dev = dev->pci_dev;\n-\tif (dev->driver)\n-\t\tdev_info->driver_name = dev->driver->pci_drv.name;\n+\tdev_info->driver_name = dev->data->drv_name;\n }\n \n void\n", "prefixes": [ "dpdk-dev", "v8", "04/11" ] }