Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85685/?format=api
{ "id": 85685, "url": "https://patches.dpdk.org/api/patches/85685/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1608724059-8562-11-git-send-email-juraj.linkes@pantheon.tech/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1608724059-8562-11-git-send-email-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/1608724059-8562-11-git-send-email-juraj.linkes@pantheon.tech", "date": "2020-12-23T11:47:37", "name": "[v14,10/12] build: disable libnuma in cross builds", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d62e3b0fff569a375cf8437415d0e0921fde867d", "submitter": { "id": 1626, "url": "https://patches.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1608724059-8562-11-git-send-email-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 14439, "url": "https://patches.dpdk.org/api/series/14439/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14439", "date": "2020-12-23T11:47:27", "name": "Arm build options rework", "version": 14, "mbox": "https://patches.dpdk.org/series/14439/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85685/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85685/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1B888A052A;\n\tWed, 23 Dec 2020 12:51:06 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 819C9CB45;\n\tWed, 23 Dec 2020 12:48:04 +0100 (CET)", "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by dpdk.org (Postfix) with ESMTP id BB9FFCAAF\n for <dev@dpdk.org>; Wed, 23 Dec 2020 12:47:59 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id 949D6BE9DF;\n Wed, 23 Dec 2020 12:47:57 +0100 (CET)", "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id NgByWqc3Sbzs; Wed, 23 Dec 2020 12:47:56 +0100 (CET)", "from service-node1.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id 05834BF46E;\n Wed, 23 Dec 2020 12:47:49 +0100 (CET)" ], "X-Virus-Scanned": "amavisd-new at siecit.sk", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "bruce.richardson@intel.com, Ruifeng.Wang@arm.com,\n Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com,\n Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com,\n ajit.khaparde@broadcom.com, ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "Date": "Wed, 23 Dec 2020 12:47:37 +0100", "Message-Id": "<1608724059-8562-11-git-send-email-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech>", "References": "<1605874101-30893-1-git-send-email-juraj.linkes@pantheon.tech>\n <1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v14 10/12] build: disable libnuma in cross builds", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA\nfor cross build and disable NUMA in Arm cross files.\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n config/arm/arm64_armada_linux_gcc | 1 +\n config/arm/arm64_bluefield_linux_gcc | 1 +\n config/arm/arm64_dpaa_linux_gcc | 1 +\n config/arm/arm64_graviton2_linux_gcc | 1 +\n config/arm/arm64_n1sdp_linux_gcc | 1 +\n config/arm/arm64_octeontx2_linux_gcc | 1 +\n config/arm/arm64_stingray_linux_gcc | 1 +\n config/arm/meson.build | 2 --\n config/meson.build | 19 +++++++++++++------\n .../linux_gsg/cross_build_dpdk_for_arm64.rst | 4 ++++\n 10 files changed, 24 insertions(+), 8 deletions(-)", "diff": "diff --git a/config/arm/arm64_armada_linux_gcc b/config/arm/arm64_armada_linux_gcc\nindex e365f61d0..487cb2923 100644\n--- a/config/arm/arm64_armada_linux_gcc\n+++ b/config/arm/arm64_armada_linux_gcc\n@@ -18,4 +18,5 @@ implementer_id = '0x56'\n part_number = '0xd08'\n max_lcores = 16\n max_numa_nodes = 1\n+numa = false\n disabled_drivers = ['bus/dpaa', 'bus/fslmc', 'common/dpaax']\ndiff --git a/config/arm/arm64_bluefield_linux_gcc b/config/arm/arm64_bluefield_linux_gcc\nindex 4f56790c5..6bef87fbd 100644\n--- a/config/arm/arm64_bluefield_linux_gcc\n+++ b/config/arm/arm64_bluefield_linux_gcc\n@@ -17,3 +17,4 @@ implementer_id = '0x41'\n part_number = '0xd08'\n max_lcores = 16\n max_numa_nodes = 1\n+numa = false\ndiff --git a/config/arm/arm64_dpaa_linux_gcc b/config/arm/arm64_dpaa_linux_gcc\nindex 8641fee63..37398c762 100644\n--- a/config/arm/arm64_dpaa_linux_gcc\n+++ b/config/arm/arm64_dpaa_linux_gcc\n@@ -18,3 +18,4 @@ implementer_id = 'dpaa'\n part_number = '0xd08'\n max_lcores = 16\n max_numa_nodes = 1\n+numa = false\ndiff --git a/config/arm/arm64_graviton2_linux_gcc b/config/arm/arm64_graviton2_linux_gcc\nindex d0bfec87d..cfe239797 100644\n--- a/config/arm/arm64_graviton2_linux_gcc\n+++ b/config/arm/arm64_graviton2_linux_gcc\n@@ -17,3 +17,4 @@ implementor_id = '0x41'\n implementor_pn = '0xd0c'\n max_lcores = 64\n max_numa_nodes = 1\n+numa = false\ndiff --git a/config/arm/arm64_n1sdp_linux_gcc b/config/arm/arm64_n1sdp_linux_gcc\nindex 138ae08c3..b00f2d1ef 100644\n--- a/config/arm/arm64_n1sdp_linux_gcc\n+++ b/config/arm/arm64_n1sdp_linux_gcc\n@@ -17,3 +17,4 @@ implementer_id = '0x41'\n part_number = '0xd0c'\n max_lcores = 4\n max_numa_nodes = 1\n+numa = false\ndiff --git a/config/arm/arm64_octeontx2_linux_gcc b/config/arm/arm64_octeontx2_linux_gcc\nindex 26cf471ad..593769709 100644\n--- a/config/arm/arm64_octeontx2_linux_gcc\n+++ b/config/arm/arm64_octeontx2_linux_gcc\n@@ -17,3 +17,4 @@ implementer_id = '0x43'\n part_number = '0xb2'\n max_lcores = 36\n max_numa_nodes = 1\n+numa = false\ndiff --git a/config/arm/arm64_stingray_linux_gcc b/config/arm/arm64_stingray_linux_gcc\nindex 4f56790c5..6bef87fbd 100644\n--- a/config/arm/arm64_stingray_linux_gcc\n+++ b/config/arm/arm64_stingray_linux_gcc\n@@ -17,3 +17,4 @@ implementer_id = '0x41'\n part_number = '0xd08'\n max_lcores = 16\n max_numa_nodes = 1\n+numa = false\ndiff --git a/config/arm/meson.build b/config/arm/meson.build\nindex 7db343b8a..f5e1ad20c 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -61,8 +61,6 @@ part_number_config_arm = {\n \t\t\t['RTE_MACHINE', '\"neoverse-n1\"'],\n \t\t\t['RTE_ARM_FEATURE_ATOMICS', true],\n \t\t\t['RTE_USE_C11_MEM_MODEL', true],\n-\t\t\t['RTE_EAL_NUMA_AWARE_HUGEPAGES', false],\n-\t\t\t['RTE_LIBRTE_VHOST_NUMA', false],\n \t\t\t['RTE_MAX_MEM_MB', 1048576],\n \t\t\t['RTE_CACHE_LINE_SIZE', 64],\n \t\t\t['RTE_MAX_LCORE', 64],\ndiff --git a/config/meson.build b/config/meson.build\nindex 19c743091..7fbd09e37 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -142,12 +142,19 @@ endif\n \n # check for libraries used in multiple places in DPDK\n has_libnuma = 0\n-numa_dep = cc.find_library('numa', required: false)\n-if numa_dep.found() and cc.has_header('numaif.h')\n-\tdpdk_conf.set10('RTE_HAS_LIBNUMA', true)\n-\thas_libnuma = 1\n-\tadd_project_link_arguments('-lnuma', language: 'c')\n-\tdpdk_extra_ldflags += '-lnuma'\n+find_libnuma = true\n+if meson.is_cross_build() and not meson.get_cross_property('numa', true)\n+\t# don't look for libnuma if explicitly disabled in cross build\n+\tcheck_libnuma = false\n+endif\n+if find_libnuma\n+\tnuma_dep = cc.find_library('numa', required: false)\n+\tif numa_dep.found() and cc.has_header('numaif.h')\n+\t\tdpdk_conf.set10('RTE_HAS_LIBNUMA', true)\n+\t\thas_libnuma = 1\n+\t\tadd_project_link_arguments('-lnuma', language: 'c')\n+\t\tdpdk_extra_ldflags += '-lnuma'\n+\tendif\n endif\n \n has_libfdt = 0\ndiff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst\nindex 210ad4508..063661ebf 100644\n--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst\n+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst\n@@ -147,3 +147,7 @@ There are other options you may specify in a cross file to tailor the build::\n disabled_drivers = ['bus/dpaa', 'crypto'] # add disabled drivers\n # valid values are directories (optionally with their subdirs)\n # in the drivers directory\n+\n+ numa = false # set to false to force building for a non-NUMA system\n+ # if not set or set to true, the build system will build for a NUMA\n+ # system only if libnuma is installed\n", "prefixes": [ "v14", "10/12" ] }