Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85664/?format=api
{ "id": 85664, "url": "https://patches.dpdk.org/api/patches/85664/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201223053018.103877-1-dapengx.yu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201223053018.103877-1-dapengx.yu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201223053018.103877-1-dapengx.yu@intel.com", "date": "2020-12-23T05:30:18", "name": "net/ice: check Rx queue number on RSS init", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6d5876675751128f59d87bba7bfbc011494a2888", "submitter": { "id": 2042, "url": "https://patches.dpdk.org/api/people/2042/?format=api", "name": "Yu, DapengX", "email": "dapengx.yu@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201223053018.103877-1-dapengx.yu@intel.com/mbox/", "series": [ { "id": 14430, "url": "https://patches.dpdk.org/api/series/14430/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14430", "date": "2020-12-23T05:30:18", "name": "net/ice: check Rx queue number on RSS init", "version": 1, "mbox": "https://patches.dpdk.org/series/14430/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85664/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85664/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 39587A09EF;\n\tWed, 23 Dec 2020 06:30:40 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0DD33CA3C;\n\tWed, 23 Dec 2020 06:30:39 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 32C98CA32;\n Wed, 23 Dec 2020 06:30:36 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Dec 2020 21:30:32 -0800", "from unknown (HELO localhost.localdomain) ([10.240.183.93])\n by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Dec 2020 21:30:29 -0800" ], "IronPort-SDR": [ "\n ww0IEmqABWgpxSfG+ocdKhaTbodbZt8TRAlumY6ym6Oblvm8qjISUsm5Aj2v65S/zfJbjEF9Bg\n FQaaeFoqxyIA==", "\n gQYN2j/JY+jKvO5aEDDJmShjaG1SmhdFALC1vD5PzkXz7ykHVQQ5uBes1iu7BDIuK9jHvdO5GI\n aogXXopxMe2A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9843\"; a=\"176111943\"", "E=Sophos;i=\"5.78,441,1599548400\"; d=\"scan'208\";a=\"176111943\"", "E=Sophos;i=\"5.78,441,1599548400\"; d=\"scan'208\";a=\"344825358\"" ], "From": "dapengx.yu@intel.com", "To": "qiming.yang@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tYU DAPENG <dapengx.yu@intel.com>,\n\tstable@dpdk.org", "Date": "Wed, 23 Dec 2020 13:30:18 +0800", "Message-Id": "<20201223053018.103877-1-dapengx.yu@intel.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/ice: check Rx queue number on RSS init", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: YU DAPENG <dapengx.yu@intel.com>\n\nWhen RSS is initialized, rx queues number is used as denominator to set\ndefault value into the RSS lookup table. If it is zero, there will be\nerror of being divided by 0. So add value check to avoid the error.\n\nFixes: 50370662b727 (\"net/ice: support device and queue ops\")\nCc: stable@dpdk.org\n\nSigned-off-by: YU DAPENG <dapengx.yu@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 9a5d6a559..bbb8c1460 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -3182,6 +3182,12 @@ static int ice_init_rss(struct ice_pf *pf)\n \tvsi->rss_key_size = ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE;\n \tvsi->rss_lut_size = pf->hash_lut_size;\n \n+\tif (nb_q == 0) {\n+\t\tPMD_DRV_LOG(WARNING,\n+\t\t\t\"RSS is not supported as rx queues number is zero\\n\");\n+\t\treturn 0;\n+\t}\n+\n \tif (is_safe_mode) {\n \t\tPMD_DRV_LOG(WARNING, \"RSS is not supported in safe mode\\n\");\n \t\treturn 0;\n", "prefixes": [] }