Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 85659,
    "url": "https://patches.dpdk.org/api/patches/85659/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201222144243.552262-3-abhinandan.gujjar@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201222144243.552262-3-abhinandan.gujjar@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201222144243.552262-3-abhinandan.gujjar@intel.com",
    "date": "2020-12-22T14:42:43",
    "name": "[v7,2/2] test: add testcase for crypto enqueue and dequeue callback",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "fbd3cf1d91ac7db26028441ddd937caf70b0f2a3",
    "submitter": {
        "id": 883,
        "url": "https://patches.dpdk.org/api/people/883/?format=api",
        "name": "Gujjar, Abhinandan S",
        "email": "abhinandan.gujjar@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "https://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201222144243.552262-3-abhinandan.gujjar@intel.com/mbox/",
    "series": [
        {
            "id": 14425,
            "url": "https://patches.dpdk.org/api/series/14425/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14425",
            "date": "2020-12-22T14:42:41",
            "name": "support enqueue & dequeue callbacks on cryptodev",
            "version": 7,
            "mbox": "https://patches.dpdk.org/series/14425/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/85659/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/85659/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B12A2A052A;\n\tTue, 22 Dec 2020 15:44:06 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B3849CA63;\n\tTue, 22 Dec 2020 15:43:36 +0100 (CET)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id 1BE86CA56\n for <dev@dpdk.org>; Tue, 22 Dec 2020 15:43:33 +0100 (CET)",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Dec 2020 06:43:33 -0800",
            "from unknown (HELO broadwell-dev-2.iind.intel.com) ([10.190.210.98])\n by FMSMGA003.fm.intel.com with ESMTP; 22 Dec 2020 06:43:31 -0800"
        ],
        "IronPort-SDR": [
            "\n DeBA6Cg17Sr78Q7iB0Dfi/ImfNJ+zNs4WXx9WLKW42uaSRHI77z64owTy+h8I6LsdqDUzhzzFf\n oZYCZ/4W3OXg==",
            "\n S7nnkbNcjnRdVI8BHbNgZhL11A+z+js2VvYYKrZVidFB/XCFii81YV9YWMhU1jSa7yQabSTKfK\n eiAtOsCd1pMg=="
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6000,8403,9842\"; a=\"173307025\"",
            "E=Sophos;i=\"5.78,438,1599548400\"; d=\"scan'208\";a=\"173307025\"",
            "E=Sophos;i=\"5.78,438,1599548400\"; d=\"scan'208\";a=\"397228932\""
        ],
        "X-ExtLoop1": "1",
        "From": "Abhinandan Gujjar <abhinandan.gujjar@intel.com>",
        "To": "dev@dpdk.org,\n\takhil.goyal@nxp.com,\n\tkonstantin.ananyev@intel.com",
        "Cc": "abhinandan.gujjar@intel.com",
        "Date": "Tue, 22 Dec 2020 20:12:43 +0530",
        "Message-Id": "<20201222144243.552262-3-abhinandan.gujjar@intel.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20201222144243.552262-1-abhinandan.gujjar@intel.com>",
        "References": "<20201222144243.552262-1-abhinandan.gujjar@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v7 2/2] test: add testcase for crypto enqueue and\n\tdequeue callback",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch adds test cases for testing functionality of\nenqueue and dequeue callback mechanism.\n\nSigned-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n app/test/test_cryptodev.c | 244 +++++++++++++++++++++++++++++++++++++-\n 1 file changed, 242 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 8189053c1..ae2245609 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -10727,6 +10727,246 @@ test_null_burst_operation(void)\n \treturn TEST_SUCCESS;\n }\n \n+static uint16_t\n+test_enq_callback(uint16_t dev_id, uint16_t qp_id, struct rte_crypto_op **ops,\n+\t\t  uint16_t nb_ops, void *user_param)\n+{\n+\tRTE_SET_USED(dev_id);\n+\tRTE_SET_USED(qp_id);\n+\tRTE_SET_USED(ops);\n+\tRTE_SET_USED(user_param);\n+\n+\tprintf(\"crypto enqueue callback called\\n\");\n+\treturn nb_ops;\n+}\n+\n+static uint16_t\n+test_deq_callback(uint16_t dev_id, uint16_t qp_id, struct rte_crypto_op **ops,\n+\t\t  uint16_t nb_ops, void *user_param)\n+{\n+\tRTE_SET_USED(dev_id);\n+\tRTE_SET_USED(qp_id);\n+\tRTE_SET_USED(ops);\n+\tRTE_SET_USED(user_param);\n+\n+\tprintf(\"crypto dequeue callback called\\n\");\n+\treturn nb_ops;\n+}\n+\n+/*\n+ * Thread using enqueue/dequeue callback with RCU.\n+ */\n+static int\n+test_enqdeq_callback_thread(void *arg)\n+{\n+\tRTE_SET_USED(arg);\n+\t/* DP thread calls rte_cryptodev_enqueue_burst()/\n+\t * rte_cryptodev_dequeue_burst() and invokes callback.\n+\t */\n+\ttest_null_burst_operation();\n+\treturn 0;\n+}\n+\n+static int\n+test_enq_callback_setup(void)\n+{\n+\tstruct crypto_testsuite_params *ts_params = &testsuite_params;\n+\tstruct rte_cryptodev_info dev_info;\n+\tstruct rte_cryptodev_qp_conf qp_conf = {\n+\t\t.nb_descriptors = MAX_NUM_OPS_INFLIGHT\n+\t};\n+\n+\tstruct rte_cryptodev_cb *cb;\n+\tuint16_t qp_id = 0;\n+\n+\t/* Stop the device in case it's started so it can be configured */\n+\trte_cryptodev_stop(ts_params->valid_devs[0]);\n+\n+\trte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);\n+\n+\tTEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0],\n+\t\t\t&ts_params->conf),\n+\t\t\t\"Failed to configure cryptodev %u\",\n+\t\t\tts_params->valid_devs[0]);\n+\n+\tqp_conf.nb_descriptors = MAX_NUM_OPS_INFLIGHT;\n+\tqp_conf.mp_session = ts_params->session_mpool;\n+\tqp_conf.mp_session_private = ts_params->session_priv_mpool;\n+\n+\tTEST_ASSERT_SUCCESS(rte_cryptodev_queue_pair_setup(\n+\t\t\tts_params->valid_devs[0], qp_id, &qp_conf,\n+\t\t\trte_cryptodev_socket_id(ts_params->valid_devs[0])),\n+\t\t\t\"Failed test for \"\n+\t\t\t\"rte_cryptodev_queue_pair_setup: num_inflights \"\n+\t\t\t\"%u on qp %u on cryptodev %u\",\n+\t\t\tqp_conf.nb_descriptors, qp_id,\n+\t\t\tts_params->valid_devs[0]);\n+\n+\t/* Test with invalid crypto device */\n+\tcb = rte_cryptodev_add_enq_callback(RTE_CRYPTO_MAX_DEVS,\n+\t\t\tqp_id, test_enq_callback, NULL);\n+\tTEST_ASSERT_NULL(cb, \"Add callback on qp %u on \"\n+\t\t\t\"cryptodev %u did not fail\",\n+\t\t\tqp_id, RTE_CRYPTO_MAX_DEVS);\n+\n+\t/* Test with invalid queue pair */\n+\tcb = rte_cryptodev_add_enq_callback(ts_params->valid_devs[0],\n+\t\t\tdev_info.max_nb_queue_pairs + 1,\n+\t\t\ttest_enq_callback, NULL);\n+\tTEST_ASSERT_NULL(cb, \"Add callback on qp %u on \"\n+\t\t\t\"cryptodev %u did not fail\",\n+\t\t\tdev_info.max_nb_queue_pairs + 1,\n+\t\t\tts_params->valid_devs[0]);\n+\n+\t/* Test with NULL callback */\n+\tcb = rte_cryptodev_add_enq_callback(ts_params->valid_devs[0],\n+\t\t\tqp_id, NULL, NULL);\n+\tTEST_ASSERT_NULL(cb, \"Add callback on qp %u on \"\n+\t\t\t\"cryptodev %u did not fail\",\n+\t\t\tqp_id, ts_params->valid_devs[0]);\n+\n+\t/* Test with valid configuration */\n+\tcb = rte_cryptodev_add_enq_callback(ts_params->valid_devs[0],\n+\t\t\tqp_id, test_enq_callback, NULL);\n+\tTEST_ASSERT_NOT_NULL(cb, \"Failed test to add callback on \"\n+\t\t\t\"qp %u on cryptodev %u\",\n+\t\t\tqp_id, ts_params->valid_devs[0]);\n+\n+\trte_cryptodev_start(ts_params->valid_devs[0]);\n+\n+\t/* Launch a thread */\n+\trte_eal_remote_launch(test_enqdeq_callback_thread, NULL,\n+\t\t\t\trte_get_next_lcore(-1, 1, 0));\n+\n+\t/* Wait until reader exited. */\n+\trte_eal_mp_wait_lcore();\n+\n+\t/* Test with invalid crypto device */\n+\tTEST_ASSERT_FAIL(rte_cryptodev_remove_enq_callback(\n+\t\t\tRTE_CRYPTO_MAX_DEVS, qp_id, cb),\n+\t\t\t\"Expected call to fail as crypto device is invalid\");\n+\n+\t/* Test with invalid queue pair */\n+\tTEST_ASSERT_FAIL(rte_cryptodev_remove_enq_callback(\n+\t\t\tts_params->valid_devs[0],\n+\t\t\tdev_info.max_nb_queue_pairs + 1, cb),\n+\t\t\t\"Expected call to fail as queue pair is invalid\");\n+\n+\t/* Test with NULL callback */\n+\tTEST_ASSERT_FAIL(rte_cryptodev_remove_enq_callback(\n+\t\t\tts_params->valid_devs[0], qp_id, NULL),\n+\t\t\t\"Expected call to fail as callback is NULL\");\n+\n+\t/* Test with valid configuration */\n+\tTEST_ASSERT_SUCCESS(rte_cryptodev_remove_enq_callback(\n+\t\t\tts_params->valid_devs[0], qp_id, cb),\n+\t\t\t\"Failed test to remove callback on \"\n+\t\t\t\"qp %u on cryptodev %u\",\n+\t\t\tqp_id, ts_params->valid_devs[0]);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+static int\n+test_deq_callback_setup(void)\n+{\n+\tstruct crypto_testsuite_params *ts_params = &testsuite_params;\n+\tstruct rte_cryptodev_info dev_info;\n+\tstruct rte_cryptodev_qp_conf qp_conf = {\n+\t\t.nb_descriptors = MAX_NUM_OPS_INFLIGHT\n+\t};\n+\n+\tstruct rte_cryptodev_cb *cb;\n+\tuint16_t qp_id = 0;\n+\n+\t/* Stop the device in case it's started so it can be configured */\n+\trte_cryptodev_stop(ts_params->valid_devs[0]);\n+\n+\trte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);\n+\n+\tTEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0],\n+\t\t\t&ts_params->conf),\n+\t\t\t\"Failed to configure cryptodev %u\",\n+\t\t\tts_params->valid_devs[0]);\n+\n+\tqp_conf.nb_descriptors = MAX_NUM_OPS_INFLIGHT;\n+\tqp_conf.mp_session = ts_params->session_mpool;\n+\tqp_conf.mp_session_private = ts_params->session_priv_mpool;\n+\n+\tTEST_ASSERT_SUCCESS(rte_cryptodev_queue_pair_setup(\n+\t\t\tts_params->valid_devs[0], qp_id, &qp_conf,\n+\t\t\trte_cryptodev_socket_id(ts_params->valid_devs[0])),\n+\t\t\t\"Failed test for \"\n+\t\t\t\"rte_cryptodev_queue_pair_setup: num_inflights \"\n+\t\t\t\"%u on qp %u on cryptodev %u\",\n+\t\t\tqp_conf.nb_descriptors, qp_id,\n+\t\t\tts_params->valid_devs[0]);\n+\n+\t/* Test with invalid crypto device */\n+\tcb = rte_cryptodev_add_deq_callback(RTE_CRYPTO_MAX_DEVS,\n+\t\t\tqp_id, test_deq_callback, NULL);\n+\tTEST_ASSERT_NULL(cb, \"Add callback on qp %u on \"\n+\t\t\t\"cryptodev %u did not fail\",\n+\t\t\tqp_id, RTE_CRYPTO_MAX_DEVS);\n+\n+\t/* Test with invalid queue pair */\n+\tcb = rte_cryptodev_add_deq_callback(ts_params->valid_devs[0],\n+\t\t\tdev_info.max_nb_queue_pairs + 1,\n+\t\t\ttest_deq_callback, NULL);\n+\tTEST_ASSERT_NULL(cb, \"Add callback on qp %u on \"\n+\t\t\t\"cryptodev %u did not fail\",\n+\t\t\tdev_info.max_nb_queue_pairs + 1,\n+\t\t\tts_params->valid_devs[0]);\n+\n+\t/* Test with NULL callback */\n+\tcb = rte_cryptodev_add_deq_callback(ts_params->valid_devs[0],\n+\t\t\tqp_id, NULL, NULL);\n+\tTEST_ASSERT_NULL(cb, \"Add callback on qp %u on \"\n+\t\t\t\"cryptodev %u did not fail\",\n+\t\t\tqp_id, ts_params->valid_devs[0]);\n+\n+\t/* Test with valid configuration */\n+\tcb = rte_cryptodev_add_deq_callback(ts_params->valid_devs[0],\n+\t\t\tqp_id, test_deq_callback, NULL);\n+\tTEST_ASSERT_NOT_NULL(cb, \"Failed test to add callback on \"\n+\t\t\t\"qp %u on cryptodev %u\",\n+\t\t\tqp_id, ts_params->valid_devs[0]);\n+\n+\trte_cryptodev_start(ts_params->valid_devs[0]);\n+\n+\t/* Launch a thread */\n+\trte_eal_remote_launch(test_enqdeq_callback_thread, NULL,\n+\t\t\t\trte_get_next_lcore(-1, 1, 0));\n+\n+\t/* Wait until reader exited. */\n+\trte_eal_mp_wait_lcore();\n+\n+\t/* Test with invalid crypto device */\n+\tTEST_ASSERT_FAIL(rte_cryptodev_remove_deq_callback(\n+\t\t\tRTE_CRYPTO_MAX_DEVS, qp_id, cb),\n+\t\t\t\"Expected call to fail as crypto device is invalid\");\n+\n+\t/* Test with invalid queue pair */\n+\tTEST_ASSERT_FAIL(rte_cryptodev_remove_deq_callback(\n+\t\t\tts_params->valid_devs[0],\n+\t\t\tdev_info.max_nb_queue_pairs + 1, cb),\n+\t\t\t\"Expected call to fail as queue pair is invalid\");\n+\n+\t/* Test with NULL callback */\n+\tTEST_ASSERT_FAIL(rte_cryptodev_remove_deq_callback(\n+\t\t\tts_params->valid_devs[0], qp_id, NULL),\n+\t\t\t\"Expected call to fail as callback is NULL\");\n+\n+\t/* Test with valid configuration */\n+\tTEST_ASSERT_SUCCESS(rte_cryptodev_remove_deq_callback(\n+\t\t\tts_params->valid_devs[0], qp_id, cb),\n+\t\t\t\"Failed test to remove callback on \"\n+\t\t\t\"qp %u on cryptodev %u\",\n+\t\t\tqp_id, ts_params->valid_devs[0]);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n static void\n generate_gmac_large_plaintext(uint8_t *data)\n {\n@@ -13047,7 +13287,6 @@ static struct unit_test_suite cryptodev_testsuite  = {\n \t\t\t\ttest_queue_pair_descriptor_setup),\n \t\tTEST_CASE_ST(ut_setup, ut_teardown,\n \t\t\t\ttest_device_configure_invalid_queue_pair_ids),\n-\n \t\tTEST_CASE_ST(ut_setup, ut_teardown,\n \t\t\t\ttest_multi_session),\n \t\tTEST_CASE_ST(ut_setup, ut_teardown,\n@@ -13056,7 +13295,6 @@ static struct unit_test_suite cryptodev_testsuite  = {\n \t\tTEST_CASE_ST(ut_setup, ut_teardown,\n \t\t\ttest_null_invalid_operation),\n \t\tTEST_CASE_ST(ut_setup, ut_teardown, test_null_burst_operation),\n-\n \t\tTEST_CASE_ST(ut_setup, ut_teardown, test_AES_chain_all),\n \t\tTEST_CASE_ST(ut_setup, ut_teardown, test_AES_cipheronly_all),\n \t\tTEST_CASE_ST(ut_setup, ut_teardown, test_3DES_chain_all),\n@@ -13670,6 +13908,8 @@ static struct unit_test_suite cryptodev_testsuite  = {\n \t\tTEST_CASE_ST(ut_setup_security, ut_teardown,\n \t\t\ttest_DOCSIS_PROTO_all),\n #endif\n+\t\tTEST_CASE_ST(ut_setup, ut_teardown, test_enq_callback_setup),\n+\t\tTEST_CASE_ST(ut_setup, ut_teardown, test_deq_callback_setup),\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\n",
    "prefixes": [
        "v7",
        "2/2"
    ]
}