Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85641/?format=api
{ "id": 85641, "url": "https://patches.dpdk.org/api/patches/85641/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201222063054.44429-2-feifei.wang2@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201222063054.44429-2-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201222063054.44429-2-feifei.wang2@arm.com", "date": "2020-12-22T06:30:53", "name": "[v1,1/2] app/test: remove unnecessary barriers for ring stress test", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "312ab2b0fcc9c31e894e34293353c18bffc695bc", "submitter": { "id": 1771, "url": "https://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201222063054.44429-2-feifei.wang2@arm.com/mbox/", "series": [ { "id": 14415, "url": "https://patches.dpdk.org/api/series/14415/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14415", "date": "2020-12-22T06:30:52", "name": "remove smp barriers in app/test", "version": 1, "mbox": "https://patches.dpdk.org/series/14415/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85641/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85641/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 43DCDA052A;\n\tTue, 22 Dec 2020 07:31:27 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 69CFDCAAF;\n\tTue, 22 Dec 2020 07:31:10 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 77B1FCA97\n for <dev@dpdk.org>; Tue, 22 Dec 2020 07:31:07 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DEC871042;\n Mon, 21 Dec 2020 22:31:06 -0800 (PST)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.131])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7A45A3F66E;\n Mon, 21 Dec 2020 22:31:04 -0800 (PST)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>", "Cc": "dev@dpdk.org, nd@arm.com, Honnappa.Nagarahalli@arm.com,\n ruifeng.wang@arm.com, Feifei Wang <feifei.wang2@arm.com>", "Date": "Tue, 22 Dec 2020 14:30:53 +0800", "Message-Id": "<20201222063054.44429-2-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201222063054.44429-1-feifei.wang2@arm.com>", "References": "<20201222063054.44429-1-feifei.wang2@arm.com>", "Subject": "[dpdk-dev] [PATCH v1 1/2] app/test: remove unnecessary barriers for\n\tring stress test", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The variable \"wrk_cmd\" is a signal to control threads from running and\nstopping. When worker lcores load \"wrk_cmd == WRK_CMD_RUN\", they start\nrunning and when worker lcores load \"wrk_cmd == WRK_CMD_STOP\", they\nstop.\n\nFor the wmb in test_mt1, no storing operations must keep the order\nafter storing \"wrk_cmd\". Thus the wmb is unnecessary.\n\nFor the rmb in test_worker, the parameters have been prepared when\nworker lcores call \"test_worker\". It is unnessary to wait wrk_cmd to be\nloaded, then the parameters can be loaded, So the rmb can be removed.\n\nIn the meanwhile, fix a typo. The note above storing \"stop\" into\n\"wrk_cmd\" should be \"stop test\" rather than \"start test\".\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test/test_ring_stress_impl.h | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/app/test/test_ring_stress_impl.h b/app/test/test_ring_stress_impl.h\nindex f9ca63b90..384555ef9 100644\n--- a/app/test/test_ring_stress_impl.h\n+++ b/app/test/test_ring_stress_impl.h\n@@ -198,7 +198,6 @@ test_worker(void *arg, const char *fname, int32_t prcs)\n \tfill_ring_elm(&loc_elm, lc);\n \n \twhile (wrk_cmd != WRK_CMD_RUN) {\n-\t\trte_smp_rmb();\n \t\trte_pause();\n \t}\n \n@@ -357,13 +356,11 @@ test_mt1(int (*test)(void *))\n \n \t/* signal worker to start test */\n \twrk_cmd = WRK_CMD_RUN;\n-\trte_smp_wmb();\n \n \tusleep(run_time * US_PER_S);\n \n-\t/* signal worker to start test */\n+\t/* signal worker to stop test */\n \twrk_cmd = WRK_CMD_STOP;\n-\trte_smp_wmb();\n \n \t/* wait for workers and collect stats. */\n \tmc = rte_lcore_id();\n", "prefixes": [ "v1", "1/2" ] }