Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85639/?format=api
{ "id": 85639, "url": "https://patches.dpdk.org/api/patches/85639/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201222050728.41000-7-feifei.wang2@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201222050728.41000-7-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201222050728.41000-7-feifei.wang2@arm.com", "date": "2020-12-22T05:07:27", "name": "[RFC,v1,6/6] app/eventdev: remove unnecessary barriers for order test", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "24c09b80b3892b69b717c8be1f7593668d3a70be", "submitter": { "id": 1771, "url": "https://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201222050728.41000-7-feifei.wang2@arm.com/mbox/", "series": [ { "id": 14414, "url": "https://patches.dpdk.org/api/series/14414/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14414", "date": "2020-12-22T05:07:21", "name": "refactor smp barriers in app/eventdev", "version": 1, "mbox": "https://patches.dpdk.org/series/14414/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85639/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85639/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ED41EA09EF;\n\tTue, 22 Dec 2020 06:09:41 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8EBC7CCAD;\n\tTue, 22 Dec 2020 06:07:56 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 812DDCB79\n for <dev@dpdk.org>; Tue, 22 Dec 2020 06:07:54 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F3BEA30E;\n Mon, 21 Dec 2020 21:07:53 -0800 (PST)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.131])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 146653F718;\n Mon, 21 Dec 2020 21:07:51 -0800 (PST)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Jerin Jacob <jerinj@marvell.com>", "Cc": "dev@dpdk.org, nd@arm.com, Honnappa.Nagarahalli@arm.com,\n Feifei Wang <feifei.wang2@arm.com>", "Date": "Tue, 22 Dec 2020 13:07:27 +0800", "Message-Id": "<20201222050728.41000-7-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201222050728.41000-1-feifei.wang2@arm.com>", "References": "<20201222050728.41000-1-feifei.wang2@arm.com>", "Subject": "[dpdk-dev] [RFC PATCH v1 6/6] app/eventdev: remove unnecessary\n\tbarriers for order test", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For the wmb in order_process_stage_1 and order_process_stage_invalid in\nthe order test, they can be removed. This is because when the test results\nare wrong, the worker core writes 'true' to t->err. Then other worker\ncores, producer cores and the main core will load the 'error' index and\nstop testing. So, for the worker cores, no other storing operation needs\nto be guaranteed after this when errors happen.\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test-eventdev/test_order_common.h | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/app/test-eventdev/test_order_common.h b/app/test-eventdev/test_order_common.h\nindex 5ef840493..cd9d6009e 100644\n--- a/app/test-eventdev/test_order_common.h\n+++ b/app/test-eventdev/test_order_common.h\n@@ -104,7 +104,6 @@ order_process_stage_1(struct test_order *const t,\n \t\t\tflow, *order_mbuf_seqn(t, ev->mbuf),\n \t\t\texpected_flow_seq[flow]);\n \t\tt->err = true;\n-\t\trte_smp_wmb();\n \t}\n \t/*\n \t * Events from an atomic flow of an event queue can be scheduled only to\n@@ -123,7 +122,6 @@ order_process_stage_invalid(struct test_order *const t,\n {\n \tevt_err(\"invalid queue %d\", ev->queue_id);\n \tt->err = true;\n-\trte_smp_wmb();\n }\n \n #define ORDER_WORKER_INIT\\\n", "prefixes": [ "RFC", "v1", "6/6" ] }