Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85618/?format=api
{ "id": 85618, "url": "https://patches.dpdk.org/api/patches/85618/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1608586356-20046-1-git-send-email-longli@linuxonhyperv.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1608586356-20046-1-git-send-email-longli@linuxonhyperv.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1608586356-20046-1-git-send-email-longli@linuxonhyperv.com", "date": "2020-12-21T21:32:36", "name": "[v2,1/2] eal/hotplug: allow monitor to be setup by multiple places", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0d0bfb2b830da3abb7f1cbd7b382354773e4bfa7", "submitter": { "id": 1784, "url": "https://patches.dpdk.org/api/people/1784/?format=api", "name": "Long Li", "email": "longli@linuxonhyperv.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1608586356-20046-1-git-send-email-longli@linuxonhyperv.com/mbox/", "series": [ { "id": 14410, "url": "https://patches.dpdk.org/api/series/14410/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14410", "date": "2020-12-21T21:32:36", "name": "[v2,1/2] eal/hotplug: allow monitor to be setup by multiple places", "version": 2, "mbox": "https://patches.dpdk.org/series/14410/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85618/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85618/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AEBC7A09EF;\n\tMon, 21 Dec 2020 22:32:51 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 05D2CCAC4;\n\tMon, 21 Dec 2020 22:32:50 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by dpdk.org (Postfix) with ESMTP id 56429CA8D\n for <dev@dpdk.org>; Mon, 21 Dec 2020 22:32:47 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1004)\n id 879E320B83DE; Mon, 21 Dec 2020 13:32:46 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 879E320B83DE", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com;\n s=default; t=1608586366;\n bh=Msdcy0VxXiHuM2Kg/InBHyy+bjH2y7rW/GmKd4Edi84=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Iq53pT3tY65nvmvaGtCjbASKLNUcbtMXxUsnyMKCCx/D4Ji4+MR3vTuTEzZjIOu1L\n uLfZ3m8L+8Z8KR5gFprHI9p81EbD35vag97HIr+eSFJf2W3c32B5yWs7+e4+nBYnzD\n XFputesCWALqNRZBPM4NyigFeno7EGXIagkIBJTg=", "From": "Long Li <longli@linuxonhyperv.com>", "To": "Stephen Hemminger <sthemmin@microsoft.com>", "Cc": "dev@dpdk.org,\n\tLong Li <longli@microsoft.com>", "Date": "Mon, 21 Dec 2020 13:32:36 -0800", "Message-Id": "<1608586356-20046-1-git-send-email-longli@linuxonhyperv.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1606809383-26660-1-git-send-email-longli@linuxonhyperv.com>", "References": "<1606809383-26660-1-git-send-email-longli@linuxonhyperv.com>", "Subject": "[dpdk-dev] [PATCH v2 1/2] eal/hotplug: allow monitor to be setup by\n\tmultiple places", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Long Li <longli@microsoft.com>\n\nIn some cases, a device or infrastructure may want to enable hotplug\nbut application may also try and start hotplug as well. Therefore\nchange the monitor_started from a boolean into a reference count.\n\nSigned-off-by: Long Li <longli@microsoft.com>\n---\n lib/librte_eal/linux/eal_dev.c | 56 ++++++++++++++++++++++++----------\n 1 file changed, 40 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_dev.c\nindex 5c0e752b2d..3b905e18f5 100644\n--- a/lib/librte_eal/linux/eal_dev.c\n+++ b/lib/librte_eal/linux/eal_dev.c\n@@ -23,8 +23,12 @@\n \n #include \"eal_private.h\"\n \n-static struct rte_intr_handle intr_handle = {.fd = -1 };\n-static bool monitor_started;\n+static struct rte_intr_handle intr_handle = {\n+\t.type = RTE_INTR_HANDLE_DEV_EVENT,\n+\t.fd = -1,\n+};\n+static rte_rwlock_t monitor_lock = RTE_RWLOCK_INITIALIZER;\n+static uint32_t monitor_refcount;\n static bool hotplug_handle;\n \n #define EAL_UEV_MSG_LEN 4096\n@@ -298,50 +302,70 @@ dev_uev_handler(__rte_unused void *param)\n int\n rte_dev_event_monitor_start(void)\n {\n-\tint ret;\n+\tint ret = 0;\n \n-\tif (monitor_started)\n-\t\treturn 0;\n+\trte_rwlock_write_lock(&monitor_lock);\n+\n+\tif (monitor_refcount) {\n+\t\tmonitor_refcount++;\n+\t\tgoto exit;\n+\t}\n \n \tret = dev_uev_socket_fd_create();\n \tif (ret) {\n \t\tRTE_LOG(ERR, EAL, \"error create device event fd.\\n\");\n-\t\treturn -1;\n+\t\tgoto exit;\n \t}\n \n-\tintr_handle.type = RTE_INTR_HANDLE_DEV_EVENT;\n \tret = rte_intr_callback_register(&intr_handle, dev_uev_handler, NULL);\n \n \tif (ret) {\n \t\tRTE_LOG(ERR, EAL, \"fail to register uevent callback.\\n\");\n-\t\treturn -1;\n+\t\tclose(intr_handle.fd);\n+\t\tintr_handle.fd = -1;\n+\t\tgoto exit;\n \t}\n \n-\tmonitor_started = true;\n+\tmonitor_refcount++;\n \n-\treturn 0;\n+exit:\n+\trte_rwlock_write_unlock(&monitor_lock);\n+\treturn ret;\n }\n \n int\n rte_dev_event_monitor_stop(void)\n {\n-\tint ret;\n+\tint ret = 0;\n \n-\tif (!monitor_started)\n-\t\treturn 0;\n+\trte_rwlock_write_lock(&monitor_lock);\n+\n+\tif (!monitor_refcount) {\n+\t\tRTE_LOG(ERR, EAL, \"device event monitor already stopped\\n\");\n+\t\tgoto exit;\n+\t}\n+\n+\tif (monitor_refcount > 1) {\n+\t\tmonitor_refcount--;\n+\t\tgoto exit;\n+\t}\n \n \tret = rte_intr_callback_unregister(&intr_handle, dev_uev_handler,\n \t\t\t\t\t (void *)-1);\n \tif (ret < 0) {\n \t\tRTE_LOG(ERR, EAL, \"fail to unregister uevent callback.\\n\");\n-\t\treturn ret;\n+\t\tgoto exit;\n \t}\n \n \tclose(intr_handle.fd);\n \tintr_handle.fd = -1;\n-\tmonitor_started = false;\n \n-\treturn 0;\n+\tmonitor_refcount--;\n+\n+exit:\n+\trte_rwlock_write_unlock(&monitor_lock);\n+\n+\treturn ret;\n }\n \n int\n", "prefixes": [ "v2", "1/2" ] }