Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 85608,
    "url": "https://patches.dpdk.org/api/patches/85608/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201221155033.6771-4-joyce.kong@arm.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201221155033.6771-4-joyce.kong@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201221155033.6771-4-joyce.kong@arm.com",
    "date": "2020-12-21T15:50:28",
    "name": "[v1,3/8] vhost: remove unnecessary smp barrier for desc flags",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ab1d724c1a4eab14dfb55e4b99b8bae1d597ccdf",
    "submitter": {
        "id": 970,
        "url": "https://patches.dpdk.org/api/people/970/?format=api",
        "name": "Joyce Kong",
        "email": "joyce.kong@arm.com"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201221155033.6771-4-joyce.kong@arm.com/mbox/",
    "series": [
        {
            "id": 14408,
            "url": "https://patches.dpdk.org/api/series/14408/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14408",
            "date": "2020-12-21T15:50:25",
            "name": "replace smp barriers in vhost with C11 atomic",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/14408/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/85608/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/85608/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4C5CBA09EF;\n\tMon, 21 Dec 2020 16:52:08 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 42434CB93;\n\tMon, 21 Dec 2020 16:51:17 +0100 (CET)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 36818CB79\n for <dev@dpdk.org>; Mon, 21 Dec 2020 16:51:15 +0100 (CET)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 97E2712FC;\n Mon, 21 Dec 2020 07:51:14 -0800 (PST)",
            "from net-arm-thunderx2-03.shanghai.arm.com\n (net-arm-thunderx2-03.shanghai.arm.com [10.169.208.206])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6A47C3F6CF;\n Mon, 21 Dec 2020 07:51:12 -0800 (PST)"
        ],
        "From": "Joyce Kong <joyce.kong@arm.com>",
        "To": "maxime.coquelin@redhat.com, chenbo.xia@intel.com,\n honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com",
        "Cc": "dev@dpdk.org,\n\tnd@arm.com",
        "Date": "Mon, 21 Dec 2020 23:50:28 +0800",
        "Message-Id": "<20201221155033.6771-4-joyce.kong@arm.com>",
        "X-Mailer": "git-send-email 2.29.2",
        "In-Reply-To": "<20201221155033.6771-1-joyce.kong@arm.com>",
        "References": "<20201221155033.6771-1-joyce.kong@arm.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v1 3/8] vhost: remove unnecessary smp barrier for\n\tdesc flags",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "As function desc_is_avail performs a load-acquire barrier to\nenforce the ordering between desc flags and desc content, it is\nunnecessary to add a rte_smp_rmb barrier around the trace which\nfollows desc_is_avail.\n\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n lib/librte_vhost/virtio_net.c | 3 ---\n 1 file changed, 3 deletions(-)",
    "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 6c5128665..ae6723766 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -1281,8 +1281,6 @@ virtio_dev_rx_batch_packed(struct virtio_net *dev,\n \t\t\treturn -1;\n \t}\n \n-\trte_smp_rmb();\n-\n \tvhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE)\n \t\tlens[i] = descs[avail_idx + i].len;\n \n@@ -1343,7 +1341,6 @@ virtio_dev_rx_single_packed(struct virtio_net *dev,\n \tstruct buf_vector buf_vec[BUF_VECTOR_MAX];\n \tuint16_t nr_descs = 0;\n \n-\trte_smp_rmb();\n \tif (unlikely(vhost_enqueue_single_packed(dev, vq, pkt, buf_vec,\n \t\t\t\t\t\t &nr_descs) < 0)) {\n \t\tVHOST_LOG_DATA(DEBUG,\n",
    "prefixes": [
        "v1",
        "3/8"
    ]
}