Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85547/?format=api
{ "id": 85547, "url": "https://patches.dpdk.org/api/patches/85547/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201220211405.313012-24-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201220211405.313012-24-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201220211405.313012-24-maxime.coquelin@redhat.com", "date": "2020-12-20T21:13:48", "name": "[23/40] net/virtio: make Vhost-user req sender consistent", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d075a1ec06df1fdc2a6861c80b849e6b11707061", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201220211405.313012-24-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 14390, "url": "https://patches.dpdk.org/api/series/14390/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14390", "date": "2020-12-20T21:13:25", "name": "net/virtio: Virtio PMD rework", "version": 1, "mbox": "https://patches.dpdk.org/series/14390/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85547/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85547/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D023AA09FD;\n\tSun, 20 Dec 2020 22:21:51 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 18D53CDCE;\n\tSun, 20 Dec 2020 22:15:53 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [63.128.21.124])\n by dpdk.org (Postfix) with ESMTP id BBE4ACD74\n for <dev@dpdk.org>; Sun, 20 Dec 2020 22:15:49 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-156-UugmVLx0P3qesWp6DgHZOw-1; Sun, 20 Dec 2020 16:15:46 -0500", "from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com\n [10.5.11.12])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6049219251A1;\n Sun, 20 Dec 2020 21:15:45 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.36.110.43])\n by smtp.corp.redhat.com (Postfix) with ESMTP id A0BFC60C43;\n Sun, 20 Dec 2020 21:15:43 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1608498948;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=wapIGAT/L/lpNUj3xf8stnln27rfX8v3wED6EW6M6kU=;\n b=eyFDY8G0Q3n40odOqpif5hT4ojNeAuuEv2yH5K+JbrmwkKIbHCC+KBSOMSV45+towzPPSY\n zDZd/64oqllPmsGyl8J1tw3lO03Dv3sdZRrAZXq4k7lXDtvSRKCXhouzQ669OOd1gshxYn\n uKqShMNEJgLzJvlHgMBlqr8sRtSLNI0=", "X-MC-Unique": "UugmVLx0P3qesWp6DgHZOw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, olivier.matz@6wind.com,\n amorenoz@redhat.com, david.marchand@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Sun, 20 Dec 2020 22:13:48 +0100", "Message-Id": "<20201220211405.313012-24-maxime.coquelin@redhat.com>", "In-Reply-To": "<20201220211405.313012-1-maxime.coquelin@redhat.com>", "References": "<20201220211405.313012-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 23/40] net/virtio: make Vhost-user req sender\n\tconsistent", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch makes vhost_user_write() consistent with\nvhost_user_read(), by passing a pointer on the Vhost-user\nmessage instead of a buffer pointer and its length, which\nis now calculated in the function.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_user/vhost_user.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c\nindex b93e65c60b..e9053eea95 100644\n--- a/drivers/net/virtio/virtio_user/vhost_user.c\n+++ b/drivers/net/virtio/virtio_user/vhost_user.c\n@@ -51,7 +51,7 @@ struct vhost_user_msg {\n \t(sizeof(struct vhost_user_msg) - VHOST_USER_HDR_SIZE)\n \n static int\n-vhost_user_write(int fd, void *buf, int len, int *fds, int fd_num)\n+vhost_user_write(int fd, struct vhost_user_msg *msg, int *fds, int fd_num)\n {\n \tint r;\n \tstruct msghdr msgh;\n@@ -63,8 +63,8 @@ vhost_user_write(int fd, void *buf, int len, int *fds, int fd_num)\n \tmemset(&msgh, 0, sizeof(msgh));\n \tmemset(control, 0, sizeof(control));\n \n-\tiov.iov_base = (uint8_t *)buf;\n-\tiov.iov_len = len;\n+\tiov.iov_base = (uint8_t *)msg;\n+\tiov.iov_len = VHOST_USER_HDR_SIZE + msg->size;\n \n \tmsgh.msg_iov = &iov;\n \tmsgh.msg_iovlen = 1;\n@@ -259,7 +259,6 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \tint has_reply_ack = 0;\n \tint fds[VHOST_MEMORY_MAX_NREGIONS];\n \tint fd_num = 0;\n-\tint len;\n \tint vhostfd = dev->vhostfd;\n \n \tRTE_SET_USED(m);\n@@ -359,8 +358,7 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \t\treturn -1;\n \t}\n \n-\tlen = VHOST_USER_HDR_SIZE + msg.size;\n-\tif (vhost_user_write(vhostfd, &msg, len, fds, fd_num) < 0) {\n+\tif (vhost_user_write(vhostfd, &msg, fds, fd_num) < 0) {\n \t\tPMD_DRV_LOG(ERR, \"%s failed: %s\",\n \t\t\t vhost_msg_strings[req], strerror(errno));\n \t\treturn -1;\n", "prefixes": [ "23/40" ] }