Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 85515,
    "url": "https://patches.dpdk.org/api/patches/85515/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201220052430.99990-6-ajit.khaparde@broadcom.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201220052430.99990-6-ajit.khaparde@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201220052430.99990-6-ajit.khaparde@broadcom.com",
    "date": "2020-12-20T05:24:29",
    "name": "[5/6] net/bnxt: modify context memory allocation code",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "45c1719832b45415e71aebebed445ca3e26c69e3",
    "submitter": {
        "id": 2064,
        "url": "https://patches.dpdk.org/api/people/2064/?format=api",
        "name": "Ajit Khaparde",
        "email": "ajitkhaparde@gmail.com"
    },
    "delegate": {
        "id": 1766,
        "url": "https://patches.dpdk.org/api/users/1766/?format=api",
        "username": "ajitkhaparde",
        "first_name": "Ajit",
        "last_name": "Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201220052430.99990-6-ajit.khaparde@broadcom.com/mbox/",
    "series": [
        {
            "id": 14388,
            "url": "https://patches.dpdk.org/api/series/14388/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14388",
            "date": "2020-12-20T05:24:24",
            "name": "net/bnxt: add support for Stingray2",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/14388/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/85515/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/85515/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5AA90A052A;\n\tSun, 20 Dec 2020 06:26:14 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AE37BCBF0;\n\tSun, 20 Dec 2020 06:24:48 +0100 (CET)",
            "from mail-pj1-f53.google.com (mail-pj1-f53.google.com\n [209.85.216.53]) by dpdk.org (Postfix) with ESMTP id 88D05CB79\n for <dev@dpdk.org>; Sun, 20 Dec 2020 06:24:43 +0100 (CET)",
            "by mail-pj1-f53.google.com with SMTP id l23so4537782pjg.1\n for <dev@dpdk.org>; Sat, 19 Dec 2020 21:24:43 -0800 (PST)",
            "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id b11sm12936544pfr.38.2020.12.19.21.24.40\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Sat, 19 Dec 2020 21:24:40 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=xWjcRdVqhLDSz9dQw435xyAHbYKVSAH+Clw7QRM9bDc=;\n b=pe5Zy7RzQfDUSwpN+15uPycPlDI8FxZdBoUTvzkEzcSsKosFozLzRbZoBr4j/uzolH\n TgLJ1iUMGj2V+xSP5pQqf+4+hVUxeZlaaFawmzjExbm+OvdJCjP+UpIu5KxjtSE1KhSy\n TibH6KRlcKccQP08W5itG+yz9VJKbtXOG1WKXvXqkSO7TIvNHvYeYBADUiNbarysDusl\n uwP1aA1sTFsCz85hHqpdKATR7xLaCcm05Dbv1f7P6J6f++rCmm92EmodiuXhVhsXyWDQ\n 0N8BEHg+K+cjMJN454xOfca5Z88MrbAMlsQsp9BEiZCfqsrzMCrfQ4Lk+gQ825g8XU7G\n WQPg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=xWjcRdVqhLDSz9dQw435xyAHbYKVSAH+Clw7QRM9bDc=;\n b=LLVFpjinKAmyhaRJB044DSx/b4lUONvSB0uJoNWYnj94hiTF8c7vOOixFJXTcIVh4i\n SuEy4XzGY6QYtGBWPksVxWNhZwVmEWMz4Oj4SDASLDtuuB9QRcxjod0UuLBFpjOzYx30\n BAgjxIQplzMW6Z1AJwN+WOIW0mDlQ3jNnLxCZPzvPc/xGqVoH7my3wwxE04veT5LGsro\n r0rgSBlRxtU9NbZIHTo79F4Ui1ypULZHid9BkA3mbTQ9JUGKcIY1kYgrtq+IlYlwgEzT\n abzovFphm7zxeuyBgD8As/gtN9PRAtbJ4ThHKJ/P2ZVm4r3mcOtMIK8tGBS9Sn5pDsgb\n FOxQ==",
        "X-Gm-Message-State": "AOAM532aegLaSzd1UmFDGyRQ/H0ipenfCQfbfSufL8VC39X/S0gPB1SH\n wqq6eY4FEbXSCDqe+CQM9DJZYw2+FXKSfw==",
        "X-Google-Smtp-Source": "\n ABdhPJxxeIoB67ZCwtnLWouUGQe4cw1qwXiGiz11pZ0PXkPvg1grfv7vaudHgCuzILODxClcDcIAYA==",
        "X-Received": "by 2002:a17:90a:ba88:: with SMTP id\n t8mr11714983pjr.229.1608441881317;\n Sat, 19 Dec 2020 21:24:41 -0800 (PST)",
        "From": "Ajit Khaparde <ajitkhaparde@gmail.com>",
        "X-Google-Original-From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "Kalesh AP <kalesh-anakkur.purayil@broadcom.com>",
        "Date": "Sat, 19 Dec 2020 21:24:29 -0800",
        "Message-Id": "<20201220052430.99990-6-ajit.khaparde@broadcom.com>",
        "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)",
        "In-Reply-To": "<20201220052430.99990-1-ajit.khaparde@broadcom.com>",
        "References": "<20201220052430.99990-1-ajit.khaparde@broadcom.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 5/6] net/bnxt: modify context memory allocation\n\tcode",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nNewer devices like SR2 may have chip backing store and do not require\nhost backed memory allocation.\n\nIn these cases, HWRM_FUNC_BACKING_STORE_QCAPS will return a zero entry\nsize to indicate contexts for which the host should not allocate backing\nstore.\n\nSelectively allocate context memory based on device capabilities and\nonly enable backing store for the appropriate contexts.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 60 ++++++++++++++++++++--------------\n drivers/net/bnxt/bnxt_hwrm.c   |  3 ++\n 2 files changed, 39 insertions(+), 24 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 8ca4fb151..e11751cc1 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -4212,39 +4212,49 @@ int bnxt_alloc_ctx_mem(struct bnxt *bp)\n \n \tctx_pg = &ctx->qp_mem;\n \tctx_pg->entries = ctx->qp_min_qp1_entries + ctx->qp_max_l2_entries;\n-\tmem_size = ctx->qp_entry_size * ctx_pg->entries;\n-\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"qp_mem\", 0);\n-\tif (rc)\n-\t\treturn rc;\n+\tif (ctx->qp_entry_size) {\n+\t\tmem_size = ctx->qp_entry_size * ctx_pg->entries;\n+\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"qp_mem\", 0);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t}\n \n \tctx_pg = &ctx->srq_mem;\n \tctx_pg->entries = ctx->srq_max_l2_entries;\n-\tmem_size = ctx->srq_entry_size * ctx_pg->entries;\n-\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"srq_mem\", 0);\n-\tif (rc)\n-\t\treturn rc;\n+\tif (ctx->srq_entry_size) {\n+\t\tmem_size = ctx->srq_entry_size * ctx_pg->entries;\n+\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"srq_mem\", 0);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t}\n \n \tctx_pg = &ctx->cq_mem;\n \tctx_pg->entries = ctx->cq_max_l2_entries;\n-\tmem_size = ctx->cq_entry_size * ctx_pg->entries;\n-\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"cq_mem\", 0);\n-\tif (rc)\n-\t\treturn rc;\n+\tif (ctx->cq_entry_size) {\n+\t\tmem_size = ctx->cq_entry_size * ctx_pg->entries;\n+\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"cq_mem\", 0);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t}\n \n \tctx_pg = &ctx->vnic_mem;\n \tctx_pg->entries = ctx->vnic_max_vnic_entries +\n \t\tctx->vnic_max_ring_table_entries;\n-\tmem_size = ctx->vnic_entry_size * ctx_pg->entries;\n-\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"vnic_mem\", 0);\n-\tif (rc)\n-\t\treturn rc;\n+\tif (ctx->vnic_entry_size) {\n+\t\tmem_size = ctx->vnic_entry_size * ctx_pg->entries;\n+\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"vnic_mem\", 0);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t}\n \n \tctx_pg = &ctx->stat_mem;\n \tctx_pg->entries = ctx->stat_max_entries;\n-\tmem_size = ctx->stat_entry_size * ctx_pg->entries;\n-\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"stat_mem\", 0);\n-\tif (rc)\n-\t\treturn rc;\n+\tif (ctx->stat_entry_size) {\n+\t\tmem_size = ctx->stat_entry_size * ctx_pg->entries;\n+\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"stat_mem\", 0);\n+\t\tif (rc)\n+\t\t\treturn rc;\n+\t}\n \n \tmin = ctx->tqm_min_entries_per_ring;\n \n@@ -4260,10 +4270,12 @@ int bnxt_alloc_ctx_mem(struct bnxt *bp)\n \tfor (i = 0, ena = 0; i < ctx->tqm_fp_rings_count + 1; i++) {\n \t\tctx_pg = ctx->tqm_mem[i];\n \t\tctx_pg->entries = i ? entries : entries_sp;\n-\t\tmem_size = ctx->tqm_entry_size * ctx_pg->entries;\n-\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"tqm_mem\", i);\n-\t\tif (rc)\n-\t\t\treturn rc;\n+\t\tif (ctx->tqm_entry_size) {\n+\t\t\tmem_size = ctx->tqm_entry_size * ctx_pg->entries;\n+\t\t\trc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, \"tqm_mem\", i);\n+\t\t\tif (rc)\n+\t\t\t\treturn rc;\n+\t\t}\n \t\tena |= HWRM_FUNC_BACKING_STORE_CFG_INPUT_ENABLES_TQM_SP << i;\n \t}\n \ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 56e2e33a9..6d54b1656 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -64,6 +64,9 @@ static void bnxt_hwrm_set_pg_attr(struct bnxt_ring_mem_info *rmem,\n \t\t\t\t  uint8_t *pg_attr,\n \t\t\t\t  uint64_t *pg_dir)\n {\n+\tif (rmem->nr_pages == 0)\n+\t\treturn;\n+\n \tif (rmem->nr_pages > 1) {\n \t\t*pg_attr = 1;\n \t\t*pg_dir = rte_cpu_to_le_64(rmem->pg_tbl_map);\n",
    "prefixes": [
        "5/6"
    ]
}