Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85474/?format=api
{ "id": 85474, "url": "https://patches.dpdk.org/api/patches/85474/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1608304614-13908-10-git-send-email-xuemingl@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1608304614-13908-10-git-send-email-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1608304614-13908-10-git-send-email-xuemingl@nvidia.com", "date": "2020-12-18T15:16:54", "name": "[RFC,9/9] net/mlx5: support new device global syntax", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "17c7f1ed39e05bdd281883293fb1502b4f92c6ae", "submitter": { "id": 1904, "url": "https://patches.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1608304614-13908-10-git-send-email-xuemingl@nvidia.com/mbox/", "series": [ { "id": 14378, "url": "https://patches.dpdk.org/api/series/14378/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14378", "date": "2020-12-18T15:16:52", "name": "support global syntax", "version": 1, "mbox": "https://patches.dpdk.org/series/14378/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85474/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85474/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4ED2CA09FD;\n\tFri, 18 Dec 2020 16:18:34 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E2E6CCB46;\n\tFri, 18 Dec 2020 16:17:18 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 3D735CAF7\n for <dev@dpdk.org>; Fri, 18 Dec 2020 16:17:10 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n xuemingl@nvidia.com) with SMTP; 18 Dec 2020 17:17:05 +0200", "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0BIFH4qh010856;\n Fri, 18 Dec 2020 17:17:05 +0200" ], "From": "Xueming Li <xuemingl@nvidia.com>", "To": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Olivier Matz <olivier.matz@6wind.com>, Matan Azrad <matan@nvidia.com>", "Cc": "dev@dpdk.org, xuemingl@nvidia.com, Asaf Penso <asafp@nvidia.com>", "Date": "Fri, 18 Dec 2020 15:16:54 +0000", "Message-Id": "<1608304614-13908-10-git-send-email-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1608304614-13908-1-git-send-email-xuemingl@nvidia.com>", "References": "<1608304614-13908-1-git-send-email-xuemingl@nvidia.com>", "Subject": "[dpdk-dev] [RFC 9/9] net/mlx5: support new device global syntax", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch support new device global syntax like:\n\tbus=pci,addr=BB:DD.F/class=eth/driver=mlx5,devargs,..\n\nIgnore \"driver\" key as part of new global device syntax in devargs.\n\nThe representor devarg is supposed to come from either class section or\ndriver section.\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\n---\n drivers/net/mlx5/linux/mlx5_os.c | 18 ++++++++++++++++--\n drivers/net/mlx5/mlx5.c | 6 +++++-\n 2 files changed, 21 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 917d6be7b8..fae339584b 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -694,13 +694,27 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \tif (switch_info->representor && dpdk_dev->devargs) {\n \t\tstruct rte_eth_devargs eth_da;\n \n-\t\terr = rte_eth_devargs_parse(dpdk_dev->devargs->args, ð_da);\n+\t\t/* Representer should come from class argument or driver */\n+\t\tif (dpdk_dev->devargs->cls_str)\n+\t\t\terr = rte_eth_devargs_parse(dpdk_dev->devargs->cls_str,\n+\t\t\t\t\t\t ð_da);\n \t\tif (err) {\n \t\t\trte_errno = -err;\n \t\t\tDRV_LOG(ERR, \"failed to process device arguments: %s\",\n-\t\t\t\tstrerror(rte_errno));\n+\t\t\t\tdpdk_dev->devargs->cls_str);\n \t\t\treturn NULL;\n \t\t}\n+\t\tif (eth_da.type == RTE_ETH_REPRESENTOR_NONE) {\n+\t\t\t/* Support legacy device argument */\n+\t\t\terr = rte_eth_devargs_parse(dpdk_dev->devargs->args,\n+\t\t\t\t\t\t ð_da);\n+\t\t\tif (err) {\n+\t\t\t\trte_errno = -err;\n+\t\t\t\tDRV_LOG(ERR, \"failed to process device arguments: %s\",\n+\t\t\t\t\tdpdk_dev->devargs->args);\n+\t\t\t\treturn NULL;\n+\t\t\t}\n+\t\t}\n \t\tfor (i = 0; i < eth_da.nb_representor_ports; ++i)\n \t\t\tif (eth_da.representor_ports[i] ==\n \t\t\t (uint16_t)switch_info->port_name)\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex 52a8a252d4..3dc15e21ca 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -39,6 +39,9 @@\n #include \"mlx5_flow.h\"\n #include \"rte_pmd_mlx5.h\"\n \n+/* Driver type key for new device global syntax. */\n+#define MLX5_DRIVER_KEY \"driver\"\n+\n /* Device parameter to enable RX completion queue compression. */\n #define MLX5_RXQ_CQE_COMP_EN \"rxq_cqe_comp_en\"\n \n@@ -1449,7 +1452,7 @@ mlx5_args_check(const char *key, const char *val, void *opaque)\n \tsigned long tmp;\n \n \t/* No-op, port representors are processed in mlx5_dev_spawn(). */\n-\tif (!strcmp(MLX5_REPRESENTOR, key))\n+\tif (!strcmp(MLX5_DRIVER_KEY, key) || !strcmp(MLX5_REPRESENTOR, key))\n \t\treturn 0;\n \terrno = 0;\n \ttmp = strtol(val, NULL, 0);\n@@ -1603,6 +1606,7 @@ int\n mlx5_args(struct mlx5_dev_config *config, struct rte_devargs *devargs)\n {\n \tconst char **params = (const char *[]){\n+\t\tMLX5_DRIVER_KEY,\n \t\tMLX5_RXQ_CQE_COMP_EN,\n \t\tMLX5_RXQ_CQE_PAD_EN,\n \t\tMLX5_RXQ_PKT_PAD_EN,\n", "prefixes": [ "RFC", "9/9" ] }