Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85466/?format=api
{ "id": 85466, "url": "https://patches.dpdk.org/api/patches/85466/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1608303356-13089-8-git-send-email-xuemingl@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1608303356-13089-8-git-send-email-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1608303356-13089-8-git-send-email-xuemingl@nvidia.com", "date": "2020-12-18T14:55:56", "name": "[RFC,7/7] net/mlx5: support representor of sub function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d742f0309c81edf13741c4a2fce31e3dddd24f99", "submitter": { "id": 1904, "url": "https://patches.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1608303356-13089-8-git-send-email-xuemingl@nvidia.com/mbox/", "series": [ { "id": 14376, "url": "https://patches.dpdk.org/api/series/14376/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14376", "date": "2020-12-18T14:55:49", "name": "support SubFunction representor", "version": 1, "mbox": "https://patches.dpdk.org/series/14376/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85466/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/85466/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2E0E7A09FD;\n\tFri, 18 Dec 2020 15:57:47 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 078BACB6B;\n\tFri, 18 Dec 2020 15:56:21 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 92319CAF7\n for <dev@dpdk.org>; Fri, 18 Dec 2020 15:56:13 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n xuemingl@nvidia.com) with SMTP; 18 Dec 2020 16:56:07 +0200", "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0BIEu65X013340;\n Fri, 18 Dec 2020 16:56:07 +0200" ], "From": "Xueming Li <xuemingl@nvidia.com>", "To": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Olivier Matz <olivier.matz@6wind.com>, Matan Azrad <matan@nvidia.com>", "Cc": "dev@dpdk.org, xuemingl@nvidia.com, Asaf Penso <asafp@nvidia.com>", "Date": "Fri, 18 Dec 2020 14:55:56 +0000", "Message-Id": "<1608303356-13089-8-git-send-email-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1608303356-13089-1-git-send-email-xuemingl@nvidia.com>", "References": "<1608303356-13089-1-git-send-email-xuemingl@nvidia.com>", "Subject": "[dpdk-dev] [RFC 7/7] net/mlx5: support representor of sub function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch supports of SF representor. Similar to VF representor, switch\nport name of SF representor in sysfs phys_port_name is \"pf<x>sf<y>\".\n\nDevice representor argumnt is \"representors=sf[list]\", list member could\nbe mix of instance and range. Example:\n representors=sf[0,2,4,8-12,-1]\n\nTo probe VF representor and SF representor, need to separate into 2\ndevices:\n -a <BDF>,representor=vf[list] -a <BDF>,representor=sf[list]\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\n---\n drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 +\n drivers/net/mlx5/linux/mlx5_os.c | 69 ++++++++++++++++++++++---\n drivers/net/mlx5/mlx5_ethdev.c | 2 +\n 3 files changed, 67 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c\nindex d4eed11fbc..11c30d587c 100644\n--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c\n@@ -1010,6 +1010,8 @@ mlx5_sysfs_check_switch_info(bool device_dir,\n \tcase MLX5_PHYS_PORT_NAME_TYPE_PFHPF:\n \t\t/* Fallthrough */\n \tcase MLX5_PHYS_PORT_NAME_TYPE_PFVF:\n+\t\t/* Fallthrough */\n+\tcase MLX5_PHYS_PORT_NAME_TYPE_PFSF:\n \t\t/* New representors naming schema. */\n \t\tswitch_info->representor = 1;\n \t\tbreak;\ndiff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 917d6be7b8..aeac1abb2c 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -692,20 +692,70 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \n \t/* Determine if this port representor is supposed to be spawned. */\n \tif (switch_info->representor && dpdk_dev->devargs) {\n-\t\tstruct rte_eth_devargs eth_da;\n+\t\tstruct rte_eth_devargs eth_da = { .nb_ports = 0 };\n \n \t\terr = rte_eth_devargs_parse(dpdk_dev->devargs->args, ð_da);\n \t\tif (err) {\n \t\t\trte_errno = -err;\n \t\t\tDRV_LOG(ERR, \"failed to process device arguments: %s\",\n-\t\t\t\tstrerror(rte_errno));\n+\t\t\t\tdpdk_dev->devargs->args);\n \t\t\treturn NULL;\n \t\t}\n+\t\tswitch (eth_da.type) {\n+\t\tcase RTE_ETH_REPRESENTOR_PF:\n+\t\t\tif (switch_info->name_type !=\n+\t\t\t\t\tMLX5_PHYS_PORT_NAME_TYPE_PFHPF) {\n+\t\t\t\trte_errno = EBUSY;\n+\t\t\t\treturn NULL;\n+\t\t\t}\n+\t\t\tbreak;\n+\t\tcase RTE_ETH_REPRESENTOR_SF:\n+\t\t\tif (switch_info->name_type !=\n+\t\t\t\t\tMLX5_PHYS_PORT_NAME_TYPE_PFSF) {\n+\t\t\t\trte_errno = EBUSY;\n+\t\t\t\treturn NULL;\n+\t\t\t}\n+\t\t\tbreak;\n+\t\tcase RTE_ETH_REPRESENTOR_VF:\n+\t\t\t/* Allows HPF representor index -1 as exception. */\n+\t\t\tif (!(spawn->info.port_name == -1 &&\n+\t\t\t switch_info->name_type ==\n+\t\t\t\t\tMLX5_PHYS_PORT_NAME_TYPE_PFHPF) &&\n+\t\t\t switch_info->name_type !=\n+\t\t\t\t\tMLX5_PHYS_PORT_NAME_TYPE_PFVF) {\n+\t\t\t\trte_errno = EBUSY;\n+\t\t\t\treturn NULL;\n+\t\t\t}\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\trte_errno = EBUSY;\n+\t\t\treturn NULL;\n+\t\t}\n+\t\t/* Check controller ID: */\n+\t\tfor (i = 0; i < eth_da.nb_mh_controllers; ++i)\n+\t\t\tif (eth_da.mh_controllers[i] ==\n+\t\t\t (uint16_t)switch_info->ctrl_num)\n+\t\t\t\tbreak;\n+\t\tif (eth_da.nb_mh_controllers && i == eth_da.nb_mh_controllers) {\n+\t\t\trte_errno = EBUSY;\n+\t\t\treturn NULL;\n+\t\t}\n+\t\t/* Check PF ID: */\n+\t\tfor (i = 0; i < eth_da.nb_ports; ++i)\n+\t\t\tif (eth_da.ports[i] ==\n+\t\t\t (uint16_t)switch_info->pf_num)\n+\t\t\t\tbreak;\n+\t\tif (eth_da.nb_ports && i == eth_da.nb_ports) {\n+\t\t\trte_errno = EBUSY;\n+\t\t\treturn NULL;\n+\t\t}\n+\t\t/* Check SF/VF ID: */\n \t\tfor (i = 0; i < eth_da.nb_representor_ports; ++i)\n \t\t\tif (eth_da.representor_ports[i] ==\n \t\t\t (uint16_t)switch_info->port_name)\n \t\t\t\tbreak;\n-\t\tif (i == eth_da.nb_representor_ports) {\n+\t\tif (eth_da.type != RTE_ETH_REPRESENTOR_PF &&\n+\t\t i == eth_da.nb_representor_ports) {\n \t\t\trte_errno = EBUSY;\n \t\t\treturn NULL;\n \t\t}\n@@ -716,8 +766,11 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \t\tif (!switch_info->representor)\n \t\t\tstrlcpy(name, dpdk_dev->name, sizeof(name));\n \t\telse\n-\t\t\tsnprintf(name, sizeof(name), \"%s_representor_%u\",\n-\t\t\t\t dpdk_dev->name, switch_info->port_name);\n+\t\t\tsnprintf(name, sizeof(name), \"%s_representor_%s%u\",\n+\t\t\t\t dpdk_dev->name,\n+\t\t\t\t switch_info->name_type ==\n+\t\t\t\t MLX5_PHYS_PORT_NAME_TYPE_PFSF ? \"sf\" : \"vf\",\n+\t\t\t\t switch_info->port_name);\n \t} else {\n \t\t/* Bonding device. */\n \t\tif (!switch_info->representor)\n@@ -725,9 +778,11 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \t\t\t\t dpdk_dev->name,\n \t\t\t\t mlx5_os_get_dev_device_name(spawn->phys_dev));\n \t\telse\n-\t\t\tsnprintf(name, sizeof(name), \"%s_%s_representor_%u\",\n+\t\t\tsnprintf(name, sizeof(name), \"%s_%s_representor_%s%u\",\n \t\t\t\t dpdk_dev->name,\n \t\t\t\t mlx5_os_get_dev_device_name(spawn->phys_dev),\n+\t\t\t\t switch_info->name_type ==\n+\t\t\t\t MLX5_PHYS_PORT_NAME_TYPE_PFSF ? \"sf\" : \"vf\",\n \t\t\t\t switch_info->port_name);\n \t}\n \t/* check if the device is already spawned */\n@@ -1966,6 +2021,8 @@ mlx5_os_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\t\t\tcase MLX5_PHYS_PORT_NAME_TYPE_PFHPF:\n \t\t\t\t\t/* Fallthrough */\n \t\t\t\tcase MLX5_PHYS_PORT_NAME_TYPE_PFVF:\n+\t\t\t\t\t/* Fallthrough */\n+\t\t\t\tcase MLX5_PHYS_PORT_NAME_TYPE_PFSF:\n \t\t\t\t\tif (list[ns].info.pf_num == bd)\n \t\t\t\t\t\tns++;\n \t\t\t\t\tbreak;\ndiff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex 45ee7e4488..ad6aacc329 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -374,6 +374,8 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)\n \t\t\tbreak;\n \t\t}\n \t}\n+\tif (priv->master)\n+\t\tinfo->dev_capa = RTE_ETH_DEV_CAPA_REPRESENTOR_SF;\n \treturn 0;\n }\n \n", "prefixes": [ "RFC", "7/7" ] }