Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85460/?format=api
{ "id": 85460, "url": "https://patches.dpdk.org/api/patches/85460/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201218132352.15834-1-olivier.matz@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201218132352.15834-1-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201218132352.15834-1-olivier.matz@6wind.com", "date": "2020-12-18T13:23:52", "name": "[v2] net/virtio-user: fix advertising of protocol features", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6d8db8708b53abcc6ebc9e7422b659092ee6e91d", "submitter": { "id": 8, "url": "https://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201218132352.15834-1-olivier.matz@6wind.com/mbox/", "series": [ { "id": 14375, "url": "https://patches.dpdk.org/api/series/14375/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14375", "date": "2020-12-18T13:23:52", "name": "[v2] net/virtio-user: fix advertising of protocol features", "version": 2, "mbox": "https://patches.dpdk.org/series/14375/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85460/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85460/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 265ACA09FD;\n\tFri, 18 Dec 2020 14:24:02 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3B7D3CAD6;\n\tFri, 18 Dec 2020 14:23:59 +0100 (CET)", "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 0F8A0CAC0;\n Fri, 18 Dec 2020 14:23:57 +0100 (CET)", "from glumotte.dev.6wind.com. (unknown [10.16.0.195])\n by proxy.6wind.com (Postfix) with ESMTP id CBB9F4AC370;\n Fri, 18 Dec 2020 14:23:55 +0100 (CET)" ], "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>, stable@dpdk.org", "Date": "Fri, 18 Dec 2020 14:23:52 +0100", "Message-Id": "<20201218132352.15834-1-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201218125217.12963-1-olivier.matz@6wind.com>", "References": "<20201218125217.12963-1-olivier.matz@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] net/virtio-user: fix advertising of protocol\n\tfeatures", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When connected to a vhost-user backend, the flag\nVHOST_USER_F_PROTOCOL_FEATURES is not advertised, preventing to do\nmultiqueue (the VHOST_USER_PROTOCOL_F_MQ protocol feature is ignored by\nsome backends if the VHOST_USER_F_PROTOCOL_FEATURES feature is not set).\n\nWhen setting vhost-user features, advertise this flag if it was\nadvertised by our peer.\n\nFixes: 8e7561054ac7 (\"net/virtio: support vhost-user protocol features\")\nCc: stable@dpdk.org\n\nSuggested-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n\nv2\n* fix obvious fallthrough case, sorry for the noise\n\n drivers/net/virtio/virtio_user/vhost_user.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c\nindex b93e65c60b..350eed4182 100644\n--- a/drivers/net/virtio/virtio_user/vhost_user.c\n+++ b/drivers/net/virtio/virtio_user/vhost_user.c\n@@ -297,13 +297,18 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \t\tif (has_reply_ack)\n \t\t\tmsg.flags |= VHOST_USER_NEED_REPLY_MASK;\n \t\t/* Fallthrough */\n-\tcase VHOST_USER_SET_FEATURES:\n \tcase VHOST_USER_SET_PROTOCOL_FEATURES:\n \tcase VHOST_USER_SET_LOG_BASE:\n \t\tmsg.payload.u64 = *((__u64 *)arg);\n \t\tmsg.size = sizeof(m.payload.u64);\n \t\tbreak;\n \n+\tcase VHOST_USER_SET_FEATURES:\n+\t\tmsg.payload.u64 = *((__u64 *)arg) | (dev->device_features &\n+\t\t\t(1ULL << VHOST_USER_F_PROTOCOL_FEATURES));\n+\t\tmsg.size = sizeof(m.payload.u64);\n+\t\tbreak;\n+\n \tcase VHOST_USER_SET_OWNER:\n \tcase VHOST_USER_RESET_OWNER:\n \t\tbreak;\n", "prefixes": [ "v2" ] }