Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 85426,
    "url": "https://patches.dpdk.org/api/patches/85426/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201218093702.3651867-18-jiawenwu@trustnetic.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201218093702.3651867-18-jiawenwu@trustnetic.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201218093702.3651867-18-jiawenwu@trustnetic.com",
    "date": "2020-12-18T09:36:46",
    "name": "[v3,17/33] net/txgbe: restore RSS filter",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ea84682146972c619532c0cc4ebb437558e49e11",
    "submitter": {
        "id": 1932,
        "url": "https://patches.dpdk.org/api/people/1932/?format=api",
        "name": "Jiawen Wu",
        "email": "jiawenwu@trustnetic.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201218093702.3651867-18-jiawenwu@trustnetic.com/mbox/",
    "series": [
        {
            "id": 14363,
            "url": "https://patches.dpdk.org/api/series/14363/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14363",
            "date": "2020-12-18T09:36:30",
            "name": "net: add txgbe PMD part 2",
            "version": 3,
            "mbox": "https://patches.dpdk.org/series/14363/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/85426/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/85426/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 13BEDA09F6;\n\tFri, 18 Dec 2020 10:40:51 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 60B8ECB96;\n\tFri, 18 Dec 2020 10:35:09 +0100 (CET)",
            "from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56])\n by dpdk.org (Postfix) with ESMTP id E1592CB19\n for <dev@dpdk.org>; Fri, 18 Dec 2020 10:34:59 +0100 (CET)",
            "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Fri, 18 Dec 2020 17:34:53 +0800 (CST)"
        ],
        "X-QQ-mid": "bizesmtp28t1608284094tz1yjr1j",
        "X-QQ-SSF": "01400000002000C0D000B00A0000000",
        "X-QQ-FEAT": "zRzn3KPPoLcdv90GdWk2y+grZVwfptzxcmNtTsFWbDLll0Xu2Wa9x93mARI7j\n /Sh9C73NHu/yHzyoisWIl7bj4ROveLCe/ogod0GV1CY7XHbJPtyc76m59QhsM9KaoS2a1FP\n U92nehy6oCZGXGJd0Gv6ih4fP03VY0w9ZZrSdwDgftnrpyIT+TwzIwVX5bk3254jxIZG6lm\n Oa7hXhHOrQ2evEEiHr4AIL7/+fCoNL6DqZ1PHSAcRLA43xNsr0LJwRXo1ReEAhxldi5Y10S\n TBeeLGaQbKMOrtZB144fPf9SlSlRKSIX/pybxHZkOf7PFSTt9+RaQ6OESzhV+d4rCvexkBq\n yxFefZudRxIsAXAIhdoVVfMH1axXQ==",
        "X-QQ-GoodBg": "2",
        "From": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "To": "dev@dpdk.org",
        "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "Date": "Fri, 18 Dec 2020 17:36:46 +0800",
        "Message-Id": "<20201218093702.3651867-18-jiawenwu@trustnetic.com>",
        "X-Mailer": "git-send-email 2.27.0",
        "In-Reply-To": "<20201218093702.3651867-1-jiawenwu@trustnetic.com>",
        "References": "<20201218093702.3651867-1-jiawenwu@trustnetic.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-QQ-SENDSIZE": "520",
        "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5",
        "X-QQ-Bgrelay": "1",
        "Subject": "[dpdk-dev] [PATCH v3 17/33] net/txgbe: restore RSS filter",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add support to restore RSS filter.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_ethdev.c | 12 ++++\n drivers/net/txgbe/txgbe_ethdev.h | 15 +++++\n drivers/net/txgbe/txgbe_rxtx.c   | 96 ++++++++++++++++++++++++++++++++\n 3 files changed, 123 insertions(+)",
    "diff": "diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex b2fbb6ef9..aa01c22ce 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -4910,6 +4910,17 @@ txgbe_l2_tn_filter_restore(struct rte_eth_dev *dev)\n \t}\n }\n \n+/* restore rss filter */\n+static inline void\n+txgbe_rss_filter_restore(struct rte_eth_dev *dev)\n+{\n+\tstruct txgbe_filter_info *filter_info = TXGBE_DEV_FILTER(dev);\n+\n+\tif (filter_info->rss_info.conf.queue_num)\n+\t\ttxgbe_config_rss_filter(dev,\n+\t\t\t&filter_info->rss_info, TRUE);\n+}\n+\n static int\n txgbe_filter_restore(struct rte_eth_dev *dev)\n {\n@@ -4918,6 +4929,7 @@ txgbe_filter_restore(struct rte_eth_dev *dev)\n \ttxgbe_syn_filter_restore(dev);\n \ttxgbe_fdir_filter_restore(dev);\n \ttxgbe_l2_tn_filter_restore(dev);\n+\ttxgbe_rss_filter_restore(dev);\n \n \treturn 0;\n }\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h\nindex 79e40caf5..c54e01308 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.h\n+++ b/drivers/net/txgbe/txgbe_ethdev.h\n@@ -123,6 +123,12 @@ struct txgbe_hw_fdir_info {\n \tbool mask_added; /* If already got mask from consistent filter */\n };\n \n+struct txgbe_rte_flow_rss_conf {\n+\tstruct rte_flow_action_rss conf; /**< RSS parameters. */\n+\tuint8_t key[TXGBE_HKEY_MAX_INDEX * sizeof(uint32_t)]; /* Hash key. */\n+\tuint16_t queue[TXGBE_MAX_RX_QUEUE_NUM]; /**< Queues indices to use. */\n+};\n+\n /* structure for interrupt relative data */\n struct txgbe_interrupt {\n \tuint32_t flags;\n@@ -233,6 +239,8 @@ struct txgbe_filter_info {\n \tstruct txgbe_5tuple_filter_list fivetuple_list;\n \t/* store the SYN filter info */\n \tuint32_t syn_info;\n+\t/* store the rss filter info */\n+\tstruct txgbe_rte_flow_rss_conf rss_info;\n };\n \n struct txgbe_l2_tn_key {\n@@ -481,6 +489,13 @@ int txgbe_set_vf_rate_limit(struct rte_eth_dev *dev, uint16_t vf,\n \t\t\t    uint16_t tx_rate, uint64_t q_msk);\n int txgbe_set_queue_rate_limit(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t\t       uint16_t tx_rate);\n+int txgbe_rss_conf_init(struct txgbe_rte_flow_rss_conf *out,\n+\t\t\tconst struct rte_flow_action_rss *in);\n+int txgbe_action_rss_same(const struct rte_flow_action_rss *comp,\n+\t\t\t  const struct rte_flow_action_rss *with);\n+int txgbe_config_rss_filter(struct rte_eth_dev *dev,\n+\t\tstruct txgbe_rte_flow_rss_conf *conf, bool add);\n+\n static inline int\n txgbe_ethertype_filter_lookup(struct txgbe_filter_info *filter_info,\n \t\t\t      uint16_t ethertype)\ndiff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c\nindex 82dde509a..209660656 100644\n--- a/drivers/net/txgbe/txgbe_rxtx.c\n+++ b/drivers/net/txgbe/txgbe_rxtx.c\n@@ -4633,3 +4633,99 @@ txgbe_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n \tqinfo->conf.tx_deferred_start = txq->tx_deferred_start;\n }\n \n+int\n+txgbe_rss_conf_init(struct txgbe_rte_flow_rss_conf *out,\n+\t\t    const struct rte_flow_action_rss *in)\n+{\n+\tif (in->key_len > RTE_DIM(out->key) ||\n+\t    in->queue_num > RTE_DIM(out->queue))\n+\t\treturn -EINVAL;\n+\tout->conf = (struct rte_flow_action_rss){\n+\t\t.func = in->func,\n+\t\t.level = in->level,\n+\t\t.types = in->types,\n+\t\t.key_len = in->key_len,\n+\t\t.queue_num = in->queue_num,\n+\t\t.key = memcpy(out->key, in->key, in->key_len),\n+\t\t.queue = memcpy(out->queue, in->queue,\n+\t\t\t\tsizeof(*in->queue) * in->queue_num),\n+\t};\n+\treturn 0;\n+}\n+\n+int\n+txgbe_action_rss_same(const struct rte_flow_action_rss *comp,\n+\t\t      const struct rte_flow_action_rss *with)\n+{\n+\treturn (comp->func == with->func &&\n+\t\tcomp->level == with->level &&\n+\t\tcomp->types == with->types &&\n+\t\tcomp->key_len == with->key_len &&\n+\t\tcomp->queue_num == with->queue_num &&\n+\t\t!memcmp(comp->key, with->key, with->key_len) &&\n+\t\t!memcmp(comp->queue, with->queue,\n+\t\t\tsizeof(*with->queue) * with->queue_num));\n+}\n+\n+int\n+txgbe_config_rss_filter(struct rte_eth_dev *dev,\n+\t\tstruct txgbe_rte_flow_rss_conf *conf, bool add)\n+{\n+\tstruct txgbe_hw *hw;\n+\tuint32_t reta;\n+\tuint16_t i;\n+\tuint16_t j;\n+\tstruct rte_eth_rss_conf rss_conf = {\n+\t\t.rss_key = conf->conf.key_len ?\n+\t\t\t(void *)(uintptr_t)conf->conf.key : NULL,\n+\t\t.rss_key_len = conf->conf.key_len,\n+\t\t.rss_hf = conf->conf.types,\n+\t};\n+\tstruct txgbe_filter_info *filter_info = TXGBE_DEV_FILTER(dev);\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\thw = TXGBE_DEV_HW(dev);\n+\n+\tif (!add) {\n+\t\tif (txgbe_action_rss_same(&filter_info->rss_info.conf,\n+\t\t\t\t\t  &conf->conf)) {\n+\t\t\ttxgbe_rss_disable(dev);\n+\t\t\tmemset(&filter_info->rss_info, 0,\n+\t\t\t\tsizeof(struct txgbe_rte_flow_rss_conf));\n+\t\t\treturn 0;\n+\t\t}\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (filter_info->rss_info.conf.queue_num)\n+\t\treturn -EINVAL;\n+\t/* Fill in redirection table\n+\t * The byte-swap is needed because NIC registers are in\n+\t * little-endian order.\n+\t */\n+\treta = 0;\n+\tfor (i = 0, j = 0; i < ETH_RSS_RETA_SIZE_128; i++, j++) {\n+\t\tif (j == conf->conf.queue_num)\n+\t\t\tj = 0;\n+\t\treta = (reta >> 8) | LS32(conf->conf.queue[j], 24, 0xFF);\n+\t\tif ((i & 3) == 3)\n+\t\t\twr32a(hw, TXGBE_REG_RSSTBL, i >> 2, reta);\n+\t}\n+\n+\t/* Configure the RSS key and the RSS protocols used to compute\n+\t * the RSS hash of input packets.\n+\t */\n+\tif ((rss_conf.rss_hf & TXGBE_RSS_OFFLOAD_ALL) == 0) {\n+\t\ttxgbe_rss_disable(dev);\n+\t\treturn 0;\n+\t}\n+\tif (rss_conf.rss_key == NULL)\n+\t\trss_conf.rss_key = rss_intel_key; /* Default hash key */\n+\ttxgbe_dev_rss_hash_update(dev, &rss_conf);\n+\n+\tif (txgbe_rss_conf_init(&filter_info->rss_info, &conf->conf))\n+\t\treturn -EINVAL;\n+\n+\treturn 0;\n+}\n+\n",
    "prefixes": [
        "v3",
        "17/33"
    ]
}