Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85425/?format=api
{ "id": 85425, "url": "https://patches.dpdk.org/api/patches/85425/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201218093702.3651867-19-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201218093702.3651867-19-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201218093702.3651867-19-jiawenwu@trustnetic.com", "date": "2020-12-18T09:36:47", "name": "[v3,18/33] net/txgbe: parse RSS filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f48723fd040fa26984689608cb4d302b7771df29", "submitter": { "id": 1932, "url": "https://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201218093702.3651867-19-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 14363, "url": "https://patches.dpdk.org/api/series/14363/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14363", "date": "2020-12-18T09:36:30", "name": "net: add txgbe PMD part 2", "version": 3, "mbox": "https://patches.dpdk.org/series/14363/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85425/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85425/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98C36A09F6;\n\tFri, 18 Dec 2020 10:40:33 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D27FECB82;\n\tFri, 18 Dec 2020 10:35:07 +0100 (CET)", "from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142])\n by dpdk.org (Postfix) with ESMTP id A0DC8CA58\n for <dev@dpdk.org>; Fri, 18 Dec 2020 10:35:00 +0100 (CET)", "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Fri, 18 Dec 2020 17:34:54 +0800 (CST)" ], "X-QQ-mid": "bizesmtp28t1608284095to7kep68", "X-QQ-SSF": "01400000002000C0D000B00A0000000", "X-QQ-FEAT": "OZolv6ISmR+RjMdOQPovi+tYZJDiVCQStilzYsGOMMzO4EiavpjAPbyLjtLpy\n ZoF6hZ1WboCbxV+jgN4owe0d3cw6jY1LQEVjx5ckNHK1jaeBU1+DRalRps0/WlGK6euaywD\n owHN+KQBhbz5Vo/n5pW3BVBqvBAx089x79HL6+cZev6GSj8XuFtHZnWpu9pN4fQn1/tHeed\n FgWUQCTe1LST4RcgSO4Sx6CwG+iew2FJTIvNAgb5685AS8+xX2xexfZtZI3PovbVP2mVRTS\n sVtYjQEYHP9YNHdZk3sojwI3gBaffZOUuD2EkU9Dzsczujp8pokuQDklY8iX7ytvr1PchOU\n /QybFMZMExCuOX6A1qB7JSAh7/DNQ==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Fri, 18 Dec 2020 17:36:47 +0800", "Message-Id": "<20201218093702.3651867-19-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201218093702.3651867-1-jiawenwu@trustnetic.com>", "References": "<20201218093702.3651867-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign6", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v3 18/33] net/txgbe: parse RSS filter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Check if the rule is a RSS filter rule, and get the RSS info.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_flow.c | 119 +++++++++++++++++++++++++++++++++\n 1 file changed, 119 insertions(+)", "diff": "diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c\nindex 47bebb98b..313f98515 100644\n--- a/drivers/net/txgbe/txgbe_flow.c\n+++ b/drivers/net/txgbe/txgbe_flow.c\n@@ -2370,6 +2370,120 @@ txgbe_parse_fdir_filter(struct rte_eth_dev *dev,\n \treturn ret;\n }\n \n+static int\n+txgbe_parse_rss_filter(struct rte_eth_dev *dev,\n+\t\t\tconst struct rte_flow_attr *attr,\n+\t\t\tconst struct rte_flow_action actions[],\n+\t\t\tstruct txgbe_rte_flow_rss_conf *rss_conf,\n+\t\t\tstruct rte_flow_error *error)\n+{\n+\tconst struct rte_flow_action *act;\n+\tconst struct rte_flow_action_rss *rss;\n+\tuint16_t n;\n+\n+\t/**\n+\t * rss only supports forwarding,\n+\t * check if the first not void action is RSS.\n+\t */\n+\tact = next_no_void_action(actions, NULL);\n+\tif (act->type != RTE_FLOW_ACTION_TYPE_RSS) {\n+\t\tmemset(rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\tact, \"Not supported action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\trss = (const struct rte_flow_action_rss *)act->conf;\n+\n+\tif (!rss || !rss->queue_num) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\tact,\n+\t\t\t \"no valid queues\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tfor (n = 0; n < rss->queue_num; n++) {\n+\t\tif (rss->queue[n] >= dev->data->nb_rx_queues) {\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t act,\n+\t\t\t\t \"queue id > max number of queues\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t}\n+\n+\tif (rss->func != RTE_ETH_HASH_FUNCTION_DEFAULT)\n+\t\treturn rte_flow_error_set\n+\t\t\t(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t \"non-default RSS hash functions are not supported\");\n+\tif (rss->level)\n+\t\treturn rte_flow_error_set\n+\t\t\t(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t \"a nonzero RSS encapsulation level is not supported\");\n+\tif (rss->key_len && rss->key_len != RTE_DIM(rss_conf->key))\n+\t\treturn rte_flow_error_set\n+\t\t\t(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t \"RSS hash key must be exactly 40 bytes\");\n+\tif (rss->queue_num > RTE_DIM(rss_conf->queue))\n+\t\treturn rte_flow_error_set\n+\t\t\t(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t \"too many queues for RSS context\");\n+\tif (txgbe_rss_conf_init(rss_conf, rss))\n+\t\treturn rte_flow_error_set\n+\t\t\t(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t \"RSS context initialization failure\");\n+\n+\t/* check if the next not void item is END */\n+\tact = next_no_void_action(actions, act);\n+\tif (act->type != RTE_FLOW_ACTION_TYPE_END) {\n+\t\tmemset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\tact, \"Not supported action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* parse attr */\n+\t/* must be input direction */\n+\tif (!attr->ingress) {\n+\t\tmemset(rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n+\t\t\t\t attr, \"Only support ingress.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* not supported */\n+\tif (attr->egress) {\n+\t\tmemset(rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\t attr, \"Not support egress.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* not supported */\n+\tif (attr->transfer) {\n+\t\tmemset(rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,\n+\t\t\t\t attr, \"No support for transfer.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (attr->priority > 0xFFFF) {\n+\t\tmemset(rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY,\n+\t\t\t\t attr, \"Error priority.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\treturn 0;\n+}\n+\n /**\n * Create or destroy a flow rule.\n * Theorically one rule can match more than one filters.\n@@ -2404,6 +2518,7 @@ txgbe_flow_validate(struct rte_eth_dev *dev,\n \tstruct rte_eth_syn_filter syn_filter;\n \tstruct txgbe_l2_tunnel_conf l2_tn_filter;\n \tstruct txgbe_fdir_rule fdir_rule;\n+\tstruct txgbe_rte_flow_rss_conf rss_conf;\n \tint ret = 0;\n \n \tmemset(&ntuple_filter, 0, sizeof(struct rte_eth_ntuple_filter));\n@@ -2436,6 +2551,10 @@ txgbe_flow_validate(struct rte_eth_dev *dev,\n \tif (!ret)\n \t\treturn 0;\n \n+\tmemset(&rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\tret = txgbe_parse_rss_filter(dev, attr,\n+\t\t\t\t\tactions, &rss_conf, error);\n+\n \treturn ret;\n }\n \n", "prefixes": [ "v3", "18/33" ] }