Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 85414,
    "url": "https://patches.dpdk.org/api/patches/85414/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201218093702.3651867-7-jiawenwu@trustnetic.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201218093702.3651867-7-jiawenwu@trustnetic.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201218093702.3651867-7-jiawenwu@trustnetic.com",
    "date": "2020-12-18T09:36:35",
    "name": "[v3,06/33] net/txgbe: parse ethertype filter",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "8d48b76cadfa5b0ad66ac8982a3fcea711ac6d1a",
    "submitter": {
        "id": 1932,
        "url": "https://patches.dpdk.org/api/people/1932/?format=api",
        "name": "Jiawen Wu",
        "email": "jiawenwu@trustnetic.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201218093702.3651867-7-jiawenwu@trustnetic.com/mbox/",
    "series": [
        {
            "id": 14363,
            "url": "https://patches.dpdk.org/api/series/14363/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14363",
            "date": "2020-12-18T09:36:30",
            "name": "net: add txgbe PMD part 2",
            "version": 3,
            "mbox": "https://patches.dpdk.org/series/14363/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/85414/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/85414/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EF526A09F6;\n\tFri, 18 Dec 2020 10:36:39 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 760B4CAB7;\n\tFri, 18 Dec 2020 10:34:49 +0100 (CET)",
            "from smtpbg501.qq.com (smtpbg501.qq.com [203.205.250.101])\n by dpdk.org (Postfix) with ESMTP id E62DCCA63\n for <dev@dpdk.org>; Fri, 18 Dec 2020 10:34:43 +0100 (CET)",
            "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Fri, 18 Dec 2020 17:34:38 +0800 (CST)"
        ],
        "X-QQ-mid": "bizesmtp28t1608284079td5d5jvs",
        "X-QQ-SSF": "01400000002000C0D000B00A0000000",
        "X-QQ-FEAT": "Fdh7gmFbvetCDYVmSDaZM9RFbqBRqmLHjLSP4XFmMNAaQmqzaVlpHgOztYeB2\n EcqknmTq73vJfUS67Xw3GYUIUAo8O+DSQt+u+2I596vBqtxHqhvWUrqSt4yG+pBCdW6Y+3e\n y4WkxKegi7oEC8nXyQQPBiBlEhOcjXNYte1uT8kNU+O+1NmFnWyB7y9xG1gkPvoHh3N8uRo\n KZBygEz10ZxxBMOCuKz3ehez0xbZA1vJwYd+qUALx1/4u8cMiZdKS1a4SrLJYJJpSjji0hN\n Jn5ram0P1AQTW8wkAkm0H1t+Y2ZJvjTyHpUlPD/jKBfZ9qlKPFAkYoXl3kcVf3Eg80dVU//\n 4gqrCI+wOa2h+2nFFOwrKg1NLDmNw==",
        "X-QQ-GoodBg": "2",
        "From": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "To": "dev@dpdk.org",
        "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "Date": "Fri, 18 Dec 2020 17:36:35 +0800",
        "Message-Id": "<20201218093702.3651867-7-jiawenwu@trustnetic.com>",
        "X-Mailer": "git-send-email 2.27.0",
        "In-Reply-To": "<20201218093702.3651867-1-jiawenwu@trustnetic.com>",
        "References": "<20201218093702.3651867-1-jiawenwu@trustnetic.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-QQ-SENDSIZE": "520",
        "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5",
        "X-QQ-Bgrelay": "1",
        "Subject": "[dpdk-dev] [PATCH v3 06/33] net/txgbe: parse ethertype filter",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Check if the rule is a ethertype rule, and get the ethertype info.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_flow.c | 248 +++++++++++++++++++++++++++++++++\n 1 file changed, 248 insertions(+)",
    "diff": "diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c\nindex f4802d269..96ff0546f 100644\n--- a/drivers/net/txgbe/txgbe_flow.c\n+++ b/drivers/net/txgbe/txgbe_flow.c\n@@ -524,6 +524,247 @@ txgbe_parse_ntuple_filter(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+/**\n+ * Parse the rule to see if it is a ethertype rule.\n+ * And get the ethertype filter info BTW.\n+ * pattern:\n+ * The first not void item can be ETH.\n+ * The next not void item must be END.\n+ * action:\n+ * The first not void action should be QUEUE.\n+ * The next not void action should be END.\n+ * pattern example:\n+ * ITEM\t\tSpec\t\t\tMask\n+ * ETH\t\ttype\t0x0807\t\t0xFFFF\n+ * END\n+ * other members in mask and spec should set to 0x00.\n+ * item->last should be NULL.\n+ */\n+static int\n+cons_parse_ethertype_filter(const struct rte_flow_attr *attr,\n+\t\t\t    const struct rte_flow_item *pattern,\n+\t\t\t    const struct rte_flow_action *actions,\n+\t\t\t    struct rte_eth_ethertype_filter *filter,\n+\t\t\t    struct rte_flow_error *error)\n+{\n+\tconst struct rte_flow_item *item;\n+\tconst struct rte_flow_action *act;\n+\tconst struct rte_flow_item_eth *eth_spec;\n+\tconst struct rte_flow_item_eth *eth_mask;\n+\tconst struct rte_flow_action_queue *act_q;\n+\n+\tif (!pattern) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM_NUM,\n+\t\t\t\tNULL, \"NULL pattern.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (!actions) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION_NUM,\n+\t\t\t\tNULL, \"NULL action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (!attr) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t   RTE_FLOW_ERROR_TYPE_ATTR,\n+\t\t\t\t   NULL, \"NULL attribute.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\titem = next_no_void_pattern(pattern, NULL);\n+\t/* The first non-void item should be MAC. */\n+\tif (item->type != RTE_FLOW_ITEM_TYPE_ETH) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\titem, \"Not supported by ethertype filter\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/*Not supported last point for range*/\n+\tif (item->last) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\titem, \"Not supported last point for range\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* Get the MAC info. */\n+\tif (!item->spec || !item->mask) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Not supported by ethertype filter\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\teth_spec = item->spec;\n+\teth_mask = item->mask;\n+\n+\t/* Mask bits of source MAC address must be full of 0.\n+\t * Mask bits of destination MAC address must be full\n+\t * of 1 or full of 0.\n+\t */\n+\tif (!rte_is_zero_ether_addr(&eth_mask->src) ||\n+\t    (!rte_is_zero_ether_addr(&eth_mask->dst) &&\n+\t     !rte_is_broadcast_ether_addr(&eth_mask->dst))) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Invalid ether address mask\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif ((eth_mask->type & UINT16_MAX) != UINT16_MAX) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Invalid ethertype mask\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* If mask bits of destination MAC address\n+\t * are full of 1, set RTE_ETHTYPE_FLAGS_MAC.\n+\t */\n+\tif (rte_is_broadcast_ether_addr(&eth_mask->dst)) {\n+\t\tfilter->mac_addr = eth_spec->dst;\n+\t\tfilter->flags |= RTE_ETHTYPE_FLAGS_MAC;\n+\t} else {\n+\t\tfilter->flags &= ~RTE_ETHTYPE_FLAGS_MAC;\n+\t}\n+\tfilter->ether_type = rte_be_to_cpu_16(eth_spec->type);\n+\n+\t/* Check if the next non-void item is END. */\n+\titem = next_no_void_pattern(pattern, item);\n+\tif (item->type != RTE_FLOW_ITEM_TYPE_END) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Not supported by ethertype filter.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* Parse action */\n+\n+\tact = next_no_void_action(actions, NULL);\n+\tif (act->type != RTE_FLOW_ACTION_TYPE_QUEUE &&\n+\t    act->type != RTE_FLOW_ACTION_TYPE_DROP) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\tact, \"Not supported action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (act->type == RTE_FLOW_ACTION_TYPE_QUEUE) {\n+\t\tact_q = (const struct rte_flow_action_queue *)act->conf;\n+\t\tfilter->queue = act_q->index;\n+\t} else {\n+\t\tfilter->flags |= RTE_ETHTYPE_FLAGS_DROP;\n+\t}\n+\n+\t/* Check if the next non-void item is END */\n+\tact = next_no_void_action(actions, act);\n+\tif (act->type != RTE_FLOW_ACTION_TYPE_END) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\tact, \"Not supported action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* Parse attr */\n+\t/* Must be input direction */\n+\tif (!attr->ingress) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n+\t\t\t\tattr, \"Only support ingress.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* Not supported */\n+\tif (attr->egress) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\tattr, \"Not support egress.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* Not supported */\n+\tif (attr->transfer) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,\n+\t\t\t\tattr, \"No support for transfer.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* Not supported */\n+\tif (attr->priority) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_PRIORITY,\n+\t\t\t\tattr, \"Not support priority.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* Not supported */\n+\tif (attr->group) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_GROUP,\n+\t\t\t\tattr, \"Not support group.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+txgbe_parse_ethertype_filter(struct rte_eth_dev *dev,\n+\t\t\t     const struct rte_flow_attr *attr,\n+\t\t\t     const struct rte_flow_item pattern[],\n+\t\t\t     const struct rte_flow_action actions[],\n+\t\t\t     struct rte_eth_ethertype_filter *filter,\n+\t\t\t     struct rte_flow_error *error)\n+{\n+\tint ret;\n+\n+\tret = cons_parse_ethertype_filter(attr, pattern,\n+\t\t\t\t\tactions, filter, error);\n+\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tif (filter->queue >= dev->data->nb_rx_queues) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_ethertype_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\tNULL, \"queue index much too big\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (filter->ether_type == RTE_ETHER_TYPE_IPV4 ||\n+\t\tfilter->ether_type == RTE_ETHER_TYPE_IPV6) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_ethertype_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\tNULL, \"IPv4/IPv6 not supported by ethertype filter\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (filter->flags & RTE_ETHTYPE_FLAGS_MAC) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_ethertype_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\tNULL, \"mac compare is unsupported\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (filter->flags & RTE_ETHTYPE_FLAGS_DROP) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_ethertype_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\tNULL, \"drop option is unsupported\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\treturn 0;\n+}\n+\n /**\n  * Create or destroy a flow rule.\n  * Theorically one rule can match more than one filters.\n@@ -554,6 +795,7 @@ txgbe_flow_validate(struct rte_eth_dev *dev,\n \t\tstruct rte_flow_error *error)\n {\n \tstruct rte_eth_ntuple_filter ntuple_filter;\n+\tstruct rte_eth_ethertype_filter ethertype_filter;\n \tint ret = 0;\n \n \tmemset(&ntuple_filter, 0, sizeof(struct rte_eth_ntuple_filter));\n@@ -562,6 +804,12 @@ txgbe_flow_validate(struct rte_eth_dev *dev,\n \tif (!ret)\n \t\treturn 0;\n \n+\tmemset(&ethertype_filter, 0, sizeof(struct rte_eth_ethertype_filter));\n+\tret = txgbe_parse_ethertype_filter(dev, attr, pattern,\n+\t\t\t\tactions, &ethertype_filter, error);\n+\tif (!ret)\n+\t\treturn 0;\n+\n \treturn ret;\n }\n \n",
    "prefixes": [
        "v3",
        "06/33"
    ]
}