Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85388/?format=api
{ "id": 85388, "url": "https://patches.dpdk.org/api/patches/85388/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201218061843.72422-1-murphyx.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201218061843.72422-1-murphyx.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201218061843.72422-1-murphyx.yang@intel.com", "date": "2020-12-18T06:18:43", "name": "[v2] net/iavf: fix negative GTP-U flow rules create successfully", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a035bd4f1cd73e77a8b79b5ed7ac32b6c0d480dc", "submitter": { "id": 1986, "url": "https://patches.dpdk.org/api/people/1986/?format=api", "name": "Murphy Yang", "email": "murphyx.yang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201218061843.72422-1-murphyx.yang@intel.com/mbox/", "series": [ { "id": 14360, "url": "https://patches.dpdk.org/api/series/14360/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14360", "date": "2020-12-18T06:18:43", "name": "[v2] net/iavf: fix negative GTP-U flow rules create successfully", "version": 2, "mbox": "https://patches.dpdk.org/series/14360/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85388/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85388/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C1F91A09F6;\n\tFri, 18 Dec 2020 07:22:47 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 610E0CA2C;\n\tFri, 18 Dec 2020 07:22:43 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 74CF0CA28\n for <dev@dpdk.org>; Fri, 18 Dec 2020 07:22:40 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2020 22:22:38 -0800", "from unknown (HELO intel-npg-odc-srv02.cd.intel.com)\n ([10.240.178.186])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2020 22:22:36 -0800" ], "IronPort-SDR": [ "\n UhW6XNMQM7fZhIfWQtC2aiZ+FsCedyq6CmqpOBhwepK+eOJLHM39KN40isOkAGZyinLqaXg63e\n S9oHf3nsmsVA==", "\n uhjapyP2LznpqUNuxicWIyw0txF8co1eSradC/mNWbShjz2rLGZ3U0NIZx2x8pMLG3erQfzvIb\n GnPQ/j+P/9+Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9838\"; a=\"163122145\"", "E=Sophos;i=\"5.78,429,1599548400\"; d=\"scan'208\";a=\"163122145\"", "E=Sophos;i=\"5.78,429,1599548400\"; d=\"scan'208\";a=\"370387582\"" ], "From": "Murphy Yang <murphyx.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "qiming.yang@intel.com, stevex.yang@intel.com, jia.guo@intel.com,\n jingjing.wu@intel.com, beilei.xing@intel.com,\n Murphy Yang <murphyx.yang@intel.com>", "Date": "Fri, 18 Dec 2020 06:18:43 +0000", "Message-Id": "<20201218061843.72422-1-murphyx.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201209071438.32419-1-murphyx.yang@intel.com>", "References": "<20201209071438.32419-1-murphyx.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/iavf: fix negative GTP-U flow rules\n\tcreate successfully", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, when use 'flow' command to create a negative GTP-U rule, it\nwill be created successfully.\n\nThe list shows the impacted outer and inner 'ipv4' GTP-U patterns with\n'ipv4' or 'gtpu' type:\n - iavf_pattern_eth_ipv4_gtpu_ipv4_udp\n - iavf_pattern_eth_ipv4_gtpu_eh_ipv4_udp\n - iavf_pattern_eth_ipv4_gtpu_ipv4_tcp\n - iavf_pattern_eth_ipv4_gtpu_eh_ipv4_tcp\n - more impacted patterns with 'gtpu' type:\n > iavf_pattern_eth_ipv4_gtpu_ipv4\n > iavf_pattern_eth_ipv4_gtpu_eh_ipv4\n\nSame as the outer and inner 'ipv6' GTP-U patterns.\n\nSo, this commit adds the invalid RSS combinations in 'invalid_rss_comb'\narray to make result correct.\n\nThe list of added invalid RSS combinations:\n - ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP\n - ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP\n - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4\n - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_UDP\n - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_TCP\n - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6\n - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_UDP\n - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_TCP\n\nFixes: 91f27b2e39ab (\"net/iavf: refactor RSS\")\n\nSigned-off-by: Murphy Yang <murphyx.yang@intel.com>\n---\nv2:\n- add invalid RSS combinations\n\n drivers/net/iavf/iavf_hash.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c\nindex c4c73e6644..8393d8535b 100644\n--- a/drivers/net/iavf/iavf_hash.c\n+++ b/drivers/net/iavf/iavf_hash.c\n@@ -806,7 +806,15 @@ static void iavf_refine_proto_hdrs(struct virtchnl_proto_hdrs *proto_hdrs,\n \n static uint64_t invalid_rss_comb[] = {\n \tETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_UDP,\n+\tETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP,\n \tETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_UDP,\n+\tETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP,\n+\tETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4,\n+\tETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_UDP,\n+\tETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_TCP,\n+\tETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6,\n+\tETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_UDP,\n+\tETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_TCP,\n \tRTE_ETH_RSS_L3_PRE32 | RTE_ETH_RSS_L3_PRE40 |\n \tRTE_ETH_RSS_L3_PRE48 | RTE_ETH_RSS_L3_PRE56 |\n \tRTE_ETH_RSS_L3_PRE96\n", "prefixes": [ "v2" ] }