Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85382/?format=api
{ "id": 85382, "url": "https://patches.dpdk.org/api/patches/85382/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201217225909.3580-2-pallavi.kadam@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201217225909.3580-2-pallavi.kadam@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201217225909.3580-2-pallavi.kadam@intel.com", "date": "2020-12-17T22:59:08", "name": "[v2,1/2] eal: add rte_random.c file on windows", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5cc5b26b1c023e5d8ea8b10fe849a1feb7129670", "submitter": { "id": 1177, "url": "https://patches.dpdk.org/api/people/1177/?format=api", "name": "Kadam, Pallavi", "email": "pallavi.kadam@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201217225909.3580-2-pallavi.kadam@intel.com/mbox/", "series": [ { "id": 14355, "url": "https://patches.dpdk.org/api/series/14355/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14355", "date": "2020-12-17T22:59:07", "name": "Support i40e PMD on Windows", "version": 2, "mbox": "https://patches.dpdk.org/series/14355/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85382/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85382/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 06D9FA09F6;\n\tFri, 18 Dec 2020 00:07:45 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 05B44CA4A;\n\tFri, 18 Dec 2020 00:07:29 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 35A91CA3E\n for <dev@dpdk.org>; Fri, 18 Dec 2020 00:07:25 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2020 15:07:21 -0800", "from win-dpdk-pallavi.jf.intel.com (HELO localhost.localdomain)\n ([10.166.188.111])\n by orsmga001.jf.intel.com with ESMTP; 17 Dec 2020 15:07:21 -0800" ], "IronPort-SDR": [ "\n cRyWGwsv7ec+kw5yg6jbRZWYyxyMjkB8bHWPFM4ffd3UdkhtorF3z9ABv68HMtQk4MG8eQU318\n oliwGmbMFbgQ==", "\n NI+k1SrnhxjVdTvyFnquTZXfKNhO2Qgdto3ncW5Hp+ROYE9V6zKXgvZ/m6t/E3lzKfMd9FhxZz\n A6stP98unFCw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9838\"; a=\"174577398\"", "E=Sophos;i=\"5.78,428,1599548400\"; d=\"scan'208\";a=\"174577398\"", "E=Sophos;i=\"5.78,428,1599548400\"; d=\"scan'208\";a=\"413660862\"" ], "X-ExtLoop1": "1", "From": "Pallavi Kadam <pallavi.kadam@intel.com>", "To": "dev@dpdk.org,\n\tthomas@monjalon.net", "Cc": "ranjit.menon@intel.com, dmitry.kozliuk@gmail.com,\n Narcisa.Vasile@microsoft.com, talshn@nvidia.com, ferruh.yigit@intel.com,\n bruce.richardson@intel.com, beilei.xing@intel.com, jia.guo@intel.com,\n pallavi.kadam@intel.com", "Date": "Thu, 17 Dec 2020 14:59:08 -0800", "Message-Id": "<20201217225909.3580-2-pallavi.kadam@intel.com>", "X-Mailer": "git-send-email 2.18.0.windows.1", "In-Reply-To": "<20201217225909.3580-1-pallavi.kadam@intel.com>", "References": "<20201205011020.6276-1-pallavi.kadam@intel.com>\n <20201217225909.3580-1-pallavi.kadam@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/2] eal: add rte_random.c file on windows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This file is required to compile and build i40e PMD on Windows.\nAdd rte_rand variable to export file.\n\nRedefine _m_prefetchw for Clang toolchain due to following error\nwith respect to conflicting types:\n\nFAILED: lib/76b5a35@@rte_eal@sta/librte_eal_common_rte_random.c.obj\nclang @lib/76b5a35@@rte_eal@sta/librte_eal_common_rte_random.c.obj.rsp\nIn file included from ../lib/librte_eal/common/rte_random.c:13:\nIn file included from ..\\lib/librte_eal/include\\rte_eal.h:20:\nIn file included from ..\\lib/librte_eal/include\\rte_per_lcore.h:25:\nIn file included from ..\\lib/librte_eal/windows/include\\pthread.h:21:\nIn file included from ..\\lib/librte_eal/windows/include\\rte_windows.h:27:\nIn file included from C:\\Program Files (x86)\\Windows Kits\\10\\include\\\n10.0.18362.0\\um\\windows.h:171:\nIn file included from C:\\Program Files (x86)\\Windows Kits\\10\\include\\\n10.0.18362.0\\shared\\windef.h:24:\nIn file included from C:\\Program Files (x86)\\Windows Kits\\10\\include\\\n10.0.18362.0\\shared\\minwindef.h:182:\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.18362.0\\um\\\nwinnt.h:3324:1: error: conflicting types for '_m_prefetchw'\n_m_prefetchw (\n^\nC:\\Program Files\\LLVM\\lib\\clang\\10.0.0\\include\\prfchwintrin.h:50:1:\nnote: previous definition is here\n_m_prefetchw(void *__P)\n^\n1 error generated.\n\nSigned-off-by: Pallavi Kadam <pallavi.kadam@intel.com>\nReviewed-by: Ranjit Menon <ranjit.menon@intel.com>\n---\n lib/librte_eal/common/meson.build | 1 +\n lib/librte_eal/rte_eal_exports.def | 1 +\n lib/librte_eal/windows/include/rte_windows.h | 5 +++++\n 3 files changed, 7 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build\nindex 39abf7a0a..98e8fffd4 100644\n--- a/lib/librte_eal/common/meson.build\n+++ b/lib/librte_eal/common/meson.build\n@@ -33,6 +33,7 @@ if is_windows\n \t\t'malloc_heap.c',\n \t\t'rte_malloc.c',\n \t\t'eal_common_timer.c',\n+\t\t'rte_random.c',\n \t\t'rte_service.c',\n \t)\n \tsubdir_done()\ndiff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def\nindex 6a6be1cfa..a2ad4d633 100644\n--- a/lib/librte_eal/rte_eal_exports.def\n+++ b/lib/librte_eal/rte_eal_exports.def\n@@ -114,6 +114,7 @@ EXPORTS\n \trte_memzone_reserve_bounded\n \trte_memzone_walk\n \trte_openlog_stream\n+\trte_rand\n \trte_realloc\n \trte_rtm_supported\n \trte_service_attr_get\ndiff --git a/lib/librte_eal/windows/include/rte_windows.h b/lib/librte_eal/windows/include/rte_windows.h\nindex b82af34f6..ee065204d 100644\n--- a/lib/librte_eal/windows/include/rte_windows.h\n+++ b/lib/librte_eal/windows/include/rte_windows.h\n@@ -18,6 +18,11 @@\n #define WIN32_LEAN_AND_MEAN\n #endif\n \n+#ifdef RTE_TOOLCHAIN_CLANG\n+#undef _m_prefetchw\n+#define _m_prefetchw __m_prefetchw\n+#endif\n+\n /* Must come first. */\n #include <windows.h>\n \n", "prefixes": [ "v2", "1/2" ] }