Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85281/?format=api
{ "id": 85281, "url": "https://patches.dpdk.org/api/patches/85281/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201217092312.27033-3-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201217092312.27033-3-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201217092312.27033-3-stevex.yang@intel.com", "date": "2020-12-17T09:22:52", "name": "[v2,02/22] app/testpmd: fix max rx packet length for VLAN packets", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7d6b34897b5fde9820a55e1f4358442c6e4417ce", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201217092312.27033-3-stevex.yang@intel.com/mbox/", "series": [ { "id": 14344, "url": "https://patches.dpdk.org/api/series/14344/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14344", "date": "2020-12-17T09:22:50", "name": "fix rx packets dropped issue", "version": 2, "mbox": "https://patches.dpdk.org/series/14344/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85281/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85281/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6ED48A09F0;\n\tThu, 17 Dec 2020 10:28:52 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4B4B0CA00;\n\tThu, 17 Dec 2020 10:28:51 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id 2FC35C9FC\n for <dev@dpdk.org>; Thu, 17 Dec 2020 10:28:48 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2020 01:28:46 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2020 01:28:22 -0800" ], "IronPort-SDR": [ "\n Ba4pGYzWo9RvaG6qOPJLRkYO2sAofPfC6vD80CCTz14Oz4N3VqoQIh1w4TocRgx8P6wETWxVGW\n xoI9sk8NfU+w==", "\n UIbjj9aXlB19D2Q0+WFoNHnFfIU+C2Bv6XK8FQ9Qh2X97yH9WHOAniTOdnfAU17RccbbnhB2ex\n 56H4umGFPGXA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9837\"; a=\"172650490\"", "E=Sophos;i=\"5.78,426,1599548400\"; d=\"scan'208\";a=\"172650490\"", "E=Sophos;i=\"5.78,426,1599548400\"; d=\"scan'208\";a=\"369745979\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com,\n asomalap@amd.com, rahul.lakkireddy@chelsio.com, hemant.agrawal@nxp.com,\n sachin.saxena@oss.nxp.com, jia.guo@intel.com, haiyue.wang@intel.com,\n g.singh@nxp.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com,\n zhouguoyang@huawei.com, xavier.huwei@huawei.com, humin29@huawei.com,\n yisen.zhuang@huawei.com, oulijun@huawei.com, jingjing.wu@intel.com,\n qiming.yang@intel.com, qi.z.zhang@intel.com, rosen.xu@intel.com,\n sthotton@marvell.com, srinivasan@marvell.com, heinrich.kuhn@netronome.com,\n hkalra@marvell.com, jerinj@marvell.com, ndabilpuram@marvell.com,\n kirankumark@marvell.com, rmody@marvell.com, shshaikh@marvell.com,\n andrew.rybchenko@oktetlabs.ru, mczekaj@marvell.com, thomas@monjalon.net,\n ferruh.yigit@intel.com, ivan.boule@6wind.com, konstantin.ananyev@intel.com,\n samuel.gauthier@6wind.com, david.marchand@6wind.com, shahafs@mellanox.com,\n stephen@networkplumber.org, maxime.coquelin@redhat.com,\n olivier.matz@6wind.com, lihuisong@huawei.com, shreyansh.jain@nxp.com,\n wei.dai@intel.com, fengchunsong@huawei.com, chenhao164@huawei.com,\n tangchengchang@hisilicon.com, helin.zhang@intel.com, yanglong.wu@intel.com,\n xiaolong.ye@intel.com, ting.xu@intel.com, xiaoyun.li@intel.com,\n dan.wei@intel.com, andy.pei@intel.com, vattunuru@marvell.com,\n skori@marvell.com, sony.chacko@qlogic.com, bruce.richardson@intel.com,\n ivan.malov@oktetlabs.ru, rad@semihalf.com, slawomir.rosek@semihalf.com,\n kamil.rytarowski@caviumnetworks.com, wei.zhao1@intel.com,\n junyux.jiang@intel.com, kumaras@chelsio.com, girish.nandibasappa@amd.com,\n rolf.neugebauer@netronome.com, alejandro.lucero@netronome.com,\n Steve Yang <stevex.yang@intel.com>", "Date": "Thu, 17 Dec 2020 09:22:52 +0000", "Message-Id": "<20201217092312.27033-3-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201217092312.27033-1-stevex.yang@intel.com>", "References": "<20201209031628.29572-1-stevex.yang@intel.com>\n <20201217092312.27033-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 02/22] app/testpmd: fix max rx packet length\n\tfor VLAN packets", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When the max rx packet length is smaller than the sum of mtu size and\nether overhead size, it should be enlarged, otherwise the VLAN packets\nwill be dropped.\n\nRemoved the rx_offloads assignment for jumbo frame during command line\nparsing, and set the correct jumbo frame flag if MTU size is larger than\nthe default value 'RTE_ETHER_MTU' within 'init_config()'.\n\nFixes: 384161e00627 (\"app/testpmd: adjust on the fly VLAN configuration\")\nFixes: 35b2d13fd6fd (\"net: add rte prefix to ether defines\")\nFixes: ce17eddefc20 (\"ethdev: introduce Rx queue offloads API\")\nFixes: 150c9ac2df13 (\"app/testpmd: update Rx offload after setting MTU\")\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\n app/test-pmd/cmdline.c | 6 ------\n app/test-pmd/config.c | 2 +-\n app/test-pmd/parameters.c | 7 ++-----\n app/test-pmd/testpmd.c | 20 ++++++++++++++++++++\n 4 files changed, 23 insertions(+), 12 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 2ccbaa039e..65042fcff5 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -1886,7 +1886,6 @@ cmd_config_max_pkt_len_parsed(void *parsed_result,\n \n \tRTE_ETH_FOREACH_DEV(pid) {\n \t\tstruct rte_port *port = &ports[pid];\n-\t\tuint64_t rx_offloads = port->dev_conf.rxmode.offloads;\n \n \t\tif (!strcmp(res->name, \"max-pkt-len\")) {\n \t\t\tif (res->value < RTE_ETHER_MIN_LEN) {\n@@ -1898,11 +1897,6 @@ cmd_config_max_pkt_len_parsed(void *parsed_result,\n \t\t\t\treturn;\n \n \t\t\tport->dev_conf.rxmode.max_rx_pkt_len = res->value;\n-\t\t\tif (res->value > RTE_ETHER_MAX_LEN)\n-\t\t\t\trx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;\n-\t\t\telse\n-\t\t\t\trx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;\n-\t\t\tport->dev_conf.rxmode.offloads = rx_offloads;\n \t\t} else {\n \t\t\tprintf(\"Unknown parameter\\n\");\n \t\t\treturn;\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 3f6c8642b1..1195f054f3 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -1434,7 +1434,7 @@ port_mtu_set(portid_t port_id, uint16_t mtu)\n \t\t * device supports jumbo frame.\n \t\t */\n \t\teth_overhead = dev_info.max_rx_pktlen - dev_info.max_mtu;\n-\t\tif (mtu > RTE_ETHER_MAX_LEN - eth_overhead) {\n+\t\tif (mtu > RTE_ETHER_MTU) {\n \t\t\trte_port->dev_conf.rxmode.offloads |=\n \t\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n \t\t\trte_port->dev_conf.rxmode.max_rx_pkt_len =\ndiff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex 414a0068fb..df5eb10d84 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -834,12 +834,9 @@ launch_args_parse(int argc, char** argv)\n \t\t\t}\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"max-pkt-len\")) {\n \t\t\t\tn = atoi(optarg);\n-\t\t\t\tif (n >= RTE_ETHER_MIN_LEN) {\n+\t\t\t\tif (n >= RTE_ETHER_MIN_LEN)\n \t\t\t\t\trx_mode.max_rx_pkt_len = (uint32_t) n;\n-\t\t\t\t\tif (n > RTE_ETHER_MAX_LEN)\n-\t\t\t\t\t\trx_offloads |=\n-\t\t\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n-\t\t\t\t} else\n+\t\t\t\telse\n \t\t\t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\t\t \"Invalid max-pkt-len=%d - should be > %d\\n\",\n \t\t\t\t\t\t n, RTE_ETHER_MIN_LEN);\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 33a060dffd..fdb5c3c38b 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -1410,6 +1410,7 @@ init_config(void)\n \tstruct rte_gro_param gro_param;\n \tuint32_t gso_types;\n \tuint16_t data_size;\n+\tuint16_t eth_overhead;\n \tbool warning = 0;\n \tint k;\n \tint ret;\n@@ -1446,6 +1447,25 @@ init_config(void)\n \t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t \"rte_eth_dev_info_get() failed\\n\");\n \n+\t\t/* Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU */\n+\t\tif (port->dev_info.max_mtu &&\n+\t\t port->dev_info.max_mtu != UINT16_MAX &&\n+\t\t port->dev_info.max_rx_pktlen &&\n+\t\t port->dev_info.max_rx_pktlen > port->dev_info.max_mtu)\n+\t\t\teth_overhead = port->dev_info.max_rx_pktlen -\n+\t\t\t\tport->dev_info.max_mtu;\n+\t\telse\n+\t\t\teth_overhead =\n+\t\t\t\tRTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;\n+\n+\t\tif (port->dev_conf.rxmode.max_rx_pkt_len <=\n+\t\t\t(uint32_t)(RTE_ETHER_MTU + eth_overhead))\n+\t\t\tport->dev_conf.rxmode.max_rx_pkt_len =\n+\t\t\t\t\tRTE_ETHER_MTU + eth_overhead;\n+\t\telse\n+\t\t\tport->dev_conf.rxmode.offloads |=\n+\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n+\n \t\tif (!(port->dev_info.tx_offload_capa &\n \t\t DEV_TX_OFFLOAD_MBUF_FAST_FREE))\n \t\t\tport->dev_conf.txmode.offloads &=\n", "prefixes": [ "v2", "02/22" ] }