Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85280/?format=api
{ "id": 85280, "url": "https://patches.dpdk.org/api/patches/85280/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201217092312.27033-2-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201217092312.27033-2-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201217092312.27033-2-stevex.yang@intel.com", "date": "2020-12-17T09:22:51", "name": "[v2,01/22] ethdev: fix MTU size exceeds max rx packet length", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7104726dfed2e7c98488cc0028f8e6fcb76bf763", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201217092312.27033-2-stevex.yang@intel.com/mbox/", "series": [ { "id": 14344, "url": "https://patches.dpdk.org/api/series/14344/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14344", "date": "2020-12-17T09:22:50", "name": "fix rx packets dropped issue", "version": 2, "mbox": "https://patches.dpdk.org/series/14344/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85280/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85280/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 56E45A09F0;\n\tThu, 17 Dec 2020 10:28:27 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2CAF2CA10;\n\tThu, 17 Dec 2020 10:28:26 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 6864ACA10\n for <dev@dpdk.org>; Thu, 17 Dec 2020 10:28:24 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2020 01:28:22 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Dec 2020 01:27:52 -0800" ], "IronPort-SDR": [ "\n 3XSswR7C2NslBIQptjU+08Ni2SVLFSoBo01fBrukc1Ei40mgmaOM9hQQWqu40d+MryFKx2pZ5G\n ZtXO3qFk/kxg==", "\n /JG8AjLKj9EAqVsmqWUo4YVYp69TWsxQgmM9QfkTVkFPjhoDeF4qq2a4cswKYFEZxJvgGvNQXS\n nd40KgCzKtMg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9837\"; a=\"193610789\"", "E=Sophos;i=\"5.78,426,1599548400\"; d=\"scan'208\";a=\"193610789\"", "E=Sophos;i=\"5.78,426,1599548400\"; d=\"scan'208\";a=\"369745126\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com,\n asomalap@amd.com, rahul.lakkireddy@chelsio.com, hemant.agrawal@nxp.com,\n sachin.saxena@oss.nxp.com, jia.guo@intel.com, haiyue.wang@intel.com,\n g.singh@nxp.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com,\n zhouguoyang@huawei.com, xavier.huwei@huawei.com, humin29@huawei.com,\n yisen.zhuang@huawei.com, oulijun@huawei.com, jingjing.wu@intel.com,\n qiming.yang@intel.com, qi.z.zhang@intel.com, rosen.xu@intel.com,\n sthotton@marvell.com, srinivasan@marvell.com, heinrich.kuhn@netronome.com,\n hkalra@marvell.com, jerinj@marvell.com, ndabilpuram@marvell.com,\n kirankumark@marvell.com, rmody@marvell.com, shshaikh@marvell.com,\n andrew.rybchenko@oktetlabs.ru, mczekaj@marvell.com, thomas@monjalon.net,\n ferruh.yigit@intel.com, ivan.boule@6wind.com, konstantin.ananyev@intel.com,\n samuel.gauthier@6wind.com, david.marchand@6wind.com, shahafs@mellanox.com,\n stephen@networkplumber.org, maxime.coquelin@redhat.com,\n olivier.matz@6wind.com, lihuisong@huawei.com, shreyansh.jain@nxp.com,\n wei.dai@intel.com, fengchunsong@huawei.com, chenhao164@huawei.com,\n tangchengchang@hisilicon.com, helin.zhang@intel.com, yanglong.wu@intel.com,\n xiaolong.ye@intel.com, ting.xu@intel.com, xiaoyun.li@intel.com,\n dan.wei@intel.com, andy.pei@intel.com, vattunuru@marvell.com,\n skori@marvell.com, sony.chacko@qlogic.com, bruce.richardson@intel.com,\n ivan.malov@oktetlabs.ru, rad@semihalf.com, slawomir.rosek@semihalf.com,\n kamil.rytarowski@caviumnetworks.com, wei.zhao1@intel.com,\n junyux.jiang@intel.com, kumaras@chelsio.com, girish.nandibasappa@amd.com,\n rolf.neugebauer@netronome.com, alejandro.lucero@netronome.com,\n Steve Yang <stevex.yang@intel.com>", "Date": "Thu, 17 Dec 2020 09:22:51 +0000", "Message-Id": "<20201217092312.27033-2-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201217092312.27033-1-stevex.yang@intel.com>", "References": "<20201209031628.29572-1-stevex.yang@intel.com>\n <20201217092312.27033-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 01/22] ethdev: fix MTU size exceeds max rx\n\tpacket length", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If max rx packet length is smaller then MTU + Ether overhead, that will\ndrop all MTU size packets.\n\nUpdate the MTU size according to the max rx packet and Ether overhead.\n\nFixes: 59d0ecdbf0e1 (\"ethdev: MTU accessors\")\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\n lib/librte_ethdev/rte_ethdev.c | 21 ++++++++++++++++++---\n 1 file changed, 18 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 17ddacc78d..ff6a1e675f 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -1292,6 +1292,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \tstruct rte_eth_dev *dev;\n \tstruct rte_eth_dev_info dev_info;\n \tstruct rte_eth_conf orig_conf;\n+\tuint16_t overhead_len;\n \tint diag;\n \tint ret;\n \n@@ -1323,6 +1324,15 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \tif (ret != 0)\n \t\tgoto rollback;\n \n+\t/* Get the real Ethernet overhead length */\n+\tif (dev_info.max_mtu &&\n+\t dev_info.max_mtu != UINT16_MAX &&\n+\t dev_info.max_rx_pktlen &&\n+\t dev_info.max_rx_pktlen > dev_info.max_mtu)\n+\t\toverhead_len = dev_info.max_rx_pktlen - dev_info.max_mtu;\n+\telse\n+\t\toverhead_len = RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;\n+\n \t/* If number of queues specified by application for both Rx and Tx is\n \t * zero, use driver preferred values. This cannot be done individually\n \t * as it is valid for either Tx or Rx (but not both) to be zero.\n@@ -1410,13 +1420,18 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\t\tgoto rollback;\n \t\t}\n \t} else {\n-\t\tif (dev_conf->rxmode.max_rx_pkt_len < RTE_ETHER_MIN_LEN ||\n-\t\t\tdev_conf->rxmode.max_rx_pkt_len > RTE_ETHER_MAX_LEN)\n+\t\tuint16_t pktlen = dev_conf->rxmode.max_rx_pkt_len;\n+\t\tif (pktlen < RTE_ETHER_MIN_MTU + overhead_len ||\n+\t\t\tpktlen > RTE_ETHER_MTU + overhead_len)\n \t\t\t/* Use default value */\n \t\t\tdev->data->dev_conf.rxmode.max_rx_pkt_len =\n-\t\t\t\t\t\t\tRTE_ETHER_MAX_LEN;\n+\t\t\t\t\t\tRTE_ETHER_MTU + overhead_len;\n \t}\n \n+\t/* Scale the MTU size to adapt max_rx_pkt_len */\n+\tdev->data->mtu = dev->data->dev_conf.rxmode.max_rx_pkt_len -\n+\t\t\t\toverhead_len;\n+\n \t/*\n \t * If LRO is enabled, check that the maximum aggregated packet\n \t * size is supported by the configured device.\n", "prefixes": [ "v2", "01/22" ] }