Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85265/?format=api
{ "id": 85265, "url": "https://patches.dpdk.org/api/patches/85265/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201216211257.37195-7-aboyer@pensando.io/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201216211257.37195-7-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20201216211257.37195-7-aboyer@pensando.io", "date": "2020-12-16T21:12:56", "name": "[v2,6/7] net/ionic: improve queue state handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3bda7be85074e08c18d6a3ccda957ca1e7a81cc5", "submitter": { "id": 2036, "url": "https://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201216211257.37195-7-aboyer@pensando.io/mbox/", "series": [ { "id": 14335, "url": "https://patches.dpdk.org/api/series/14335/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14335", "date": "2020-12-16T21:12:50", "name": "net/ionic: fixes for stop and start", "version": 2, "mbox": "https://patches.dpdk.org/series/14335/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85265/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85265/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 77340A09F0;\n\tWed, 16 Dec 2020 22:15:15 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 20EB8CA30;\n\tWed, 16 Dec 2020 22:13:38 +0100 (CET)", "from mail-pg1-f175.google.com (mail-pg1-f175.google.com\n [209.85.215.175]) by dpdk.org (Postfix) with ESMTP id E3A02CA16\n for <dev@dpdk.org>; Wed, 16 Dec 2020 22:13:34 +0100 (CET)", "by mail-pg1-f175.google.com with SMTP id w16so18513418pga.9\n for <dev@dpdk.org>; Wed, 16 Dec 2020 13:13:34 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id r67sm3345614pfc.82.2020.12.16.13.13.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 16 Dec 2020 13:13:32 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :in-reply-to:references;\n bh=BNvMlG6hvt/wHqDM4ng6uSSXIhmPdhANFyidDN2NeQU=;\n b=vvetOmEQVhjSohmX0YkB6ieQPlrdULqyVX6PDeWp3/17weSUspzeSVXqDV5fAg5Mpw\n BII29CDVzl/8PSYAIPBSqDJDTh+ooToExI5fC4qxp7WqOsiZIeIn/YBxhajVc7gvQydB\n T+NbWtszW4tTvPUpdRRMjJgsokZlDrn0jQIyMsc+ouua2A70GEWPtQOiInlZN9v5HCGw\n VJ9r2OCJG6Iwmu70FqkDHZEkc1LKmSalIxlxqZpu86EUb+Kz2XM/m/czGxhrWqbsCIc3\n d5TejyHZb5W52B9Mh7X3dUDXp6Hh5ZVqrCCPmbhEGLjOjNBgh474LZVvNn+Z6C1uMyUS\n yutg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:in-reply-to:references;\n bh=BNvMlG6hvt/wHqDM4ng6uSSXIhmPdhANFyidDN2NeQU=;\n b=S/i44Y5awl8RJv953vYF6i8PDcxuK0y4bYsNe8Lp68eNTx7M3zUa164Yhfm1LeAN/H\n q78iKff6HuvURzgEmUBO3dyip4T9KNx0E1f9oqBpUvGKCxtIsON4YFVP1SrcMn79u2v/\n 5FrHn/LnpdZXcoFsYmV5L9VfiQLbC0mJ9X98VqEfhwVt/g382kNV31kk5PTttaNM1i2n\n By9KKspX6FxC33UKRR/DiaKyNHs2OON+vR58SZX3nv0s5Vll3XOBICrrN/WwJcxnQmq/\n hRKQYApoYQS/lrlzPxQdgIj0DswEP8bawXNsUwPPfOcGaBF9JpT4YEXzLDSg6OUw2jfu\n VcBA==", "X-Gm-Message-State": "AOAM533oFo4bslwu4aYlJvXTbCWc1YqFG0kBGPn5FV6DdLdYGfyjCBUl\n ph+z5DonitYAvA52jAZcFMlU4I1XARN9Ww==", "X-Google-Smtp-Source": "\n ABdhPJzrl0b6AicfZ1qbdffk/hNzFjCp8zpLTiBXWhwD1VHiVzs1rLQ9voIiI7UaT5gJ4buXFhT50g==", "X-Received": "by 2002:a62:ae0c:0:b029:1a5:819d:9ac5 with SMTP id\n q12-20020a62ae0c0000b02901a5819d9ac5mr15318259pff.26.1608153212862;\n Wed, 16 Dec 2020 13:13:32 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Wed, 16 Dec 2020 13:12:56 -0800", "Message-Id": "<20201216211257.37195-7-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<20201216211257.37195-1-aboyer@pensando.io>", "<20201210142231.63209-1-aboyer@pensando.io>" ], "References": [ "<20201216211257.37195-1-aboyer@pensando.io>", "<20201210142231.63209-1-aboyer@pensando.io>" ], "Subject": "[dpdk-dev] [PATCH v2 6/7] net/ionic: improve queue state handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Skip ionic_lif_[rxq|txq]_init() in queue start if it's already done.\nMove ionic_lif_[rxq|txq]_deinit() from queue stop to queue release.\n\nThis allows the queues to be restarted.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_rxtx.c | 62 +++++++++++++++++++++++-----------\n 1 file changed, 42 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex b689c8381..d06f1246c 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -125,6 +125,8 @@ ionic_dev_tx_queue_release(void *tx_queue)\n \n \tIONIC_PRINT_CALL();\n \n+\tionic_lif_txq_deinit(txq);\n+\n \tionic_qcq_free(txq);\n }\n \n@@ -137,6 +139,9 @@ ionic_dev_tx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id)\n \n \ttxq = eth_dev->data->tx_queues[tx_queue_id];\n \n+\teth_dev->data->tx_queue_state[tx_queue_id] =\n+\t\tRTE_ETH_QUEUE_STATE_STOPPED;\n+\n \t/*\n \t * Note: we should better post NOP Tx desc and wait for its completion\n \t * before disabling Tx queue\n@@ -146,11 +151,6 @@ ionic_dev_tx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id)\n \n \tionic_tx_flush(&txq->cq);\n \n-\tionic_lif_txq_deinit(txq);\n-\n-\teth_dev->data->tx_queue_state[tx_queue_id] =\n-\t\tRTE_ETH_QUEUE_STATE_STOPPED;\n-\n \treturn 0;\n }\n \n@@ -187,6 +187,9 @@ ionic_dev_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id,\n \t\teth_dev->data->tx_queues[tx_queue_id] = NULL;\n \t}\n \n+\teth_dev->data->tx_queue_state[tx_queue_id] =\n+\t\tRTE_ETH_QUEUE_STATE_STOPPED;\n+\n \terr = ionic_tx_qcq_alloc(lif, tx_queue_id, nb_desc, &txq);\n \tif (err) {\n \t\tIONIC_PRINT(DEBUG, \"Queue allocation failure\");\n@@ -210,22 +213,30 @@ ionic_dev_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id,\n int __rte_cold\n ionic_dev_tx_queue_start(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id)\n {\n+\tuint8_t *tx_queue_state = eth_dev->data->tx_queue_state;\n \tstruct ionic_qcq *txq;\n \tint err;\n \n+\tif (tx_queue_state[tx_queue_id] == RTE_ETH_QUEUE_STATE_STARTED) {\n+\t\tIONIC_PRINT(DEBUG, \"TX queue %u already started\",\n+\t\t\ttx_queue_id);\n+\t\treturn 0;\n+\t}\n+\n \ttxq = eth_dev->data->tx_queues[tx_queue_id];\n \n \tIONIC_PRINT(DEBUG, \"Starting TX queue %u, %u descs\",\n \t\ttx_queue_id, txq->q.num_descs);\n \n-\terr = ionic_lif_txq_init(txq);\n-\tif (err)\n-\t\treturn err;\n+\tif (!(txq->flags & IONIC_QCQ_F_INITED)) {\n+\t\terr = ionic_lif_txq_init(txq);\n+\t\tif (err)\n+\t\t\treturn err;\n+\t}\n \n \tionic_qcq_enable(txq);\n \n-\teth_dev->data->tx_queue_state[tx_queue_id] =\n-\t\tRTE_ETH_QUEUE_STATE_STARTED;\n+\ttx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;\n \n \treturn 0;\n }\n@@ -634,6 +645,8 @@ ionic_dev_rx_queue_release(void *rx_queue)\n \n \tionic_rx_empty(&rxq->q);\n \n+\tionic_lif_rxq_deinit(rxq);\n+\n \tionic_qcq_free(rxq);\n }\n \n@@ -682,6 +695,9 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,\n \t\teth_dev->data->rx_queues[rx_queue_id] = NULL;\n \t}\n \n+\teth_dev->data->rx_queue_state[rx_queue_id] =\n+\t\tRTE_ETH_QUEUE_STATE_STOPPED;\n+\n \terr = ionic_rx_qcq_alloc(lif, rx_queue_id, nb_desc, &rxq);\n \tif (err) {\n \t\tIONIC_PRINT(ERR, \"Queue %d allocation failure\", rx_queue_id);\n@@ -953,17 +969,26 @@ int __rte_cold\n ionic_dev_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)\n {\n \tuint32_t frame_size = eth_dev->data->dev_conf.rxmode.max_rx_pkt_len;\n+\tuint8_t *rx_queue_state = eth_dev->data->rx_queue_state;\n \tstruct ionic_qcq *rxq;\n \tint err;\n \n+\tif (rx_queue_state[rx_queue_id] == RTE_ETH_QUEUE_STATE_STARTED) {\n+\t\tIONIC_PRINT(DEBUG, \"RX queue %u already started\",\n+\t\t\trx_queue_id);\n+\t\treturn 0;\n+\t}\n+\n \trxq = eth_dev->data->rx_queues[rx_queue_id];\n \n \tIONIC_PRINT(DEBUG, \"Starting RX queue %u, %u descs (size: %u)\",\n \t\trx_queue_id, rxq->q.num_descs, frame_size);\n \n-\terr = ionic_lif_rxq_init(rxq);\n-\tif (err)\n-\t\treturn err;\n+\tif (!(rxq->flags & IONIC_QCQ_F_INITED)) {\n+\t\terr = ionic_lif_rxq_init(rxq);\n+\t\tif (err)\n+\t\t\treturn err;\n+\t}\n \n \t/* Allocate buffers for descriptor rings */\n \tif (ionic_rx_fill(rxq, frame_size) != 0) {\n@@ -974,8 +999,7 @@ ionic_dev_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)\n \n \tionic_qcq_enable(rxq);\n \n-\teth_dev->data->rx_queue_state[rx_queue_id] =\n-\t\tRTE_ETH_QUEUE_STATE_STARTED;\n+\trx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;\n \n \treturn 0;\n }\n@@ -1044,16 +1068,14 @@ ionic_dev_rx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)\n \n \trxq = eth_dev->data->rx_queues[rx_queue_id];\n \n+\teth_dev->data->rx_queue_state[rx_queue_id] =\n+\t\tRTE_ETH_QUEUE_STATE_STOPPED;\n+\n \tionic_qcq_disable(rxq);\n \n \t/* Flush */\n \tionic_rxq_service(&rxq->cq, -1, NULL);\n \n-\tionic_lif_rxq_deinit(rxq);\n-\n-\teth_dev->data->rx_queue_state[rx_queue_id] =\n-\t\tRTE_ETH_QUEUE_STATE_STOPPED;\n-\n \treturn 0;\n }\n \n", "prefixes": [ "v2", "6/7" ] }