Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85263/?format=api
{ "id": 85263, "url": "https://patches.dpdk.org/api/patches/85263/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201216211257.37195-5-aboyer@pensando.io/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201216211257.37195-5-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20201216211257.37195-5-aboyer@pensando.io", "date": "2020-12-16T21:12:54", "name": "[v2,4/7] net/ionic: fully implement remove-on-close", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7d847f092b4eb712837f5fed537ed550318a21c9", "submitter": { "id": 2036, "url": "https://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201216211257.37195-5-aboyer@pensando.io/mbox/", "series": [ { "id": 14335, "url": "https://patches.dpdk.org/api/series/14335/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14335", "date": "2020-12-16T21:12:50", "name": "net/ionic: fixes for stop and start", "version": 2, "mbox": "https://patches.dpdk.org/series/14335/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85263/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85263/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B97E7A09F0;\n\tWed, 16 Dec 2020 22:14:38 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7E3DECA0E;\n\tWed, 16 Dec 2020 22:13:34 +0100 (CET)", "from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180]) by dpdk.org (Postfix) with ESMTP id 0B5C0C9CA\n for <dev@dpdk.org>; Wed, 16 Dec 2020 22:13:31 +0100 (CET)", "by mail-pl1-f180.google.com with SMTP id x12so13190255plr.10\n for <dev@dpdk.org>; Wed, 16 Dec 2020 13:13:30 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id r67sm3345614pfc.82.2020.12.16.13.13.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 16 Dec 2020 13:13:28 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :in-reply-to:references;\n bh=Bgvg/pp9ubxXqJY5qXM2NXJg+EIPe1bg5yUXhpJ88og=;\n b=xWEZWUyseJ1E9ntB+4bIhti8erETRI2jOhFzZkoN53ZTHYFP1UZStT+jEIYuX2+5Vk\n FRN2J7DnZoGGdwJl2GRUO/7AebdM5evOA+MIJTQHMkOlo1XRsJFDAf3tCxD8wrSkPA6w\n LQ6mr9XkpetZFTaTbhCHxPkHF/LAztQJjDytcRL7EpdKWHfnGLgK7NfvRUWzVWW21zuO\n tI4eKHySmCoIzRIczN3nVrKytWO26KG2y56RVQAauSvXWKbMg0F+LxF75vd+lZvCEC2Z\n It6DB51chs7pXSK9qVc5/UR4Aq2Nuk4Cc59GP9FOaoW47+aqOmLY7QMK9R67zxKdynKt\n szHg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:in-reply-to:references;\n bh=Bgvg/pp9ubxXqJY5qXM2NXJg+EIPe1bg5yUXhpJ88og=;\n b=NJCuKuLeSsAd2sHOw3AtBBkhNZJOBhEHJo8iQFC514L+8b2nDI0zuXMKBn7lNDyROM\n ud/wRSev5FMdZ9178d0T2adZk4Qyh4gMrZrZhktE6PugW7TuYePNNbUcHTyquwpNQkiT\n ycBjrsg2AiO0OHwzWs9PgNFinjm3J/FnHtBli9uPnB26dJNUPg1mbouvUQWw/Avl/QjH\n 6SQ50/zeDJYa5H5u1RIK630zLnV/zK0Fb77WgYZZXB4TesjMMSRAy/Bmu892rLVcAL1i\n ZPY5WoYDiXKGbk8pHcy7b+MmNNEMCDv/pMrzVhUs287gi/NWmnnIep6qvyHgm5x9thzX\n HgrA==", "X-Gm-Message-State": "AOAM531rmy3kSU1sddQ3LpI4JP3OEN7TSWcG/STHo4SRqVD17eD5od7l\n cZTQRvr/LpD6tthNZiuCslCWndZNQDHiGg==", "X-Google-Smtp-Source": "\n ABdhPJy3kMipxKvtiV2UQ3uQzMs68w9VkE2vHMahPr8oIYPDr3v1cc7k+cNkarRxCQBtf0u586DB/Q==", "X-Received": "by 2002:a17:90a:fb8a:: with SMTP id\n cp10mr4658297pjb.136.1608153209007;\n Wed, 16 Dec 2020 13:13:29 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Wed, 16 Dec 2020 13:12:54 -0800", "Message-Id": "<20201216211257.37195-5-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<20201216211257.37195-1-aboyer@pensando.io>", "<20201210142231.63209-1-aboyer@pensando.io>" ], "References": [ "<20201216211257.37195-1-aboyer@pensando.io>", "<20201210142231.63209-1-aboyer@pensando.io>" ], "Subject": "[dpdk-dev] [PATCH v2 4/7] net/ionic: fully implement remove-on-close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "ionic_dev_close() is responsible for destroying the ethdev, lif, and\nadapter. eth_ionic_dev_remove() calls ionic_dev_close().\n\nRemove-on-close is now required behavior for a PMD.\nRemove the UNMAINTAINED flag.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n MAINTAINERS | 2 +-\n drivers/net/ionic/ionic_ethdev.c | 40 ++++++++++++++++----------------\n drivers/net/ionic/ionic_lif.c | 15 ++++++++++++\n drivers/net/ionic/ionic_lif.h | 1 +\n 4 files changed, 37 insertions(+), 21 deletions(-)", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex 6787b15dc..76ed473e4 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -841,7 +841,7 @@ F: doc/guides/nics/pfe.rst\n F: drivers/net/pfe/\n F: doc/guides/nics/features/pfe.ini\n \n-Pensando ionic - UNMAINTAINED\n+Pensando ionic\n M: Andrew Boyer <aboyer@pensando.io>\n F: drivers/net/ionic/\n F: doc/guides/nics/ionic.rst\ndiff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex 54d7a6cad..7ab32a0d7 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -955,6 +955,8 @@ ionic_dev_stop(struct rte_eth_dev *eth_dev)\n \treturn err;\n }\n \n+static void ionic_unconfigure_intr(struct ionic_adapter *adapter);\n+\n /*\n * Reset and stop device.\n */\n@@ -962,6 +964,7 @@ static int\n ionic_dev_close(struct rte_eth_dev *eth_dev)\n {\n \tstruct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);\n+\tstruct ionic_adapter *adapter = lif->adapter;\n \tint err;\n \n \tIONIC_PRINT_CALL();\n@@ -974,11 +977,17 @@ ionic_dev_close(struct rte_eth_dev *eth_dev)\n \t\treturn -1;\n \t}\n \n-\terr = eth_ionic_dev_uninit(eth_dev);\n-\tif (err) {\n-\t\tIONIC_PRINT(ERR, \"Cannot destroy LIF: %d\", err);\n-\t\treturn -1;\n-\t}\n+\tionic_lif_free_queues(lif);\n+\n+\tIONIC_PRINT(NOTICE, \"Removing device %s\", eth_dev->device->name);\n+\tionic_unconfigure_intr(adapter);\n+\n+\trte_eth_dev_destroy(eth_dev, eth_ionic_dev_uninit);\n+\n+\tionic_port_reset(adapter);\n+\tionic_reset(adapter);\n+\n+\trte_free(adapter);\n \n \treturn 0;\n }\n@@ -1270,29 +1279,20 @@ eth_ionic_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n }\n \n static int\n-eth_ionic_pci_remove(struct rte_pci_device *pci_dev __rte_unused)\n+eth_ionic_pci_remove(struct rte_pci_device *pci_dev)\n {\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n-\tstruct ionic_adapter *adapter = NULL;\n \tstruct rte_eth_dev *eth_dev;\n-\tstruct ionic_lif *lif;\n \n \t/* Adapter lookup is using the eth_dev name */\n \tsnprintf(name, sizeof(name), \"%s_lif\", pci_dev->device.name);\n \n \teth_dev = rte_eth_dev_allocated(name);\n-\tif (eth_dev) {\n-\t\tlif = IONIC_ETH_DEV_TO_LIF(eth_dev);\n-\t\tadapter = lif->adapter;\n-\t}\n-\n-\tif (adapter) {\n-\t\tionic_unconfigure_intr(adapter);\n-\n-\t\trte_eth_dev_destroy(eth_dev, eth_ionic_dev_uninit);\n-\n-\t\trte_free(adapter);\n-\t}\n+\tif (eth_dev)\n+\t\tionic_dev_close(eth_dev);\n+\telse\n+\t\tIONIC_PRINT(DEBUG, \"Cannot find device %s\",\n+\t\t\tpci_dev->device.name);\n \n \treturn 0;\n }\ndiff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex 4b5221b83..9b11e6310 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -920,6 +920,21 @@ ionic_lif_free(struct ionic_lif *lif)\n \t}\n }\n \n+void\n+ionic_lif_free_queues(struct ionic_lif *lif)\n+{\n+\tuint32_t i;\n+\n+\tfor (i = 0; i < lif->ntxqcqs; i++) {\n+\t\tionic_dev_tx_queue_release(lif->eth_dev->data->tx_queues[i]);\n+\t\tlif->eth_dev->data->tx_queues[i] = NULL;\n+\t}\n+\tfor (i = 0; i < lif->nrxqcqs; i++) {\n+\t\tionic_dev_rx_queue_release(lif->eth_dev->data->rx_queues[i]);\n+\t\tlif->eth_dev->data->rx_queues[i] = NULL;\n+\t}\n+}\n+\n int\n ionic_lif_rss_config(struct ionic_lif *lif,\n \t\tconst uint16_t types, const uint8_t *key, const uint32_t *indir)\ndiff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h\nindex c1d15dca6..cc0e4f04e 100644\n--- a/drivers/net/ionic/ionic_lif.h\n+++ b/drivers/net/ionic/ionic_lif.h\n@@ -121,6 +121,7 @@ int ionic_lifs_size(struct ionic_adapter *ionic);\n \n int ionic_lif_alloc(struct ionic_lif *lif);\n void ionic_lif_free(struct ionic_lif *lif);\n+void ionic_lif_free_queues(struct ionic_lif *lif);\n \n int ionic_lif_init(struct ionic_lif *lif);\n void ionic_lif_deinit(struct ionic_lif *lif);\n", "prefixes": [ "v2", "4/7" ] }