Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85254/?format=api
{ "id": 85254, "url": "https://patches.dpdk.org/api/patches/85254/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201216164931.1517-2-ophirmu@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201216164931.1517-2-ophirmu@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201216164931.1517-2-ophirmu@nvidia.com", "date": "2020-12-16T16:49:26", "name": "[v1,1/6] app/regex: move mem pool creation to worker routine", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a5cc9e1307c6bc9091bd15188fcd16400fd0b41c", "submitter": { "id": 1908, "url": "https://patches.dpdk.org/api/people/1908/?format=api", "name": "Ophir Munk", "email": "ophirmu@nvidia.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201216164931.1517-2-ophirmu@nvidia.com/mbox/", "series": [ { "id": 14334, "url": "https://patches.dpdk.org/api/series/14334/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14334", "date": "2020-12-16T16:49:28", "name": "regex multi Q with multi cores support", "version": 1, "mbox": "https://patches.dpdk.org/series/14334/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85254/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85254/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D0B6A09F0;\n\tWed, 16 Dec 2020 17:50:41 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 70D96C9E7;\n\tWed, 16 Dec 2020 17:50:07 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id A9A93C9D4\n for <dev@dpdk.org>; Wed, 16 Dec 2020 17:50:04 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n ophirmu@nvidia.com) with SMTP; 16 Dec 2020 18:49:58 +0200", "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0BGGnvcs005924;\n Wed, 16 Dec 2020 18:49:57 +0200" ], "From": "Ophir Munk <ophirmu@nvidia.com>", "To": "Ori Kam <orika@nvidia.com>, dev@dpdk.org,\n Raslan Darawsheh <rasland@nvidia.com>", "Cc": "Ophir Munk <ophirmu@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>", "Date": "Wed, 16 Dec 2020 16:49:26 +0000", "Message-Id": "<20201216164931.1517-2-ophirmu@nvidia.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20201216164931.1517-1-ophirmu@nvidia.com>", "References": "<20201216164931.1517-1-ophirmu@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v1 1/6] app/regex: move mem pool creation to\n\tworker routine", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Function rte_pktmbuf_pool_create() is moved from init_port() routine to\nrun_regex() routine. Looking forward on multi core support - init_port()\nwill be called only once as part of application startup while mem pool\ncreation should be called multiple times (per core).\n\nSigned-off-by: Ophir Munk <ophirmu@nvidia.com>\n---\n app/test-regex/main.c | 34 +++++++++++++++-------------------\n 1 file changed, 15 insertions(+), 19 deletions(-)", "diff": "diff --git a/app/test-regex/main.c b/app/test-regex/main.c\nindex ac6152d..cb2a065 100644\n--- a/app/test-regex/main.c\n+++ b/app/test-regex/main.c\n@@ -163,8 +163,7 @@ read_file(char *file, char **buf)\n }\n \n static int\n-init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,\n-\t uint16_t *nb_max_payload, char *rules_file, uint8_t *nb_max_matches)\n+init_port(uint16_t *nb_max_payload, char *rules_file, uint8_t *nb_max_matches)\n {\n \tuint16_t id;\n \tuint16_t num_devs;\n@@ -187,14 +186,6 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,\n \t\treturn -EINVAL;\n \t}\n \n-\t*mbuf_mp = rte_pktmbuf_pool_create(\"mbuf_pool\", nb_jobs, 0,\n-\t\t\t\t\t 0, MBUF_SIZE, rte_socket_id());\n-\tif (*mbuf_mp == NULL) {\n-\t\tprintf(\"Error, can't create memory pool\\n\");\n-\t\tres = -ENOMEM;\n-\t\tgoto error;\n-\t}\n-\n \trules_len = read_file(rules_file, &rules);\n \tif (rules_len < 0) {\n \t\tprintf(\"Error, can't read rules files.\\n\");\n@@ -237,8 +228,6 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,\n error:\n \tif (rules)\n \t\trte_free(rules);\n-\tif (*mbuf_mp)\n-\t\trte_mempool_free(*mbuf_mp);\n \treturn res;\n }\n \n@@ -248,7 +237,7 @@ extbuf_free_cb(void *addr __rte_unused, void *fcb_opaque __rte_unused)\n }\n \n static int\n-run_regex(struct rte_mempool *mbuf_mp, uint32_t nb_jobs,\n+run_regex(uint32_t nb_jobs,\n \t uint16_t nb_max_payload, bool perf_mode, uint32_t nb_iterations,\n \t char *data_file, uint8_t nb_max_matches)\n {\n@@ -273,9 +262,17 @@ run_regex(struct rte_mempool *mbuf_mp, uint32_t nb_jobs,\n \ttime_t end;\n \tdouble time;\n \tstruct job_ctx *jobs_ctx;\n+\tstruct rte_mempool *mbuf_mp;\n \n \tshinfo.free_cb = extbuf_free_cb;\n \n+\tmbuf_mp = rte_pktmbuf_pool_create(\"mbuf_pool\", nb_jobs, 0,\n+\t\t\t0, MBUF_SIZE, rte_socket_id());\n+\tif (mbuf_mp == NULL) {\n+\t\tprintf(\"Error, can't create memory pool\\n\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n \tops = rte_malloc(NULL, sizeof(*ops) * nb_jobs, 0);\n \tif (!ops) {\n \t\tprintf(\"Error, can't allocate memory for ops.\\n\");\n@@ -409,6 +406,9 @@ run_regex(struct rte_mempool *mbuf_mp, uint32_t nb_jobs,\n \trte_free(jobs_ctx);\n \tif (buf)\n \t\trte_free(buf);\n+\tif (mbuf_mp)\n+\t\trte_mempool_free(mbuf_mp);\n+\n \treturn res;\n }\n \n@@ -417,7 +417,6 @@ main(int argc, char **argv)\n {\n \tchar rules_file[MAX_FILE_NAME];\n \tchar data_file[MAX_FILE_NAME];\n-\tstruct rte_mempool *mbuf_mp = NULL;\n \tuint32_t nb_jobs = 0;\n \tuint16_t nb_max_payload = 0;\n \tbool perf_mode = 0;\n@@ -434,16 +433,13 @@ main(int argc, char **argv)\n \t\targs_parse(argc, argv, rules_file, data_file, &nb_jobs,\n \t\t\t &perf_mode, &nb_iterations);\n \n-\tret = init_port(&mbuf_mp, nb_jobs, &nb_max_payload, rules_file,\n-\t\t\t&nb_max_matches);\n+\tret = init_port(&nb_max_payload, rules_file, &nb_max_matches);\n \tif (ret < 0)\n \t\trte_exit(EXIT_FAILURE, \"init port failed\\n\");\n-\tret = run_regex(mbuf_mp, nb_jobs, nb_max_payload, perf_mode,\n+\tret = run_regex(nb_jobs, nb_max_payload, perf_mode,\n \t\t\tnb_iterations, data_file, nb_max_matches);\n \tif (ret < 0) {\n-\t\trte_mempool_free(mbuf_mp);\n \t\trte_exit(EXIT_FAILURE, \"RegEx function failed\\n\");\n \t}\n-\trte_mempool_free(mbuf_mp);\n \treturn EXIT_SUCCESS;\n }\n", "prefixes": [ "v1", "1/6" ] }