Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8519/?format=api
{ "id": 8519, "url": "https://patches.dpdk.org/api/patches/8519/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1446459547-1754-6-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1446459547-1754-6-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1446459547-1754-6-git-send-email-harry.van.haaren@intel.com", "date": "2015-11-02T10:19:02", "name": "[dpdk-dev,v5,05/10] igbvf: add xstats() implementation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "044f32fce11690032505769785bb4ab52ee885f6", "submitter": { "id": 317, "url": "https://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1446459547-1754-6-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/8519/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/8519/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8CE318E9B;\n\tMon, 2 Nov 2015 11:19:25 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id DF7038E8E\n\tfor <dev@dpdk.org>; Mon, 2 Nov 2015 11:19:22 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 02 Nov 2015 02:19:23 -0800", "from sie-lab-212-222.ir.intel.com (HELO\n\tsilpixa00366884.ir.intel.com) ([10.237.212.222])\n\tby orsmga002.jf.intel.com with ESMTP; 02 Nov 2015 02:19:21 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,234,1444719600\"; d=\"scan'208\";a=\"840505416\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 2 Nov 2015 10:19:02 +0000", "Message-Id": "<1446459547-1754-6-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1446459547-1754-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1446204998-17151-2-git-send-email-harry.van.haaren@intel.com>\n\t<1446459547-1754-1-git-send-email-harry.van.haaren@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 05/10] igbvf: add xstats() implementation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add xstats functionality to igbvf PMD, adding\nnecessary statistic strings.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n drivers/net/e1000/igb_ethdev.c | 62 +++++++++++++++++++++++++++++++++++++-----\n 1 file changed, 55 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex a5461e5..e57d436 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -152,7 +152,10 @@ static int igbvf_dev_start(struct rte_eth_dev *dev);\n static void igbvf_dev_stop(struct rte_eth_dev *dev);\n static void igbvf_dev_close(struct rte_eth_dev *dev);\n static int eth_igbvf_link_update(struct e1000_hw *hw);\n-static void eth_igbvf_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats);\n+static void eth_igbvf_stats_get(struct rte_eth_dev *dev,\n+\t\t\t\tstruct rte_eth_stats *rte_stats);\n+static int eth_igbvf_xstats_get(struct rte_eth_dev *dev,\n+\t\t\t\tstruct rte_eth_xstats *xstats, unsigned n);\n static void eth_igbvf_stats_reset(struct rte_eth_dev *dev);\n static int igbvf_vlan_filter_set(struct rte_eth_dev *dev,\n \t\tuint16_t vlan_id, int on);\n@@ -345,7 +348,9 @@ static const struct eth_dev_ops igbvf_eth_dev_ops = {\n \t.dev_close = igbvf_dev_close,\n \t.link_update = eth_igb_link_update,\n \t.stats_get = eth_igbvf_stats_get,\n+\t.xstats_get = eth_igbvf_xstats_get,\n \t.stats_reset = eth_igbvf_stats_reset,\n+\t.xstats_reset = eth_igbvf_stats_reset,\n \t.vlan_filter_set = igbvf_vlan_filter_set,\n \t.dev_infos_get = eth_igbvf_infos_get,\n \t.rx_queue_setup = eth_igb_rx_queue_setup,\n@@ -428,6 +433,17 @@ static const struct rte_igb_xstats_name_off rte_igb_stats_strings[] = {\n #define IGB_NB_XSTATS (sizeof(rte_igb_stats_strings) / \\\n \t\tsizeof(rte_igb_stats_strings[0]))\n \n+static const struct rte_igb_xstats_name_off rte_igbvf_stats_strings[] = {\n+\t{\"rx_multicast_packets\", offsetof(struct e1000_vf_stats, mprc)},\n+\t{\"rx_good_loopback_packets\", offsetof(struct e1000_vf_stats, gprlbc)},\n+\t{\"tx_good_loopback_packets\", offsetof(struct e1000_vf_stats, gptlbc)},\n+\t{\"rx_good_loopback_bytes\", offsetof(struct e1000_vf_stats, gorlbc)},\n+\t{\"tx_good_loopback_bytes\", offsetof(struct e1000_vf_stats, gotlbc)},\n+};\n+\n+#define IGBVF_NB_XSTATS (sizeof(rte_igbvf_stats_strings) / \\\n+\t\tsizeof(rte_igbvf_stats_strings[0]))\n+\n /**\n * Atomically reads the link status information from global\n * structure rte_eth_dev.\n@@ -1534,12 +1550,8 @@ eth_igb_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstats *xstats,\n }\n \n static void\n-eth_igbvf_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats)\n+igbvf_read_stats_registers(struct e1000_hw *hw, struct e1000_vf_stats *hw_stats)\n {\n-\tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct e1000_vf_stats *hw_stats = (struct e1000_vf_stats*)\n-\t\t\t E1000_DEV_PRIVATE_TO_STATS(dev->data->dev_private);\n-\n \t/* Good Rx packets, include VF loopback */\n \tUPDATE_VF_STAT(E1000_VFGPRC,\n \t hw_stats->last_gprc, hw_stats->gprc);\n@@ -1575,6 +1587,43 @@ eth_igbvf_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats)\n \t/* Good Tx loopback octets */\n \tUPDATE_VF_STAT(E1000_VFGOTLBC,\n \t hw_stats->last_gotlbc, hw_stats->gotlbc);\n+}\n+\n+static int\n+eth_igbvf_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstats *xstats,\n+\t\t unsigned n)\n+{\n+\tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tstruct e1000_vf_stats *hw_stats = (struct e1000_vf_stats *)\n+\t\t\tE1000_DEV_PRIVATE_TO_STATS(dev->data->dev_private);\n+\tunsigned i;\n+\n+\tif (n < IGBVF_NB_XSTATS)\n+\t\treturn IGBVF_NB_XSTATS;\n+\n+\tigbvf_read_stats_registers(hw, hw_stats);\n+\n+\tif (!xstats)\n+\t\treturn 0;\n+\n+\tfor (i = 0; i < IGBVF_NB_XSTATS; i++) {\n+\t\tsnprintf(xstats[i].name, sizeof(xstats[i].name), \"%s\",\n+\t\t\t rte_igbvf_stats_strings[i].name);\n+\t\txstats[i].value = *(uint64_t *)(((char *)hw_stats) +\n+\t\t\trte_igbvf_stats_strings[i].offset);\n+\t}\n+\n+\treturn IGBVF_NB_XSTATS;\n+}\n+\n+static void\n+eth_igbvf_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats)\n+{\n+\tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tstruct e1000_vf_stats *hw_stats = (struct e1000_vf_stats *)\n+\t\t\t E1000_DEV_PRIVATE_TO_STATS(dev->data->dev_private);\n+\n+\tigbvf_read_stats_registers(hw, hw_stats);\n \n \tif (rte_stats == NULL)\n \t\treturn;\n@@ -1602,7 +1651,6 @@ eth_igbvf_stats_reset(struct rte_eth_dev *dev)\n \t/* reset HW current stats*/\n \tmemset(&hw_stats->gprc, 0, sizeof(*hw_stats) -\n \t offsetof(struct e1000_vf_stats, gprc));\n-\n }\n \n static void\n", "prefixes": [ "dpdk-dev", "v5", "05/10" ] }