Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85019/?format=api
{ "id": 85019, "url": "https://patches.dpdk.org/api/patches/85019/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1607705598-8695-1-git-send-email-17826875952@163.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1607705598-8695-1-git-send-email-17826875952@163.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1607705598-8695-1-git-send-email-17826875952@163.com", "date": "2020-12-11T16:53:18", "name": "[v2] net/virtio-user: fix run close(0) and close callfd", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "df59300501b25cf8d90891dd15f1ed92e7ccf2f9", "submitter": { "id": 2055, "url": "https://patches.dpdk.org/api/people/2055/?format=api", "name": "Jiawei Zhu", "email": "17826875952@163.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1607705598-8695-1-git-send-email-17826875952@163.com/mbox/", "series": [ { "id": 14263, "url": "https://patches.dpdk.org/api/series/14263/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14263", "date": "2020-12-11T16:53:18", "name": "[v2] net/virtio-user: fix run close(0) and close callfd", "version": 2, "mbox": "https://patches.dpdk.org/series/14263/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/85019/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/85019/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DAC1EA09E0;\n\tFri, 11 Dec 2020 17:53:26 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7641CC952;\n\tFri, 11 Dec 2020 17:53:25 +0100 (CET)", "from mail-m971.mail.163.com (mail-m971.mail.163.com [123.126.97.1])\n by dpdk.org (Postfix) with ESMTP id 99A2CC950\n for <dev@dpdk.org>; Fri, 11 Dec 2020 17:53:23 +0100 (CET)", "from ecs-5dae.localdomain (unknown [119.8.186.164])\n by smtp1 (Coremail) with SMTP id GdxpCgAnDkz+o9NfUNOMAw--.2068S2;\n Sat, 12 Dec 2020 00:53:19 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n s=s110527; h=From:Subject:Date:Message-Id; bh=iukThcZG2Ybe4Q1U9Y\n uz7stM7dQRyZOJjPth3nVg7qo=; b=dkTFLj2L1dL12F7xToOhcsAKTUKyIKDdti\n krpRGIUKGHqRoamR0G1QTkN7fPXaUIrWYZNECDk/oVzbGkxqtffHdsO0MRjXfd8D\n a9lsfb27gtg/7mLYa/B1uBOtEMf3HAAdTCFcy0ugGtRUMOymJZlwbuUz+xvMRI54\n S/2BzJzd8=", "From": "Jiawei Zhu <17826875952@163.com>", "To": "dev@dpdk.org", "Date": "Sat, 12 Dec 2020 00:53:18 +0800", "Message-Id": "<1607705598-8695-1-git-send-email-17826875952@163.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1607703293-6121-1-git-send-email-17826875952@163.com>", "References": "<1607703293-6121-1-git-send-email-17826875952@163.com>", "X-CM-TRANSID": "GdxpCgAnDkz+o9NfUNOMAw--.2068S2", "X-Coremail-Antispam": "1Uf129KBjvJXoWxJr18ZF1rWryxAFWkZrW3Awb_yoW8GF4DpF\n 4UuFs3Xry7Gry2k3WrJ3WDWa45Zas3Gw47Gr95Xwn5CrZ5Ar15ArW8Aa4Ykr17AryDAFW7\n tr109F15trZxuaUanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jY_M3UUUUU=", "X-Originating-IP": "[119.8.186.164]", "X-CM-SenderInfo": "bprxmjywyxkmivs6il2tof0z/1tbiqh-39lr7rMMLQQAAsw", "Subject": "[dpdk-dev] [PATCH v2] net/virtio-user: fix run close(0) and close\n\tcallfd", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jiawei Zhu <zhujiawei12@huawei.com>\n\nWhen i < VIRTIO_MAX_VIRTQUEUES and j == i,\ndev->callfds[i] and dev->kickfds[i] are default 0.\nSo it will close(0), close the standard input (stdin).\nAnd when the code fails in kickfd creation,\nit will leaves one callfd not closed.\n\nFixes: e6e7ad8b3024 (\"net/virtio-user: move eventfd open/close into init/uninit\")\nCc: stable@dpdk.org:\n\nSigned-off-by: Jiawei Zhu <zhujiawei12@huawei.com>\n---\nv2:\n* Add close callfd when fail in kickfd creation before break.\n---\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 053f026..e1cbad0 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -276,6 +276,7 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)\n \t\t}\n \t\tkickfd = eventfd(0, EFD_CLOEXEC | EFD_NONBLOCK);\n \t\tif (kickfd < 0) {\n+\t\t\tclose(callfd);\n \t\t\tPMD_DRV_LOG(ERR, \"kickfd error, %s\", strerror(errno));\n \t\t\tbreak;\n \t\t}\n@@ -284,7 +285,7 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)\n \t}\n \n \tif (i < VIRTIO_MAX_VIRTQUEUES) {\n-\t\tfor (j = 0; j <= i; ++j) {\n+\t\tfor (j = 0; j < i; ++j) {\n \t\t\tclose(dev->callfds[j]);\n \t\t\tclose(dev->kickfds[j]);\n \t\t}\n", "prefixes": [ "v2" ] }